-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove refcounting (reland of #3356) #3405
Merged
BroderickCarlin
merged 3 commits into
project-chip:master
from
mspang:for-chip/remove-unified-config2
Oct 26, 2020
Merged
Remove refcounting (reland of #3356) #3405
BroderickCarlin
merged 3 commits into
project-chip:master
from
mspang:for-chip/remove-unified-config2
Oct 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs a re-think; there are several problems currently: - refcounting of objects with static storage duration - refcounting of objects with automatic storage duration (stack objects) - refcounting of subobjects - including multiple base class subobjects (diamond inheritance) The majority of current uses are in contexts where lifetime could not be extended by reference counting and in general, the initial reference is not dropped. The remaining case looks like a case of unique ownership. If delegate interfaces really need to be refcounted, we'll need to ban multiple inheritance of them (without resorting to virtual inheritance). Reland with some #include needed after project-chip#3397. fixes project-chip#3348
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
rwalker-apple and
saurabhst
October 22, 2020 20:48
bzbarsky-apple
approved these changes
Oct 22, 2020
rwalker-apple
approved these changes
Oct 22, 2020
Size increase report for "esp32-example-build"
Full report output
|
Size increase report for "nrfconnect-example-build"
Full report output
|
andy31415
approved these changes
Oct 23, 2020
BroderickCarlin
approved these changes
Oct 26, 2020
mspang
added a commit
to mspang/connectedhomeip
that referenced
this pull request
Oct 27, 2020
NetworkProvisioning::Init needs to initialize mDelegate to its first argument. This was dropped unintentionally in project-chip#3405
mspang
added a commit
to mspang/connectedhomeip
that referenced
this pull request
Oct 27, 2020
NetworkProvisioning::Init needs to initialize mDelegate to its first argument. This was dropped unintentionally in project-chip#3405
andy31415
pushed a commit
that referenced
this pull request
Oct 27, 2020
NetworkProvisioning::Init needs to initialize mDelegate to its first argument. This was dropped unintentionally in #3405
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs a re-think; there are several problems currently:
The majority of current uses are in contexts where lifetime could not be
extended by reference counting and in general, the initial reference is
not dropped. The remaining case looks like a case of unique ownership.
If delegate interfaces really need to be refcounted, we'll need to ban
multiple inheritance of them (without resorting to virtual inheritance).
Reland with some #includes needed after #3397.
fixes #3348