Remove reference counting

[mspang]

This needs a re-think; there are several problems currently:

• refcounting of objects with static storage duration
• refcounting of objects with automatic storage duration (stack objects)
• refcounting of subobjects
  • including multiple base class subobjects (diamond inheritance)

The majority of current uses are in contexts where lifetime could not be
extended by reference counting and in general, the initial reference is
not dropped. The remaining case looks like a case of unique ownership.
Remove the refcounting since there does not seem to be a case where
it's needed.

If delegate interfaces really need to be refcounted, we'll need to ban
multiple inheritance of them (without resorting to virtual inheritance).

[github-actions]

Size increase report for "nrfconnect-example-build"

File	Section	File	VM
chip-lock.elf	datas	-4	-4
chip-lock.elf	devices	-4	-4
chip-lock.elf	bss	0	-13
chip-lock.elf	[LOAD #3 [RW]]	0	-19
chip-lock.elf	text	-448	-448
chip-lighting.elf	[LOAD #3 [RW]]	0	27
chip-lighting.elf	datas	-4	-4
chip-lighting.elf	devices	-4	-4
chip-lighting.elf	bss	0	-27
chip-lighting.elf	text	-448	-448

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.shstrtab,0,3
datas,-4,-4
devices,-4,-4
bss,-13,0
[LOAD #3 [RW]],-19,0
.debug_aranges,0,-40
.symtab,0,-128
.debug_frame,0,-184
.strtab,0,-379
.debug_abbrev,0,-388
.debug_ranges,0,-432
text,-448,-448
.debug_line,0,-1374
.debug_loc,0,-1417
.debug_str,0,-4271
.debug_info,0,-9494

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
[LOAD #3 [RW]],27,0
.shstrtab,0,-1
datas,-4,-4
devices,-4,-4
bss,-27,0
.debug_aranges,0,-40
.symtab,0,-128
.debug_frame,0,-184
.strtab,0,-379
.debug_abbrev,0,-388
.debug_ranges,0,-432
text,-448,-448
.debug_line,0,-1374
.debug_loc,0,-1425
.debug_str,0,-4271
.debug_info,0,-9494

[github-actions]

Size increase report for "esp32-example-build"

File	Section	File	VM
chip-wifi-echo.elf	.dram0.bss	0	-8
chip-wifi-echo.elf	.flash.text	-236	-236

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize
.xt.prop._ZN4chip8Encoding12LittleEndian7Write32ERPhj,0,-1
.dram0.bss,-8,0
.debug_aranges,0,-16
.debug_ranges,0,-40
.xt.prop._ZN4chip8BufBound3PutEPKvj,0,-40
.xt.prop._ZN4chip9Transport19PeerConnectionStateC5Ev,0,-40
.debug_frame,0,-48
.xt.prop._ZN4chip16ReferenceCountedINS_28SecurePairingSessionDelegateENS_13DeleteDeletorIS1_EEE7ReleaseEv,0,-88
.xt.prop._ZN4chip16ReferenceCountedINS_9Transport4BaseENS_13DeleteDeletorIS2_EEE7ReleaseEv,0,-88
.symtab,0,-96
.strtab,0,-179
.flash.text,-236,-236
.debug_abbrev,0,-256
.shstrtab,0,-393
.debug_loc,0,-743
.debug_line,0,-1165
.debug_str,0,-2654
.debug_info,0,-4909

[mspang]

This is not technically needed to fix #3348, I uploaded a targeted fix for that in #3357.

With that bug fixed, AIUI these refcounts will generally not become zero, so managing them is not really unsafe - just confusing. It's dead code.

[andy31415]

We really need some saner (auto_ptr-like or unique_ptr-like) reference management. Manually Retain/AddRef/Release/RemoveRef does not see easy to keep track off.

[mspang]

@saurabhst @hawk248 @BroderickCarlin @chrisdecenzo @jelderton