Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase dnssd kHostNameMaxLength to 40 bytes #33468

Merged
merged 1 commit into from
May 15, 2024
Merged

Increase dnssd kHostNameMaxLength to 40 bytes #33468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/lib/dnssd/Constants.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,12 @@ namespace Dnssd {
* Matter DNS host settings
*/

inline constexpr size_t kHostNameMaxLength = 16; // MAC or 802.15.4 Extended Address in hex
// Matter spec expects hostname to be MAC or 802.15.4 Extended Address in hex.
// But in latest android nsdManager, it would set hostname with 40 bytes with prefix as android_,
// and there is no existing API to update the hostname, therefore we put temporary workaround with 40 bytes.
// Follow-up with ticket issue https://github.com/project-chip/connectedhomeip/issues/33474
inline constexpr size_t kHostNameMaxLength = 40;
//

/*
* Matter DNS service subtypes
Expand Down
Loading