-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase dnssd kHostNameMaxLength to 40 bytes #33468
Merged
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/fix_mdns_hostname_android
May 15, 2024
Merged
Increase dnssd kHostNameMaxLength to 40 bytes #33468
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/fix_mdns_hostname_android
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhanw-google
force-pushed
the
feature/fix_mdns_hostname_android
branch
from
May 15, 2024 07:39
e482c4b
to
3016369
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
May 15, 2024 07:40
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
May 15, 2024 07:40
PR #33468: Size comparison from f4e02d4 to 3016369 Increases (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (41 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, linux, nrfconnect, nxp, psoc6, qpg, stm32)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
joonhaengHeo
approved these changes
May 15, 2024
mkardous-silabs
approved these changes
May 15, 2024
yunhanw-google
force-pushed
the
feature/fix_mdns_hostname_android
branch
from
May 15, 2024 17:44
3016369
to
14422a2
Compare
yunhanw-google
force-pushed
the
feature/fix_mdns_hostname_android
branch
from
May 15, 2024 17:45
14422a2
to
4550566
Compare
PR #33468: Size comparison from 83d35a3 to 4550566 Increases above 0.2%:
Increases (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (42 builds for bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nrfconnect, nxp, psoc6, qpg, stm32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
andy31415
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pixel 7, we see nsdManager is advertising host name with 40bytes, in android nsdManager, there is no API to set this hostname.
The below is avahi-browse -r _matter._tcp
= wlan0 IPv6 B6071280809E4E17-000000000001B669 _matter._tcp local
hostname = [Android_25101c8afe6a479387b1d63318378d56.local]
address = [192.168.0.102]
port = [58586]
During ICD check-in test, we see the mdns advertisment from android cannot be resolved in lit icd board because of the the above length issue so that lit cannot send the check-in message,
In order to resolve this issue, we expand the kHostNameMaxLength to 40 in dnssd.