-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs][Test driver]Fix efr32 assert due to missing init #33375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jmartinez-silabs
commented
May 8, 2024
•
edited
Loading
edited
- sl_system_init() was recently moved out of Silabs::GetPlatform().Init() and placed directly in the common app main.cpp. However the test_driver doesn't share that main.cpp and it was missing here.
- renable RTT logs with pw-rcp enable. Both can work together
- Temporarily remove TestExchange from efr32. The whole exchange test set fails on EFR32 seemingly due to event loop mockup that do not work on our platform. TBD [Test Failed] EFR32 TestExchange.cpp asserts #33373
…able. Temporaly remove TestExchange from efr32
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
May 8, 2024 20:19
pullapprove
bot
requested review from
tobiasgraf,
wiba-nordic,
turon,
woody-apple,
vivien-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
May 8, 2024 20:19
pullapprove
bot
added
review - pending
platform
test driver
silabs
messaging
and removed
platform
test driver
silabs
messaging
labels
May 8, 2024
PR #33375: Size comparison from 8edcecd to 599370d Increases (1 build for efr32)
Decreases (2 builds for efr32)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
tcarmelveilleux
approved these changes
May 8, 2024
mkardous-silabs
approved these changes
May 8, 2024
rquidute
pushed a commit
to rquidute/connectedhomeip
that referenced
this pull request
May 9, 2024
…able. Temporaly remove TestExchange from efr32 (project-chip#33375)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.