-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted unit tests in src/controller/tests/data_model from NL to PW. #33371
Merged
mergify
merged 16 commits into
project-chip:master
from
feasel0:feature/unittest--controller-tests-data_model_v2
May 13, 2024
Merged
Converted unit tests in src/controller/tests/data_model from NL to PW. #33371
mergify
merged 16 commits into
project-chip:master
from
feasel0:feature/unittest--controller-tests-data_model_v2
May 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests-data_model_v2
…nto feature/unittest--controller-tests-data_model_v2
…ontext now have SetUp/SetUpTestSuite returning void.
…nto feature/unittest--controller-tests-data_model_v2
PR #33371: Size comparison from 8edcecd to 8958766 Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
…tps://github.com/feasel0/connectedhomeip into feature/unittest--controller-tests-data_model_v2
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic and
dhrishi
May 8, 2024 18:38
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
May 8, 2024 18:38
PR #33371: Size comparison from 8edcecd to 2891d81 Decreases (2 builds for efr32)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33371: Size comparison from 307cffb to 4748f50 Decreases (2 builds for efr32)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
andy31415
reviewed
May 9, 2024
andy31415
reviewed
May 9, 2024
…tps://github.com/feasel0/connectedhomeip into feature/unittest--controller-tests-data_model_v2
PR #33371: Size comparison from 307cffb to 515db18 Increases (78 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (2 builds for linux)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
andy31415
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I converted the unit tests in
src/controller/tests/data_model
to use PW.(For the tests in the parent directory
src/controller/tests
, see PR #33351)In the NL version the tests were executed in a different order than they were defined (whereas in PW they execute in the order of definition). Normally this shouldn't matter, so I opted to leave the order of definition unchanged so as to reduce the code delta. But there was one exception; one of the tests seems to be order-dependent.
TestReadSubscribeAttributeResponseWithVersionOnlyCache
must execute beforeTestReadSubscribeAttributeResponseWithCache
or else it fails one of its EXPECTs. In particular this one:EXPECT_TRUE(version1.HasValue() && (version1.Value() == 0));
version1.Value()
returns2
if this test is done afterTestReadSubscribeAttributeResponseWithCache
or0
if this test is done before it.I added a comment to the code noting this order-dependence, but we should eventually take a look at why this is happening.