-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests for BLE layer class #33359
Conversation
PR #33359: Size comparison from e887e58 to eeeef54 Increases (2 builds for mbed, stm32)
Full report (4 builds for cc32xx, mbed, stm32)
|
PR #33359: Size comparison from e887e58 to 5a0bc36 Increases above 0.2%:
Increases (40 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
Decreases (1 build for linux)
Full report (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
PR #33359: Size comparison from e887e58 to a3a3bbf Increases (2 builds for mbed, stm32)
Full report (4 builds for cc32xx, mbed, stm32)
|
PR #33359: Size comparison from 8edcecd to 86ff531 Increases (7 builds for mbed, nrfconnect, qpg, stm32)
Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
PR #33359: Size comparison from 8edcecd to 55d7dcc Increases above 0.2%:
Increases (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (1 build for linux)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33359: Size comparison from 8edcecd to 165e976 Increases above 0.2%:
Increases (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (1 build for linux)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the error return fix in Handle* including HandleWriteReceived
PR #33359: Size comparison from 8edcecd to eb72c8d Increases above 0.2%:
Increases (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (1 build for linux)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Problem
There are no unit tests for functionality in BleLayer.cpp
Changes
BleLayer
classfalse
in case of error in allHandle*
functionsTesting
Manually verified linux-linux BLE commissioning after changes.