[Python] Eliminate ZCLSubscribeAttribute #33337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use asyncio Event and wait_for to wait for the change and continue immediately when received.
|
PR #33337: Size comparison from b791b75 to c049dcd Full report (14 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, qpg, stm32)
|
The current test implementation starves the asyncio event loop by synchronously waiting for the threading.Condition. This prevents making the SubscriptionTransaction fully leveraging the async paradigm. It probably would be possible to mix asyncio.sleep() and threading, but instead embrace the async pradigm for this test.
agners
force-pushed
the
eliminate-zcl-subscribe-attribute
branch
from
c049dcd to
b046a7b
Compare
agners
changed the title
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #33337: Size comparison from 242accd to 61c21d5 Decreases (2 builds for efr32)
Full report (77 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
yunhanw-google
approved these changes
May 7, 2024
|
PR #33337: Size comparison from 242accd to a4c38a9 Decreases (2 builds for efr32)
Full report (77 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
tehampson
reviewed
May 7, 2024
agners
force-pushed
the
eliminate-zcl-subscribe-attribute
branch
2 times, most recently
from
479b23a to
26c1270
Compare
|
PR #33337: Size comparison from 8edcecd to 26c1270 Decreases (2 builds for efr32)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
agners
force-pushed
the
eliminate-zcl-subscribe-attribute
branch
from
26c1270 to
887a8e7
Compare
|
PR #33337: Size comparison from 1dd9495 to 887a8e7 Decreases (2 builds for efr32)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
The current test implementation starves the asyncio event loop by synchronously waiting for the threading.Condition. This prevents making the SubscriptionTransaction fully leveraging the async paradigm. It probably would be possible to mix asyncio.sleep() and threading, but instead embrace the async pradigm for this test.
Eliminate use of ZCLSubscribeAttribute and embrace asyncio.
Eliminate use of ZCLSubscribeAttribute and embrace asyncio.
Use ReadAttribute with asyncio in subscription_resumption_timeout_test as well.
agners
force-pushed
the
eliminate-zcl-subscribe-attribute
branch
from
887a8e7 to
8d4914f
Compare
|
PR #33337: Size comparison from 0d67568 to 8d4914f Decreases (2 builds for efr32)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
tehampson
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates use of ZCLSubscribeAttribute and improves some tests using asyncio.