Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scenes] AttributeValue refactor #33260

Merged
merged 9 commits into from
Jul 5, 2024
Merged

[Scenes] AttributeValue refactor #33260

merged 9 commits into from
Jul 5, 2024

Conversation

lpbeliveau-silabs
Copy link
Contributor

Updated scene.xml AttributeValuePairStruct to match the spec.
Updated scene handlers and test scripts to use the new valueUnsigned* instead of AttributeValue.

@lpbeliveau-silabs lpbeliveau-silabs force-pushed the bugfix/scenes-attributeValue-refactor branch from 3158f7d to bc0e0a9 Compare May 6, 2024 16:48
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024 •
edited
Loading

PR #33260: Size comparison from bf73003 to bc0e0a9

Increases above 0.2%:

platform target config section bf73003 bc0e0a9 change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read/write) 177612 180516 2904 1.6
.bss 99556 102460 2904 2.9
cyw30739 light cyw930739m2evb_01 (read/write) 571551 575423 3872 0.7
.bss 64932 67836 2904 4.5
efr32 lighting-app BRD4187C (read/write) 1070820 1074684 3864 0.4
.bss 180008 182912 2904 1.6
esp32 all-clusters-app c3devkit .dram0.bss 74592 77480 2888 3.9
m5stack (read/write) 537708 540612 2904 0.5
.dram0.bss 81344 84248 2904 3.6
linux all-clusters-app debug (read/write) 483976 487080 3104 0.6
.bss 136000 138880 2880 2.1
all-clusters-minimal-app debug (read/write) 239928 242808 2880 1.2
.bss 128864 131744 2880 2.2
lighting-app debug+rpc+ui (read/write) 229640 232520 2880 1.3
.bss 120336 123216 2880 2.4
shell debug (read only) 2997553 3004961 7408 0.2
(read/write) 159408 162288 2880 1.8
.bss 63504 66384 2880 4.5
.text 2628610 2635986 7376 0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1060320 1064144 3824 0.4
bss 139123 142019 2896 2.1
nrf7002dk_nrf5340_cpuapp (read/write) 1237840 1241712 3872 0.3
bss 137419 140315 2896 2.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1008112 1011856 3744 0.4
bss 138029 140925 2896 2.1
psoc6 all-clusters cy8ckit_062s2_43012 .bss 204308 207212 2904 1.4
all-clusters-minimal cy8ckit_062s2_43012 .bss 201236 204140 2904 1.4
light cy8ckit_062s2_43012 (read/write) 1666572 1670964 4392 0.3
.bss 194700 197604 2904 1.5
stm32 light STM32WB5MM-DK (read/write) 605817 609737 3920 0.6
.bss 128492 131396 2904 2.3
.text 386376 387392 1016 0.3
telink all-clusters-app tlsr9518adk80d (read/write) 1096480 1100520 4040 0.4
bss 101544 104440 2896 2.9
all-clusters-minimal-app tlsr9528a (read/write) 1058956 1063044 4088 0.4
bss 110040 112936 2896 2.6
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read/write) 1090796 1094928 4132 0.4
bss 99868 102760 2892 2.9
Increases (22 builds for cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, stm32, telink)
platform target config section bf73003 bc0e0a9 change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 798356 799332 976 0.1
(read/write) 177612 180516 2904 1.6
.bss 99556 102460 2904 2.9
.text 713168 714144 976 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 571551 575423 3872 0.7
.app_xip_area 461437 462405 968 0.2
.bss 64932 67836 2904 4.5
efr32 lighting-app BRD4187C (read/write) 1070820 1074684 3864 0.4
.bss 180008 182912 2904 1.6
.text 887360 888320 960 0.1
esp32 all-clusters-app c3devkit (read only) 1214950 1216126 1176 0.1
(read/write) 1751296 1754192 2896 0.2
.dram0.bss 74592 77480 2888 3.9
.flash.text 1214950 1216126 1176 0.1
m5stack (read only) 1256655 1257551 896 0.1
(read/write) 537708 540612 2904 0.5
.dram0.bss 81344 84248 2904 3.6
.flash.text 1250491 1251387 896 0.1
linux all-clusters-app debug (read only) 6026009 6032737 6728 0.1
(read/write) 483976 487080 3104 0.6
.bss 136000 138880 2880 2.1
.data.rel.ro 335960 336184 224 0.1
.rodata 353072 353200 128 0.0
.text 5234291 5240723 6432 0.1
all-clusters-minimal-app debug (read only) 5309529 5316985 7456 0.1
(read/write) 239928 242808 2880 1.2
.bss 128864 131744 2880 2.2
.rodata 291978 292010 32 0.0
.text 4777715 4785139 7424 0.2
chip-tool debug (read only) 1214514 12152545 7400 0.1
(read/write) 524288 524512 224 0.0
.data.rel.ro 416904 417128 224 0.1
.rodata 453081 453817 736 0.2
.text 10981427 10987923 6496 0.1
chip-tool-ipv6only arm64 (read only) 11473604 11479540 5936 0.1
.data.rel.ro 457000 457224 224 0.0
.rodata 357476 358068 592 0.2
.text 1023151 10236696 5184 0.1
lighting-app debug+rpc+ui (read only) 5623745 5632561 8816 0.2
(read/write) 229640 232520 2880 1.3
.bss 120336 123216 2880 2.4
.rodata 356276 356308 32 0.0
.text 5015619 5024403 8784 0.2
shell debug (read only) 2997553 3004961 7408 0.2
(read/write) 159408 162288 2880 1.8
.bss 63504 66384 2880 4.5
.rodata 189984 190016 32 0.0
.text 2628610 2635986 7376 0.3
tv-casting-app debug (read only) 9983769 9990745 6976 0.1
.rodata 386648 387256 608 0.2
.text 9126275 9132643 6368 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1060320 1064144 3824 0.4
bss 139123 142019 2896 2.1
text 772428 773312 884 0.1
nrf7002dk_nrf5340_cpuapp (read/write) 1237840 1241712 3872 0.3
bss 137419 140315 2896 2.1
rodata 151400 151448 48 0.0
text 798992 799920 928 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1008112 1011856 3744 0.4
bss 138029 140925 2896 2.1
text 733980 734916 936 0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1826836 1830988 4152 0.2
.bss 204308 207212 2904 1.4
.text 1611396 1612644 1248 0.1
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1748108 1752356 4248 0.2
.bss 201236 204140 2904 1.4
.text 1535764 1537108 1344 0.1
light cy8ckit_062s2_43012 (read/write) 1666572 1670964 4392 0.3
.bss 194700 197604 2904 1.5
.text 1460948 1462436 1488 0.1
stm32 light STM32WB5MM-DK (read/write) 605817 609737 3920 0.6
.bss 128492 131396 2904 2.3
.text 386376 387392 1016 0.3
telink all-clusters-app tlsr9518adk80d (read/write) 1096480 1100520 4040 0.4
bss 101544 104440 2896 2.9
text 797478 798590 1112 0.1
all-clusters-minimal-app tlsr9528a (read/write) 1058956 1063044 4088 0.4
bss 110040 112936 2896 2.6
text 772798 773962 1164 0.2
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read/write) 1090796 1094928 4132 0.4
bss 99868 102760 2892 2.9
text 794274 795488 1214 0.2
Decreases (6 builds for efr32, linux, psoc6)
platform target config section bf73003 bc0e0a9 change % change
efr32 lock-app BRD4338a (read/write) 962060 962052 -8 -0.0
.text 700184 700176 -8 -0.0
window-app BRD4187C (read/write) 1137520 1137512 -8 -0.0
.text 969556 969548 -8 -0.0
linux chip-tool-ipv6only arm64 (read/write) 591600 589808 -1792 -0.3
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 826288 823384 -2904 -0.4
all-clusters-minimal cy8ckit_062s2_43012 (read only) 829384 826480 -2904 -0.4
light cy8ckit_062s2_43012 (read only) 836104 833200 -2904 -0.3
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section bf73003 bc0e0a9 change % change
bl602 lighting-app bl602 (read/write) 1444358 1444358 0 0.0
.bss 85744 85744 0 0.0
.data 9512 9512 0 0.0
.rodata 159200 159200 0 0.0
.text 1109240 1109240 0 0.0
bl602+mfd (read/write) 1458782 1458782 0 0.0
.bss 85912 85912 0 0.0
.data 9488 9488 0 0.0
.rodata 158160 158160 0 0.0
.text 1124558 1124558 0 0.0
bl602+rpc (read/write) 1492006 1492006 0 0.0
.bss 93784 93784 0 0.0
.data 9888 9888 0 0.0
.rodata 166768 166768 0 0.0
.text 1140886 1140886 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1210047 1210047 0 0.0
.bss 11185 11185 0 0.0
.data 3704 3704 0 0.0
.rodata 108796 108796 0 0.0
.text 979384 979384 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1220887 1220887 0 0.0
.bss 11361 11361 0 0.0
.data 3688 3688 0 0.0
.rodata 107736 107736 0 0.0
.text 991138 991138 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1301535 1301535 0 0.0
.bss 19669 19669 0 0.0
.data 4248 4248 0 0.0
.rodata 124168 124168 0 0.0
.text 1054092 1054092 0 0.0
bl706-eth (read/write) 1026469 1026469 0 0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 101892 101892 0 0.0
.text 769238 769238 0 0.0
bl706-wifi (read/write) 1261922 1261922 0 0.0
.bss 10645 10645 0 0.0
.data 3704 3704 0 0.0
.rodata 122884 122884 0 0.0
.text 1001916 1001916 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1179388 1179388 0 0.0
.bss 16396 16396 0 0.0
.data 5072 5072 0 0.0
.rodata 102800 102800 0 0.0
.text 972238 972238 0 0.0
bl702l+mfd (read/write) 1191296 1191296 0 0.0
.bss 16572 16572 0 0.0
.data 5048 5048 0 0.0
.rodata 101740 101740 0 0.0
.text 984560 984560 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 798356 799332 976 0.1
(read/write) 177612 180516 2904 1.6
.bss 99556 102460 2904 2.9
.data 3588 3588 0 0.0
.rodata 84924 84924 0 0.0
.text 713168 714144 976 0.1
lock-ftd LP_EM_CC1354P10_6 (read only) 813648 813648 0 0.0
(read/write) 188100 188100 0 0.0
.bss 110044 110044 0 0.0
.data 3588 3588 0 0.0
.rodata 78552 78552 0 0.0
.text 734832 734832 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 802932 802932 0 0.0
(read/write) 182220 182220 0 0.0
.bss 104164 104164 0 0.0
.data 3588 3588 0 0.0
.rodata 105828 105828 0 0.0
.text 696840 696840 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 755212 755212 0 0.0
(read/write) 176588 176588 0 0.0
.bss 98296 98296 0 0.0
.data 3580 3580 0 0.0
.rodata 80580 80580 0 0.0
.text 674368 674368 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 740900 740900 0 0.0
(read/write) 176796 176796 0 0.0
.bss 98520 98520 0 0.0
.data 3572 3572 0 0.0
.rodata 76364 76364 0 0.0
.text 664272 664272 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 605438 605438 0 0.0
(read/write) 209572 209572 0 0.0
.bss 202796 202796 0 0.0
.data 1652 1652 0 0.0
.rodata 89574 89574 0 0.0
.text 513740 513740 0 0.0
lock CC3235SF_LAUNCHXL (read only) 651326 651326 0 0.0
(read/write) 209836 209836 0 0.0
.bss 203200 203200 0 0.0
.data 1516 1516 0 0.0
.rodata 110334 110334 0 0.0
.text 538872 538872 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 571551 575423 3872 0.7
.app_xip_area 461437 462405 968 0.2
.bss 64932 67836 2904 4.5
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 553647 553647 0 0.0
.app_xip_area 438861 438861 0 0.0
.bss 69596 69596 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 574279 574279 0 0.0
.app_xip_area 465661 465661 0 0.0
.bss 63476 63476 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 566855 566855 0 0.0
.app_xip_area 455053 455053 0 0.0
.bss 66580 66580 0 0.0
.data 800 800 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4187C (read/write) 1070820 1074684 3864 0.4
.bss 180008 182912 2904 1.6
.data 3432 3432 0 0.0
.text 887360 888320 960 0.1
lock-app BRD4338a (read/write) 962060 962052 -8 -0.0
.bss 213064 213064 0 0.0
.data 29448 29448 0 0.0
.text 700184 700176 -8 -0.0
window-app BRD4187C (read/write) 1137520 1137512 -8 -0.0
.bss 164608 164608 0 0.0
.data 3336 3336 0 0.0
.text 969556 969548 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1214950 1216126 1176 0.1
(read/write) 1751296 1754192 2896 0.2
.dram0.bss 74592 77480 2888 3.9
.dram0.data 13652 13652 0 0.0
.flash.rodata 253520 253520 0 0.0
.flash.text 1214950 1216126 1176 0.1
.iram0.text 75570 75570 0 0.0
m5stack (read only) 1256655 1257551 896 0.1
(read/write) 537708 540612 2904 0.5
.dram0.bss 81344 84248 2904 3.6
.dram0.data 35196 35196 0 0.0
.flash.rodata 285248 285248 0 0.0
.flash.text 1250491 1251387 896 0.1
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2713421 2713421 0 0.0
(read/write) 132432 132432 0 0.0
.bss 47720 47720 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 76440 76440 0 0.0
.dynamic 608 608 0 0.0
.got 4576 4576 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 186352 186352 0 0.0
.text 2344133 2344133 0 0.0
all-clusters-app debug (read only) 6026009 6032737 6728 0.1
(read/write) 483976 487080 3104 0.6
.bss 136000 138880 2880 2.1
.data 4560 4560 0 0.0
.data.rel.ro 335960 336184 224 0.1
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1440 1440 0 0.0
.rodata 353072 353200 128 0.0
.text 5234291 5240723 6432 0.1
all-clusters-minimal-app debug (read only) 5309529 5316985 7456 0.1
(read/write) 239928 242808 2880 1.2
.bss 128864 131744 2880 2.2
.data 4464 4464 0 0.0
.data.rel.ro 99496 99496 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 291978 292010 32 0.0
.text 4777715 4785139 7424 0.2
bridge-app debug (read only) 4700153 4700153 0 0.0
(read/write) 220840 220840 0 0.0
.bss 119392 119392 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 88464 88464 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 232426 232426 0 0.0
.text 4242307 4242307 0 0.0
chip-tool debug (read only) 1214514 12152545 7400 0.1
(read/write) 524288 524512 224 0.0
.bss 95032 95032 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 416904 417128 224 0.1
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 453081 453817 736 0.2
.text 10981427 10987923 6496 0.1
chip-tool-ipv6only arm64 (read only) 11473604 11479540 5936 0.1
(read/write) 591600 589808 -1792 -0.3
.bss 104008 104008 0 0.0
.data 4520 4520 0 0.0
.data.rel.ro 457000 457224 224 0.0
.dynamic 512 512 0 0.0
.got 17232 17232 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 357476 358068 592 0.2
.text 1023151 10236696 5184 0.1
lighting-app debug+rpc+ui (read only) 5623745 5632561 8816 0.2
(read/write) 229640 232520 2880 1.3
.bss 120336 123216 2880 2.4
.data 4896 4896 0 0.0
.data.rel.ro 96880 96880 0 0.0
.dynamic 672 672 0 0.0
.got 5864 5864 0 0.0
.init 27 27 0 0.0
.init_array 976 976 0 0.0
.rodata 356276 356308 32 0.0
.text 5015619 5024403 8784 0.2
lock-app debug (read only) 4767193 4767193 0 0.0
(read/write) 208032 208032 0 0.0
.bss 114664 114664 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 82472 82472 0 0.0
.dynamic 624 624 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 258346 258346 0 0.0
.text 4292499 4292499 0 0.0
ota-provider-app debug (read only) 4375033 4375033 0 0.0
(read/write) 196504 196504 0 0.0
.bss 114464 114464 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 71712 71712 0 0.0
.dynamic 624 624 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 211178 211178 0 0.0
.text 3966163 3966163 0 0.0
ota-requestor-app debug (read only) 4505737 4505737 0 0.0
(read/write) 200872 200872 0 0.0
.bss 115360 115360 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 74816 74816 0 0.0
.dynamic 624 624 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 217258 217258 0 0.0
.text 4086243 4086243 0 0.0
shell debug (read only) 2997553 3004961 7408 0.2
(read/write) 159408 162288 2880 1.8
.bss 63504 66384 2880 4.5
.data 1424 1424 0 0.0
.data.rel.ro 88640 88640 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 189984 190016 32 0.0
.text 2628610 2635986 7376 0.3
thermostat-no-ble arm64 (read only) 4493948 4493948 0 0.0
(read/write) 248008 248008 0 0.0
.bss 122984 122984 0 0.0
.data 3408 3408 0 0.0
.data.rel.ro 105912 105912 0 0.0
.dynamic 512 512 0 0.0
.got 8960 8960 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 161876 161876 0 0.0
.text 3990872 3990872 0 0.0
tv-app debug (read only) 5823329 5823329 0 0.0
(read/write) 355224 355224 0 0.0
.bss 245136 245136 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 96248 96248 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 296554 296554 0 0.0
.text 5280643 5280643 0 0.0
tv-casting-app debug (read only) 9983769 9990745 6976 0.1
(read/write) 345632 345632 0 0.0
.bss 159448 159448 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 176208 176208 0 0.0
.dynamic 624 624 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 1216 1216 0 0.0
.rodata 386648 387256 608 0.2
.text 9126275 9132643 6368 0.1
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2536744 2536744 0 0.0
.bss 220768 220768 0 0.0
.data 5216 5216 0 0.0
.text 1499428 1499428 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1060320 1064144 3824 0.4
bss 139123 142019 2896 2.1
rodata 101552 101552 0 0.0
text 772428 773312 884 0.1
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1237840 1241712 3872 0.3
bss 137419 140315 2896 2.1
rodata 151400 151448 48 0.0
text 798992 799920 928 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1008112 1011856 3744 0.4
bss 138029 140925 2896 2.1
rodata 88808 88808 0 0.0
text 733980 734916 936 0.1
nxp contact k32w0+release (read only) 576508 576508 0 0.0
(read/write) 83164 83164 0 0.0
.bss 67880 67880 0 0.0
.data 2188 2188 0 0.0
.text 575972 575972 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 704004 704004 0 0.0
.bss 71224 71224 0 0.0
.data 2864 2864 0 0.0
.text 590536 590536 0 0.0
light k32w0+release (read only) 610568 610568 0 0.0
(read/write) 82624 82624 0 0.0
.bss 67320 67320 0 0.0
.data 2208 2208 0 0.0
.text 610032 610032 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 795848 795848 0 0.0
.bss 80760 80760 0 0.0
.data 2064 2064 0 0.0
.text 673656 673656 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 826288 823384 -2904 -0.4
(read/write) 1826836 1830988 4152 0.2
.bss 204308 207212 2904 1.4
.data 2744 2744 0 0.0
.text 1611396 1612644 1248 0.1
all-clusters-minimal cy8ckit_062s2_43012 (read only) 829384 826480 -2904 -0.4
(read/write) 1748108 1752356 4248 0.2
.bss 201236 204140 2904 1.4
.data 2720 2720 0 0.0
.text 1535764 1537108 1344 0.1
light cy8ckit_062s2_43012 (read only) 836104 833200 -2904 -0.3
(read/write) 1666572 1670964 4392 0.3
.bss 194700 197604 2904 1.5
.data 2536 2536 0 0.0
.text 1460948 1462436 1488 0.1
lock cy8ckit_062s2_43012 (read only) 809040 809040 0 0.0
(read/write) 1695220 1695220 0 0.0
.bss 221780 221780 0 0.0
.data 2520 2520 0 0.0
.text 1462532 1462532 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1134164 1134164 0 0.0
.bss 102644 102644 0 0.0
.data 856 856 0 0.0
.text 646544 646544 0 0.0
lock-app qpg6105+debug (read/write) 1094012 1094012 0 0.0
.bss 97316 97316 0 0.0
.data 860 860 0 0.0
.text 606396 606396 0 0.0
stm32 light STM32WB5MM-DK (read/write) 605817 609737 3920 0.6
.bss 128492 131396 2904 2.3
.data 688 688 0 0.0
.rodata 80516 80516 0 0.0
.text 386376 387392 1016 0.3
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 834098 834098 0 0.0
bss 49876 49876 0 0.0
text 624764 624764 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1096480 1100520 4040 0.4
bss 101544 104440 2896 2.9
text 797478 798590 1112 0.1
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1058956 1063044 4088 0.4
bss 110040 112936 2896 2.6
text 772798 773962 1164 0.2
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 914596 914596 0 0.0
bss 92796 92796 0 0.0
text 656400 656400 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 836450 836450 0 0.0
bss 49920 49920 0 0.0
text 627184 627184 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 937280 937280 0 0.0
bss 77532 77532 0 0.0
text 703846 703846 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1090796 1094928 4132 0.4
bss 99868 102760 2892 2.9
text 794274 795488 1214 0.2
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 911576 911576 0 0.0
bss 69200 69200 0 0.0
text 660590 660590 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 933400 933400 0 0.0
bss 92508 92508 0 0.0
text 675386 675386 0 0.0
pump-app tlsr9258a (read only) 52568 52568 0 0.0
(read/write) 831048 831048 0 0.0
bss 58164 58164 0 0.0
text 621228 621228 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 800144 800144 0 0.0
bss 56100 56100 0 0.0
text 599100 599100 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676092 676092 0 0.0
bss 73412 73412 0 0.0
text 461776 461776 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 844318 844318 0 0.0
bss 51548 51548 0 0.0
text 633852 633852 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 858977 858977 0 0.0
bss 59716 59716 0 0.0
text 642640 642640 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 825700 825700 0 0.0
bss 56424 56424 0 0.0
text 618662 618662 0 0.0
window-covering tlsr9258a (read only) 52568 52568 0 0.0
(read/write) 835744 835744 0 0.0
bss 58380 58380 0 0.0
text 623496 623496 0 0.0

@lpbeliveau-silabs lpbeliveau-silabs force-pushed the bugfix/scenes-attributeValue-refactor branch from bc0e0a9 to 9c2af2c Compare May 8, 2024 19:02
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

PR #33260: Size comparison from 8edcecd to 9c2af2c

Full report (19 builds for bl602, bl702, bl702l, cc32xx, mbed, nxp, qpg)
platform target config section 8edcecd 9c2af2c change % change
bl602 lighting-app bl602 (read/write) 1444502 1444502 0 0.0
.bss 85776 85776 0 0.0
.data 9512 9512 0 0.0
.rodata 159200 159200 0 0.0
.text 1109346 1109346 0 0.0
bl602+mfd (read/write) 1458918 1458918 0 0.0
.bss 85952 85952 0 0.0
.data 9488 9488 0 0.0
.rodata 158160 158160 0 0.0
.text 1124664 1124664 0 0.0
bl602+rpc (read/write) 1492142 1492142 0 0.0
.bss 93824 93824 0 0.0
.data 9888 9888 0 0.0
.rodata 166768 166768 0 0.0
.text 1140992 1140992 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1210183 1210183 0 0.0
.bss 11185 11185 0 0.0
.data 3712 3712 0 0.0
.rodata 108796 108796 0 0.0
.text 979480 979480 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1220999 1220999 0 0.0
.bss 11361 11361 0 0.0
.data 3688 3688 0 0.0
.rodata 107736 107736 0 0.0
.text 991234 991234 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1301647 1301647 0 0.0
.bss 19669 19669 0 0.0
.data 4248 4248 0 0.0
.rodata 124168 124168 0 0.0
.text 1054188 1054188 0 0.0
bl706-eth (read/write) 1026377 1026377 0 0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 101892 101892 0 0.0
.text 769114 769114 0 0.0
bl706-wifi (read/write) 1262090 1262090 0 0.0
.bss 10645 10645 0 0.0
.data 3704 3704 0 0.0
.rodata 122884 122884 0 0.0
.text 1002052 1002052 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1179504 1179504 0 0.0
.bss 16396 16396 0 0.0
.data 5072 5072 0 0.0
.rodata 102800 102800 0 0.0
.text 972338 972338 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1190908 1190908 0 0.0
.bss 16572 16572 0 0.0
.data 5056 5056 0 0.0
.rodata 101740 101740 0 0.0
.text 984660 984660 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 605550 605550 0 0.0
(read/write) 209588 209588 0 0.0
.bss 202812 202812 0 0.0
.data 1652 1652 0 0.0
.rodata 89574 89574 0 0.0
.text 513852 513852 0 0.0
lock CC3235SF_LAUNCHXL (read only) 651438 651438 0 0.0
(read/write) 209844 209844 0 0.0
.bss 203208 203208 0 0.0
.data 1516 1516 0 0.0
.rodata 110334 110334 0 0.0
.text 538984 538984 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2536936 2536936 0 0.0
.bss 220808 220808 0 0.0
.data 5216 5216 0 0.0
.text 1499620 1499620 0 0.0
nxp contact k32w0+release (read only) 576668 576668 0 0.0
(read/write) 83172 83172 0 0.0
.bss 67888 67888 0 0.0
.data 2196 2196 0 0.0
.text 576132 576132 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 704220 704220 0 0.0
.bss 71240 71240 0 0.0
.data 2864 2864 0 0.0
.text 590736 590736 0 0.0
light k32w0+release (read only) 610776 610776 0 0.0
(read/write) 82640 82640 0 0.0
.bss 67336 67336 0 0.0
.data 2216 2216 0 0.0
.text 610240 610240 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 796064 796064 0 0.0
.bss 80776 80776 0 0.0
.data 2072 2072 0 0.0
.text 673848 673848 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1134324 1134324 0 0.0
.bss 102636 102636 0 0.0
.data 856 856 0 0.0
.text 646704 646704 0 0.0
lock-app qpg6105+debug (read/write) 1094116 1094116 0 0.0
.bss 97308 97308 0 0.0
.data 868 868 0 0.0
.text 606500 606500 0 0.0

@lpbeliveau-silabs lpbeliveau-silabs force-pushed the bugfix/scenes-attributeValue-refactor branch from 9c2af2c to 89a938b Compare May 8, 2024 19:59
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

PR #33260: Size comparison from 8edcecd to 89a938b

Increases above 0.2%:

platform target config section 8edcecd 89a938b change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read/write) 177644 180188 2544 1.4
.bss 99572 102116 2544 2.6
cyw30739 light CYW30739B2-P5-EVK-01 (read/write) 742035 745459 3424 0.5
.bss 75364 77908 2544 3.4
CYW30739B2-P5-EVK-02 (read/write) 757671 761103 3432 0.5
.bss 77220 79764 2544 3.3
CYW30739B2-P5-EVK-03 (read/write) 757671 761103 3432 0.5
.bss 77220 79764 2544 3.3
CYW930739M2EVB-02 (read/write) 713891 717315 3424 0.5
.bss 70488 73032 2544 3.6
efr32 lighting-app BRD4187C (read/write) 1071116 1074524 3408 0.3
.bss 180016 182560 2544 1.4
esp32 all-clusters-app c3devkit .dram0.bss 74624 77152 2528 3.4
m5stack (read/write) 537748 540292 2544 0.5
.dram0.bss 81384 83928 2544 3.1
linux all-clusters-app debug (read/write) 484008 486728 2720 0.6
.bss 136032 138528 2496 1.8
all-clusters-minimal-app debug (read/write) 239960 242456 2496 1.0
.bss 128896 131392 2496 1.9
lighting-app debug+rpc+ui (read/write) 229672 232168 2496 1.1
.bss 120368 122864 2496 2.1
shell debug (read only) 2998641 3005873 7232 0.2
(read/write) 159408 161904 2496 1.6
.bss 63504 66000 2496 3.9
.text 2629538 2636738 7200 0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1061288 1064648 3360 0.3
bss 139161 141697 2536 1.8
nrf7002dk_nrf5340_cpuapp (read/write) 1238632 1242064 3432 0.3
bss 137517 140053 2536 1.8
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1008928 1012336 3408 0.3
bss 138059 140595 2536 1.8
psoc6 all-clusters cy8ckit_062s2_43012 .bss 204340 206884 2544 1.2
all-clusters-minimal cy8ckit_062s2_43012 .bss 201268 203812 2544 1.3
light cy8ckit_062s2_43012 .bss 194732 197276 2544 1.3
stm32 light STM32WB5MM-DK (read/write) 605993 609473 3480 0.6
.bss 128500 131044 2544 2.0
telink all-clusters-app tlsr9518adk80d (read/write) 1096704 1100328 3624 0.3
bss 101552 104088 2536 2.5
all-clusters-minimal-app tlsr9528a (read/write) 1059196 1062868 3672 0.3
bss 110048 112584 2536 2.3
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read/write) 1091036 1094752 3716 0.3
bss 99876 102408 2532 2.5
Increases (25 builds for cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, stm32, telink)
platform target config section 8edcecd 89a938b change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 798564 799460 896 0.1
(read/write) 177644 180188 2544 1.4
.bss 99572 102116 2544 2.6
.text 713376 714272 896 0.1
cyw30739 light CYW30739B2-P5-EVK-01 (read/write) 742035 745459 3424 0.5
.app_xip_area 660277 661157 880 0.1
.bss 75364 77908 2544 3.4
CYW30739B2-P5-EVK-02 (read/write) 757671 761103 3432 0.5
.app_xip_area 672713 673601 888 0.1
.bss 77220 79764 2544 3.3
CYW30739B2-P5-EVK-03 (read/write) 757671 761103 3432 0.5
.app_xip_area 672713 673601 888 0.1
.bss 77220 79764 2544 3.3
CYW930739M2EVB-02 (read/write) 713891 717315 3424 0.5
.app_xip_area 637065 637945 880 0.1
.bss 70488 73032 2544 3.6
efr32 lighting-app BRD4187C (read/write) 1071116 1074524 3408 0.3
.bss 180016 182560 2544 1.4
.text 887648 888512 864 0.1
esp32 all-clusters-app c3devkit (read only) 1215236 1216334 1098 0.1
(read/write) 1751328 1753856 2528 0.1
.dram0.bss 74624 77152 2528 3.4
.flash.text 1215236 1216334 1098 0.1
m5stack (read only) 1256871 1257787 916 0.1
(read/write) 537748 540292 2544 0.5
.dram0.bss 81384 83928 2544 3.1
.flash.text 1250707 1251623 916 0.1
linux all-clusters-app debug (read only) 6027337 6033889 6552 0.1
(read/write) 484008 486728 2720 0.6
.bss 136032 138528 2496 1.8
.data.rel.ro 335960 336184 224 0.1
.rodata 353424 353552 128 0.0
.text 5235267 5241523 6256 0.1
all-clusters-minimal-app debug (read only) 5310665 5317961 7296 0.1
(read/write) 239960 242456 2496 1.0
.bss 128896 131392 2496 1.9
.rodata 292170 292202 32 0.0
.text 4778659 4785923 7264 0.2
chip-tool debug (read only) 12146297 12153665 7368 0.1
(read/write) 524256 524480 224 0.0
.data.rel.ro 416904 417128 224 0.1
.rodata 453209 453945 736 0.2
.text 10982451 10988915 6464 0.1
chip-tool-ipv6only arm64 (read only) 11474580 11480516 5936 0.1
.data.rel.ro 457000 457224 224 0.0
.rodata 357508 358100 592 0.2
.text 10232440 10237608 5168 0.1
lighting-app debug+rpc+ui (read only) 5624801 5633457 8656 0.2
(read/write) 229672 232168 2496 1.1
.bss 120368 122864 2496 2.1
.rodata 356404 356436 32 0.0
.text 5016547 5025171 8624 0.2
shell debug (read only) 2998641 3005873 7232 0.2
(read/write) 159408 161904 2496 1.6
.bss 63504 66000 2496 3.9
.rodata 190144 190176 32 0.0
.text 2629538 2636738 7200 0.3
tv-casting-app debug (read only) 9985393 9992369 6976 0.1
.rodata 387192 387832 640 0.2
.text 9127331 9133667 6336 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1061288 1064648 3360 0.3
bss 139161 141697 2536 1.8
text 773108 773908 800 0.1
nrf7002dk_nrf5340_cpuapp (read/write) 1238632 1242064 3432 0.3
bss 137517 140053 2536 1.8
rodata 151408 151456 48 0.0
text 799684 800528 844 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1008928 1012336 3408 0.3
bss 138059 140595 2536 1.8
text 734652 735508 856 0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1827028 1830692 3664 0.2
.bss 204340 206884 2544 1.2
.text 1611556 1612676 1120 0.1
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1748300 1752060 3760 0.2
.bss 201268 203812 2544 1.3
.text 1535924 1537140 1216 0.1
light cy8ckit_062s2_43012 (read/write) 1666764 1670668 3904 0.2
.bss 194732 197276 2544 1.3
.text 1461108 1462468 1360 0.1
stm32 light STM32WB5MM-DK (read/write) 605993 609473 3480 0.6
.bss 128500 131044 2544 2.0
.text 386544 387480 936 0.2
telink all-clusters-app tlsr9518adk80d (read/write) 1096704 1100328 3624 0.3
bss 101552 104088 2536 2.5
text 797694 798746 1052 0.1
all-clusters-minimal-app tlsr9528a (read/write) 1059196 1062868 3672 0.3
bss 110048 112584 2536 2.3
text 773034 774138 1104 0.1
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read/write) 1091036 1094752 3716 0.3
bss 99876 102408 2532 2.5
text 794502 795656 1154 0.1
Decreases (6 builds for efr32, linux, psoc6)
platform target config section 8edcecd 89a938b change % change
efr32 lock-app BRD4338a (read/write) 962252 962244 -8 -0.0
.text 700344 700336 -8 -0.0
window-app BRD4187C (read/write) 1137688 1137680 -8 -0.0
.text 969716 969708 -8 -0.0
linux chip-tool-ipv6only arm64 (read/write) 590680 588840 -1840 -0.3
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 826256 823712 -2544 -0.3
all-clusters-minimal cy8ckit_062s2_43012 (read only) 829352 826808 -2544 -0.3
light cy8ckit_062s2_43012 (read only) 836072 833528 -2544 -0.3
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section 8edcecd 89a938b change % change
bl602 lighting-app bl602 (read/write) 1444502 1444502 0 0.0
.bss 85776 85776 0 0.0
.data 9512 9512 0 0.0
.rodata 159200 159200 0 0.0
.text 1109346 1109346 0 0.0
bl602+mfd (read/write) 1458918 1458918 0 0.0
.bss 85952 85952 0 0.0
.data 9488 9488 0 0.0
.rodata 158160 158160 0 0.0
.text 1124664 1124664 0 0.0
bl602+rpc (read/write) 1492142 1492142 0 0.0
.bss 93824 93824 0 0.0
.data 9888 9888 0 0.0
.rodata 166768 166768 0 0.0
.text 1140992 1140992 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1210183 1210183 0 0.0
.bss 11185 11185 0 0.0
.data 3712 3712 0 0.0
.rodata 108796 108796 0 0.0
.text 979480 979480 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1220999 1220999 0 0.0
.bss 11361 11361 0 0.0
.data 3688 3688 0 0.0
.rodata 107736 107736 0 0.0
.text 991234 991234 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1301647 1301647 0 0.0
.bss 19669 19669 0 0.0
.data 4248 4248 0 0.0
.rodata 124168 124168 0 0.0
.text 1054188 1054188 0 0.0
bl706-eth (read/write) 1026377 1026377 0 0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 101892 101892 0 0.0
.text 769114 769114 0 0.0
bl706-wifi (read/write) 1262090 1262090 0 0.0
.bss 10645 10645 0 0.0
.data 3704 3704 0 0.0
.rodata 122884 122884 0 0.0
.text 1002052 1002052 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1179504 1179504 0 0.0
.bss 16396 16396 0 0.0
.data 5072 5072 0 0.0
.rodata 102800 102800 0 0.0
.text 972338 972338 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1190908 1190908 0 0.0
.bss 16572 16572 0 0.0
.data 5056 5056 0 0.0
.rodata 101740 101740 0 0.0
.text 984660 984660 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 798564 799460 896 0.1
(read/write) 177644 180188 2544 1.4
.bss 99572 102116 2544 2.6
.data 3596 3596 0 0.0
.rodata 84924 84924 0 0.0
.text 713376 714272 896 0.1
lock-ftd LP_EM_CC1354P10_6 (read only) 813856 813856 0 0.0
(read/write) 188116 188116 0 0.0
.bss 110060 110060 0 0.0
.data 3588 3588 0 0.0
.rodata 78552 78552 0 0.0
.text 735040 735040 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 803140 803140 0 0.0
(read/write) 182236 182236 0 0.0
.bss 104180 104180 0 0.0
.data 3588 3588 0 0.0
.rodata 105828 105828 0 0.0
.text 697048 697048 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 755388 755388 0 0.0
(read/write) 176596 176596 0 0.0
.bss 98304 98304 0 0.0
.data 3580 3580 0 0.0
.rodata 80580 80580 0 0.0
.text 674544 674544 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 741116 741116 0 0.0
(read/write) 176828 176828 0 0.0
.bss 98536 98536 0 0.0
.data 3580 3580 0 0.0
.rodata 76364 76364 0 0.0
.text 664488 664488 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 605550 605550 0 0.0
(read/write) 209588 209588 0 0.0
.bss 202812 202812 0 0.0
.data 1652 1652 0 0.0
.rodata 89574 89574 0 0.0
.text 513852 513852 0 0.0
lock CC3235SF_LAUNCHXL (read only) 651438 651438 0 0.0
(read/write) 209844 209844 0 0.0
.bss 203208 203208 0 0.0
.data 1516 1516 0 0.0
.rodata 110334 110334 0 0.0
.text 538984 538984 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 (read/write) 742035 745459 3424 0.5
.app_xip_area 660277 661157 880 0.1
.bss 75364 77908 2544 3.4
.data 932 932 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 757671 761103 3432 0.5
.app_xip_area 672713 673601 888 0.1
.bss 77220 79764 2544 3.3
.data 2276 2276 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 757671 761103 3432 0.5
.app_xip_area 672713 673601 888 0.1
.bss 77220 79764 2544 3.3
.data 2276 2276 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW930739M2EVB-02 (read/write) 713891 717315 3424 0.5
.app_xip_area 637065 637945 880 0.1
.bss 70488 73032 2544 3.6
.data 876 876 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
light-switch CYW30739B2-P5-EVK-01 (read/write) 679551 679551 0 0.0
.app_xip_area 602081 602081 0 0.0
.bss 70956 70956 0 0.0
.data 1052 1052 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 694883 694883 0 0.0
.app_xip_area 614301 614301 0 0.0
.bss 72812 72812 0 0.0
.data 2308 2308 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 694883 694883 0 0.0
.app_xip_area 614301 614301 0 0.0
.bss 72812 72812 0 0.0
.data 2308 2308 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
lock CYW30739B2-P5-EVK-01 (read/write) 698099 698099 0 0.0
.app_xip_area 617613 617613 0 0.0
.bss 74004 74004 0 0.0
.data 1020 1020 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 713503 713503 0 0.0
.app_xip_area 629905 629905 0 0.0
.bss 75860 75860 0 0.0
.data 2276 2276 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 713503 713503 0 0.0
.app_xip_area 629905 629905 0 0.0
.bss 75860 75860 0 0.0
.data 2276 2276 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
thermostat CYW30739B2-P5-EVK-01 (read/write) 660627 660627 0 0.0
.app_xip_area 586173 586173 0 0.0
.bss 68164 68164 0 0.0
.data 828 828 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 676271 676271 0 0.0
.app_xip_area 598609 598609 0 0.0
.bss 70028 70028 0 0.0
.data 2172 2172 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 676271 676271 0 0.0
.app_xip_area 598609 598609 0 0.0
.bss 70028 70028 0 0.0
.data 2172 2172 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
efr32 lighting-app BRD4187C (read/write) 1071116 1074524 3408 0.3
.bss 180016 182560 2544 1.4
.data 3432 3432 0 0.0
.text 887648 888512 864 0.1
lock-app BRD4338a (read/write) 962252 962244 -8 -0.0
.bss 213092 213092 0 0.0
.data 29448 29448 0 0.0
.text 700344 700336 -8 -0.0
window-app BRD4187C (read/write) 1137688 1137680 -8 -0.0
.bss 164608 164608 0 0.0
.data 3344 3344 0 0.0
.text 969716 969708 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1215236 1216334 1098 0.1
(read/write) 1751328 1753856 2528 0.1
.dram0.bss 74624 77152 2528 3.4
.dram0.data 13652 13652 0 0.0
.flash.rodata 253520 253520 0 0.0
.flash.text 1215236 1216334 1098 0.1
.iram0.text 75570 75570 0 0.0
m5stack (read only) 1256871 1257787 916 0.1
(read/write) 537748 540292 2544 0.5
.dram0.bss 81384 83928 2544 3.1
.dram0.data 35196 35196 0 0.0
.flash.rodata 285248 285248 0 0.0
.flash.text 1250707 1251623 916 0.1
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2714541 2714541 0 0.0
(read/write) 132464 132464 0 0.0
.bss 47752 47752 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 76440 76440 0 0.0
.dynamic 608 608 0 0.0
.got 4576 4576 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 186544 186544 0 0.0
.text 2345061 2345061 0 0.0
all-clusters-app debug (read only) 6027337 6033889 6552 0.1
(read/write) 484008 486728 2720 0.6
.bss 136032 138528 2496 1.8
.data 4560 4560 0 0.0
.data.rel.ro 335960 336184 224 0.1
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1440 1440 0 0.0
.rodata 353424 353552 128 0.0
.text 5235267 5241523 6256 0.1
all-clusters-minimal-app debug (read only) 5310665 5317961 7296 0.1
(read/write) 239960 242456 2496 1.0
.bss 128896 131392 2496 1.9
.data 4464 4464 0 0.0
.data.rel.ro 99496 99496 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 292170 292202 32 0.0
.text 4778659 4785923 7264 0.2
bridge-app debug (read only) 4701241 4701241 0 0.0
(read/write) 220872 220872 0 0.0
.bss 119424 119424 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 88464 88464 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 232586 232586 0 0.0
.text 4243235 4243235 0 0.0
chip-tool debug (read only) 12146297 12153665 7368 0.1
(read/write) 524256 524480 224 0.0
.bss 95000 95000 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 416904 417128 224 0.1
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 453209 453945 736 0.2
.text 10982451 10988915 6464 0.1
chip-tool-ipv6only arm64 (read only) 11474580 11480516 5936 0.1
(read/write) 590680 588840 -1840 -0.3
.bss 104008 104008 0 0.0
.data 4520 4520 0 0.0
.data.rel.ro 457000 457224 224 0.0
.dynamic 512 512 0 0.0
.got 17240 17240 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 357508 358100 592 0.2
.text 10232440 10237608 5168 0.1
lighting-app debug+rpc+ui (read only) 5624801 5633457 8656 0.2
(read/write) 229672 232168 2496 1.1
.bss 120368 122864 2496 2.1
.data 4896 4896 0 0.0
.data.rel.ro 96880 96880 0 0.0
.dynamic 672 672 0 0.0
.got 5864 5864 0 0.0
.init 27 27 0 0.0
.init_array 976 976 0 0.0
.rodata 356404 356436 32 0.0
.text 5016547 5025171 8624 0.2
lock-app debug (read only) 4768249 4768249 0 0.0
(read/write) 208032 208032 0 0.0
.bss 114664 114664 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 82472 82472 0 0.0
.dynamic 624 624 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 258474 258474 0 0.0
.text 4293427 4293427 0 0.0
ota-provider-app debug (read only) 4376153 4376153 0 0.0
(read/write) 196568 196568 0 0.0
.bss 114528 114528 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 71712 71712 0 0.0
.dynamic 624 624 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 211370 211370 0 0.0
.text 3967091 3967091 0 0.0
ota-requestor-app debug (read only) 4506857 4506857 0 0.0
(read/write) 200936 200936 0 0.0
.bss 115424 115424 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 74816 74816 0 0.0
.dynamic 624 624 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 217450 217450 0 0.0
.text 4087171 4087171 0 0.0
shell debug (read only) 2998641 3005873 7232 0.2
(read/write) 159408 161904 2496 1.6
.bss 63504 66000 2496 3.9
.data 1424 1424 0 0.0
.data.rel.ro 88640 88640 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 190144 190176 32 0.0
.text 2629538 2636738 7200 0.3
thermostat-no-ble arm64 (read only) 4494860 4494860 0 0.0
(read/write) 247104 247104 0 0.0
.bss 123000 123000 0 0.0
.data 3408 3408 0 0.0
.data.rel.ro 105912 105912 0 0.0
.dynamic 512 512 0 0.0
.got 8968 8968 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 161908 161908 0 0.0
.text 3991720 3991720 0 0.0
tv-app debug (read only) 5824449 5824449 0 0.0
(read/write) 355224 355224 0 0.0
.bss 245136 245136 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 96248 96248 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 296682 296682 0 0.0
.text 5281635 5281635 0 0.0
tv-casting-app debug (read only) 9985393 9992369 6976 0.1
(read/write) 345704 345704 0 0.0
.bss 159512 159512 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 176208 176208 0 0.0
.dynamic 624 624 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 1224 1224 0 0.0
.rodata 387192 387832 640 0.2
.text 9127331 9133667 6336 0.1
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2536936 2536936 0 0.0
.bss 220808 220808 0 0.0
.data 5216 5216 0 0.0
.text 1499620 1499620 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1061288 1064648 3360 0.3
bss 139161 141697 2536 1.8
rodata 101696 101696 0 0.0
text 773108 773908 800 0.1
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1238632 1242064 3432 0.3
bss 137517 140053 2536 1.8
rodata 151408 151456 48 0.0
text 799684 800528 844 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1008928 1012336 3408 0.3
bss 138059 140595 2536 1.8
rodata 88952 88952 0 0.0
text 734652 735508 856 0.1
nxp contact k32w0+release (read only) 576668 576668 0 0.0
(read/write) 83172 83172 0 0.0
.bss 67888 67888 0 0.0
.data 2196 2196 0 0.0
.text 576132 576132 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 704220 704220 0 0.0
.bss 71240 71240 0 0.0
.data 2864 2864 0 0.0
.text 590736 590736 0 0.0
light k32w0+release (read only) 610776 610776 0 0.0
(read/write) 82640 82640 0 0.0
.bss 67336 67336 0 0.0
.data 2216 2216 0 0.0
.text 610240 610240 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 796064 796064 0 0.0
.bss 80776 80776 0 0.0
.data 2072 2072 0 0.0
.text 673848 673848 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 826256 823712 -2544 -0.3
(read/write) 1827028 1830692 3664 0.2
.bss 204340 206884 2544 1.2
.data 2744 2744 0 0.0
.text 1611556 1612676 1120 0.1
all-clusters-minimal cy8ckit_062s2_43012 (read only) 829352 826808 -2544 -0.3
(read/write) 1748300 1752060 3760 0.2
.bss 201268 203812 2544 1.3
.data 2720 2720 0 0.0
.text 1535924 1537140 1216 0.1
light cy8ckit_062s2_43012 (read only) 836072 833528 -2544 -0.3
(read/write) 1666764 1670668 3904 0.2
.bss 194732 197276 2544 1.3
.data 2536 2536 0 0.0
.text 1461108 1462468 1360 0.1
lock cy8ckit_062s2_43012 (read only) 809008 809008 0 0.0
(read/write) 1695428 1695428 0 0.0
.bss 221812 221812 0 0.0
.data 2520 2520 0 0.0
.text 1462708 1462708 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1134324 1134324 0 0.0
.bss 102636 102636 0 0.0
.data 856 856 0 0.0
.text 646704 646704 0 0.0
lock-app qpg6105+debug (read/write) 1094116 1094116 0 0.0
.bss 97308 97308 0 0.0
.data 868 868 0 0.0
.text 606500 606500 0 0.0
stm32 light STM32WB5MM-DK (read/write) 605993 609473 3480 0.6
.bss 128500 131044 2544 2.0
.data 688 688 0 0.0
.rodata 80516 80516 0 0.0
.text 386544 387480 936 0.2
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 834314 834314 0 0.0
bss 49884 49884 0 0.0
text 624976 624976 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1096704 1100328 3624 0.3
bss 101552 104088 2536 2.5
text 797694 798746 1052 0.1
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1059196 1062868 3672 0.3
bss 110048 112584 2536 2.3
text 773034 774138 1104 0.1
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 914836 914836 0 0.0
bss 92804 92804 0 0.0
text 656628 656628 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 836682 836682 0 0.0
bss 49928 49928 0 0.0
text 627396 627396 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 937488 937488 0 0.0
bss 77540 77540 0 0.0
text 704050 704050 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1091036 1094752 3716 0.3
bss 99876 102408 2532 2.5
text 794502 795656 1154 0.1
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 911792 911792 0 0.0
bss 69208 69208 0 0.0
text 660802 660802 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 933648 933648 0 0.0
bss 92516 92516 0 0.0
text 675614 675614 0 0.0
pump-app tlsr9258a (read only) 52568 52568 0 0.0
(read/write) 831280 831280 0 0.0
bss 58172 58172 0 0.0
text 621440 621440 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 800376 800376 0 0.0
bss 56108 56108 0 0.0
text 599312 599312 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676080 676080 0 0.0
bss 73388 73388 0 0.0
text 461778 461778 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 844534 844534 0 0.0
bss 51556 51556 0 0.0
text 634064 634064 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 859201 859201 0 0.0
bss 59724 59724 0 0.0
text 642852 642852 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 825924 825924 0 0.0
bss 56432 56432 0 0.0
text 618874 618874 0 0.0
window-covering tlsr9258a (read only) 52568 52568 0 0.0
(read/write) 835968 835968 0 0.0
bss 58388 58388 0 0.0
text 623708 623708 0 0.0

bzbarsky-apple
bzbarsky-apple reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The crash issues should get fixed here, the rest in followups.

src/app/zap-templates/zcl/data-model/chip/scene.xml Outdated Show resolved Hide resolved
src/app/clusters/on-off-server/on-off-server.cpp Show resolved Hide resolved
src/app/clusters/level-control/level-control.cpp Show resolved Hide resolved
src/app/clusters/level-control/level-control.cpp Show resolved Hide resolved
src/app/tests/suites/certification/Test_TC_S_2_2.yaml Show resolved Hide resolved
src/app/clusters/color-control-server/color-control-server.cpp Outdated Show resolved Hide resolved
@lpbeliveau-silabs lpbeliveau-silabs force-pushed the bugfix/scenes-attributeValue-refactor branch from 7ee42b1 to 0e1f0b4 Compare July 5, 2024 19:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024 •
edited
Loading

PR #33260: Size comparison from d454ffb to 0e1f0b4

Increases above 0.2%:

platform target config section d454ffb 0e1f0b4 change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 RAM 106636 109180 2544 2.4
cyw30739 light CYW30739B2-P5-EVK-01 RAM 75100 77644 2544 3.4
CYW30739B2-P5-EVK-02 RAM 77732 80276 2544 3.3
CYW30739B2-P5-EVK-03 RAM 77732 80276 2544 3.3
CYW930739M2EVB-02 RAM 70168 72712 2544 3.6
nrfconnect all-clusters-app nrf52840dk_nrf52840 RAM 139573 142109 2536 1.8
nrf7002dk_nrf5340_cpuapp RAM 138001 140537 2536 1.8
all-clusters-minimal-app nrf52840dk_nrf52840 RAM 138487 141023 2536 1.8
psoc6 all-clusters cy8ckit_062s2_43012 RAM 207148 209692 2544 1.2
all-clusters-minimal cy8ckit_062s2_43012 RAM 204036 206580 2544 1.2
light cy8ckit_062s2_43012 RAM 197308 199852 2544 1.3
stm32 light STM32WB5MM-DK RAM 141660 144204 2544 1.8
tizen all-clusters-app arm RAM 46004 48540 2536 5.5
Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
platform target config section d454ffb 0e1f0b4 change % change
bl602 lighting-app bl602 FLASH 1271026 1271026 0 0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1285284 1285284 0 0.0
RAM 95472 95472 0 0.0
bl602+rpc FLASH 1309986 1309986 0 0.0
RAM 103752 103752 0 0.0
bl702 lighting-app bl702 FLASH 1091924 1091924 0 0.0
RAM 15265 15265 0 0.0
bl702+mfd FLASH 1102618 1102618 0 0.0
RAM 15417 15417 0 0.0
bl702+rpc FLASH 1181734 1181734 0 0.0
RAM 24285 24285 0 0.0
bl706-eth FLASH 875196 875196 0 0.0
RAM 27376 27376 0 0.0
bl706-wifi FLASH 1127270 1127270 0 0.0
RAM 14709 14709 0 0.0
bl702l lighting-app bl702l FLASH 1078806 1078806 0 0.0
RAM 21836 21836 0 0.0
bl702l+mfd FLASH 1090068 1090068 0 0.0
RAM 21996 21996 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 797084 797972 888 0.1
RAM 106636 109180 2544 2.4
lock-ftd LP_EM_CC1354P10_6 FLASH 816000 816000 0 0.0
RAM 116956 116956 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 807452 807452 0 0.0
RAM 111236 111236 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 760308 760308 0 0.0
RAM 105336 105336 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 746036 746036 0 0.0
RAM 105576 105576 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 605706 605706 0 0.0
RAM 204508 204508 0 0.0
lock CC3235SF_LAUNCHXL FLASH 650734 650734 0 0.0
RAM 204780 204780 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 666225 667113 888 0.1
RAM 75100 77644 2544 3.4
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 686077 686957 880 0.1
RAM 77732 80276 2544 3.3
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 686077 686957 880 0.1
RAM 77732 80276 2544 3.3
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 643013 643901 888 0.1
RAM 70168 72712 2544 3.6
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 608745 608745 0 0.0
RAM 70804 70804 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 628389 628389 0 0.0
RAM 73348 73348 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 628389 628389 0 0.0
RAM 73348 73348 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 624273 624273 0 0.0
RAM 73820 73820 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 643989 643989 0 0.0
RAM 76364 76364 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 643989 643989 0 0.0
RAM 76364 76364 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 592845 592845 0 0.0
RAM 67788 67788 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 612689 612689 0 0.0
RAM 70428 70428 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 612689 612689 0 0.0
RAM 70428 70428 0 0.0
linux chip-tool-ipv6only arm64 unknown 20008 20008 0 0.0
FLASH 10829612 10835356 5744 0.1
RAM 592192 592416 224 0.0
thermostat-no-ble arm64 unknown 9144 9144 0 0.0
FLASH 4167132 4167132 0 0.0
RAM 235640 235640 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1502292 1502292 0 0.0
RAM 226640 226640 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 881364 882144 780 0.1
RAM 139573 142109 2536 1.8
nrf7002dk_nrf5340_cpuapp FLASH 951880 952748 868 0.1
RAM 138001 140537 2536 1.8
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 826896 827748 852 0.1
RAM 138487 141023 2536 1.8
nxp contact k32w0+release FLASH 575916 575916 0 0.0
RAM 70004 70004 0 0.0
k32w1+release FLASH 591144 591144 0 0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 610016 610016 0 0.0
RAM 69480 69480 0 0.0
k32w1+release FLASH 674728 674728 0 0.0
RAM 82816 82816 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1613700 1614804 1104 0.1
RAM 207148 209692 2544 1.2
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534468 1535700 1232 0.1
RAM 204036 206580 2544 1.2
light cy8ckit_062s2_43012 FLASH 1460972 1462348 1376 0.1
RAM 197308 199852 2544 1.3
lock cy8ckit_062s2_43012 FLASH 1462828 1462828 0 0.0
RAM 224380 224380 0 0.0
qpg lighting-app qpg6105+debug FLASH 651052 651052 0 0.0
RAM 104560 104560 0 0.0
lock-app qpg6105+debug FLASH 611168 611168 0 0.0
RAM 99228 99228 0 0.0
stm32 light STM32WB5MM-DK FLASH 472440 473376 936 0.2
RAM 141660 144204 2544 1.8
tizen all-clusters-app arm unknown 1584 1584 0 0.0
FLASH 1633868 1637576 3708 0.2
RAM 46004 48540 2536 5.5
chip-tool-ubsan arm unknown 2384 2384 0 0.0
FLASH 16153886 16168382 14496 0.1
RAM 7097212 7103620 6408 0.1

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024 •
edited
Loading

PR #33260: Size comparison from d454ffb to 69a5fc1

Increases above 0.2%:

platform target config section d454ffb 69a5fc1 change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 RAM 106636 109180 2544 2.4
cyw30739 light CYW30739B2-P5-EVK-01 RAM 75100 77644 2544 3.4
CYW30739B2-P5-EVK-02 RAM 77732 80276 2544 3.3
CYW30739B2-P5-EVK-03 RAM 77732 80276 2544 3.3
CYW930739M2EVB-02 RAM 70168 72712 2544 3.6
efr32 lighting-app BRD4187C RAM 134984 137516 2532 1.9
esp32 all-clusters-app c3devkit DRAM 88332 90860 2528 2.9
m5stack DRAM 114868 117412 2544 2.2
linux all-clusters-app debug RAM 488144 490864 2720 0.6
all-clusters-minimal-app debug RAM 232992 235488 2496 1.1
lighting-app debug+rpc+ui RAM 221600 224096 2496 1.1
shell debug FLASH 2795981 2803773 7792 0.3
RAM 150504 153000 2496 1.7
nrfconnect all-clusters-app nrf52840dk_nrf52840 RAM 139573 142109 2536 1.8
nrf7002dk_nrf5340_cpuapp RAM 138001 140537 2536 1.8
all-clusters-minimal-app nrf52840dk_nrf52840 RAM 138487 141023 2536 1.8
psoc6 all-clusters cy8ckit_062s2_43012 RAM 207148 209692 2544 1.2
all-clusters-minimal cy8ckit_062s2_43012 RAM 204036 206580 2544 1.2
light cy8ckit_062s2_43012 RAM 197308 199852 2544 1.3
stm32 light STM32WB5MM-DK RAM 141660 144204 2544 1.8
telink all-clusters-app tlsr9118bdk40d RAM 145760 148296 2536 1.7
all-clusters-minimal-app tlsr9528a RAM 110580 113116 2536 2.3
lighting-app-ota-factory-data tlsr9118bdk40d RAM 142000 144532 2532 1.8
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d RAM 100404 102936 2532 2.5
tizen all-clusters-app arm RAM 46004 48540 2536 5.5
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section d454ffb 69a5fc1 change % change
bl602 lighting-app bl602 FLASH 1271026 1271026 0 0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1285284 1285284 0 0.0
RAM 95472 95472 0 0.0
bl602+rpc FLASH 1309986 1309986 0 0.0
RAM 103752 103752 0 0.0
bl702 lighting-app bl702 FLASH 1091924 1091924 0 0.0
RAM 15265 15265 0 0.0
bl702+mfd FLASH 1102618 1102618 0 0.0
RAM 15417 15417 0 0.0
bl702+rpc FLASH 1181734 1181734 0 0.0
RAM 24285 24285 0 0.0
bl706-eth FLASH 875196 875196 0 0.0
RAM 27376 27376 0 0.0
bl706-wifi FLASH 1127270 1127270 0 0.0
RAM 14709 14709 0 0.0
bl702l lighting-app bl702l FLASH 1078806 1078806 0 0.0
RAM 21836 21836 0 0.0
bl702l+mfd FLASH 1090068 1090068 0 0.0
RAM 21996 21996 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 797084 797972 888 0.1
RAM 106636 109180 2544 2.4
lock-ftd LP_EM_CC1354P10_6 FLASH 816000 816000 0 0.0
RAM 116956 116956 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 807452 807452 0 0.0
RAM 111236 111236 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 760308 760308 0 0.0
RAM 105336 105336 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 746036 746036 0 0.0
RAM 105576 105576 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 605706 605706 0 0.0
RAM 204508 204508 0 0.0
lock CC3235SF_LAUNCHXL FLASH 650734 650734 0 0.0
RAM 204780 204780 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 666225 667113 888 0.1
RAM 75100 77644 2544 3.4
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 686077 686957 880 0.1
RAM 77732 80276 2544 3.3
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 686077 686957 880 0.1
RAM 77732 80276 2544 3.3
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 643013 643901 888 0.1
RAM 70168 72712 2544 3.6
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 608745 608745 0 0.0
RAM 70804 70804 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 628389 628389 0 0.0
RAM 73348 73348 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 628389 628389 0 0.0
RAM 73348 73348 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 624273 624273 0 0.0
RAM 73820 73820 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 643989 643989 0 0.0
RAM 76364 76364 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 643989 643989 0 0.0
RAM 76364 76364 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 592845 592845 0 0.0
RAM 67788 67788 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 612689 612689 0 0.0
RAM 70428 70428 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 612689 612689 0 0.0
RAM 70428 70428 0 0.0
efr32 lighting-app BRD4187C FLASH 923312 924208 896 0.1
RAM 134984 137516 2532 1.9
lock-app BRD4338a FLASH 733068 733068 0 0.0
RAM 207996 207996 0 0.0
window-app BRD4187C FLASH 1012016 1012016 0 0.0
RAM 129620 129620 0 0.0
esp32 all-clusters-app c3devkit DRAM 88332 90860 2528 2.9
FLASH 1467674 1468738 1064 0.1
IRAM 75570 75570 0 0.0
m5stack DRAM 114868 117412 2544 2.2
FLASH 1536675 1537631 956 0.1
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4592 4592 0 0.0
FLASH 2529008 2529008 0 0.0
RAM 125072 125072 0 0.0
all-clusters-app debug unknown 5368 5368 0 0.0
FLASH 5582574 5588686 6112 0.1
RAM 488144 490864 2720 0.6
all-clusters-minimal-app debug unknown 5288 5288 0 0.0
FLASH 5052856 5060696 7840 0.2
RAM 232992 235488 2496 1.1
bridge-app debug unknown 5256 5256 0 0.0
FLASH 4477208 4477208 0 0.0
RAM 212744 212744 0 0.0
chip-tool debug unknown 5728 5728 0 0.0
FLASH 11713207 11720407 7200 0.1
RAM 543386 543610 224 0.0
chip-tool-ipv6only arm64 unknown 20008 20008 0 0.0
FLASH 10829612 10835356 5744 0.1
RAM 592192 592416 224 0.0
fabric-admin debug unknown 5616 5616 0 0.0
FLASH 10797431 10804871 7440 0.1
RAM 540226 540450 224 0.0
fabric-bridge-app debug unknown 4528 4528 0 0.0
FLASH 4242760 4242760 0 0.0
RAM 198808 198808 0 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5372450 5381570 9120 0.2
RAM 221600 224096 2496 1.1
lock-app debug unknown 5192 5192 0 0.0
FLASH 4540776 4540776 0 0.0
RAM 200240 200240 0 0.0
ota-provider-app debug unknown 4576 4576 0 0.0
FLASH 4196616 4196616 0 0.0
RAM 194520 194520 0 0.0
ota-requestor-app debug unknown 4512 4512 0 0.0
FLASH 4322152 4322152 0 0.0
RAM 199176 199176 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2795981 2803773 7792 0.3
RAM 150504 153000 2496 1.7
thermostat-no-ble arm64 unknown 9144 9144 0 0.0
FLASH 4167132 4167132 0 0.0
RAM 235640 235640 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5604696 5604696 0 0.0
RAM 341760 341760 0 0.0
tv-casting-app debug unknown 5096 5096 0 0.0
FLASH 9882974 9889950 6976 0.1
RAM 400816 400816 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1502292 1502292 0 0.0
RAM 226640 226640 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 881364 882144 780 0.1
RAM 139573 142109 2536 1.8
nrf7002dk_nrf5340_cpuapp FLASH 951880 952748 868 0.1
RAM 138001 140537 2536 1.8
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 826896 827748 852 0.1
RAM 138487 141023 2536 1.8
nxp contact k32w0+release FLASH 575916 575916 0 0.0
RAM 70004 70004 0 0.0
k32w1+release FLASH 591144 591144 0 0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 610016 610016 0 0.0
RAM 69480 69480 0 0.0
k32w1+release FLASH 674728 674728 0 0.0
RAM 82816 82816 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1613700 1614804 1104 0.1
RAM 207148 209692 2544 1.2
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534468 1535700 1232 0.1
RAM 204036 206580 2544 1.2
light cy8ckit_062s2_43012 FLASH 1460972 1462348 1376 0.1
RAM 197308 199852 2544 1.3
lock cy8ckit_062s2_43012 FLASH 1462828 1462828 0 0.0
RAM 224380 224380 0 0.0
qpg lighting-app qpg6105+debug FLASH 651052 651052 0 0.0
RAM 104560 104560 0 0.0
lock-app qpg6105+debug FLASH 611168 611168 0 0.0
RAM 99228 99228 0 0.0
stm32 light STM32WB5MM-DK FLASH 472440 473376 936 0.2
RAM 141660 144204 2544 1.8
telink air-quality-sensor-app tlsr9528a_retention FLASH 632486 632486 0 0.0
RAM 50424 50424 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 657232 658252 1020 0.2
RAM 145760 148296 2536 1.7
all-clusters-minimal-app tlsr9528a FLASH 777548 778650 1102 0.1
RAM 110580 113116 2536 2.3
bridge-app tlsr9258a FLASH 675472 675472 0 0.0
RAM 95200 95200 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 634070 634070 0 0.0
RAM 50468 50468 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 719860 719860 0 0.0
RAM 77044 77044 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 612288 613440 1152 0.2
RAM 142000 144532 2532 1.8
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 800074 801226 1152 0.1
RAM 100404 102936 2532 2.5
lock-app-dfu tlsr9528a FLASH 665634 665634 0 0.0
RAM 69756 69756 0 0.0
ota-requestor-app tlsr9258a FLASH 694802 694802 0 0.0
RAM 94924 94924 0 0.0
pump-app tlsr9518adk80d FLASH 616334 616334 0 0.0
RAM 56848 56848 0 0.0
pump-controller-app tlsr9518adk80d FLASH 606718 606718 0 0.0
RAM 56648 56648 0 0.0
shell tlsr9518adk80d FLASH 466150 466150 0 0.0
RAM 72460 72460 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 640684 640684 0 0.0
RAM 52096 52096 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 650544 650544 0 0.0
RAM 60284 60284 0 0.0
thermostat tlsr9518adk80d FLASH 625608 625608 0 0.0
RAM 56980 56980 0 0.0
window-covering tlsr9118bdk40d FLASH 518834 518834 0 0.0
RAM 97696 97696 0 0.0
tizen all-clusters-app arm unknown 1584 1584 0 0.0
FLASH 1633868 1637576 3708 0.2
RAM 46004 48540 2536 5.5
chip-tool-ubsan arm unknown 2384 2384 0 0.0
FLASH 16153886 16168382 14496 0.1
RAM 7097212 7103620 6408 0.1

@mergify mergify bot merged commit 5a634f5 into project-chip:master Jul 5, 2024
72 checks passed
austina-csa pushed a commit to austina-csa/connectedhomeip that referenced this pull request Jul 10, 2024
@lpbeliveau-silabs @bzbarsky-apple @austina-csa
[Scenes] AttributeValue refactor (project-chip#33260)
ea6e910 
* Refactor AttributeValue to the appropriate Value* in AttributeValueList

* Updated attribute value in test

* Applied comments about typing and commented code, as well as example of colorcontrol in scenes

* Made static check on same type instead of size

* Update src/app/zap-templates/zcl/data-model/chip/scene.xml

Co-authored-by: Boris Zbarsky <[email protected]>

* Added checks for missing values in level control and on off

* Added checks for HasValue in color control apply scene handler

* Added check on out of range values in the level control handler

* Updated Zap generated files

---------

Co-authored-by: Boris Zbarsky <[email protected]>
@lpbeliveau-silabs lpbeliveau-silabs deleted the bugfix/scenes-attributeValue-refactor branch December 10, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 left review comments

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@axelnxp axelnxp Awaiting requested review from axelnxp

@chapongatien chapongatien Awaiting requested review from chapongatien

@doru91 doru91 Awaiting requested review from doru91

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

Assignees
No one assigned
Labels
app controller darwin examples review - approved tests
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpbeliveau-silabs @andy31415 @bzbarsky-apple @jmartinez-silabs