-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable TCP on the MCU based platforms by default. #33232
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
April 29, 2024 20:18
pullapprove
bot
requested review from
yufengwangca,
selissia,
yunhanw-google,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
April 29, 2024 20:19
pullapprove
bot
added
examples
platform
config
and removed
examples
platform
config
labels
Apr 29, 2024
Some of the MCU based platforms had TCP enabled on them without having to use it. Disabling the flag before landing the TCP PR project-chip#30339 to avoid increase in code size. We can assess the need to enable TCP on these platforms later.
pidarped
force-pushed
the
DisableTCPOnMCU
branch
from
April 29, 2024 20:20
203e789
to
4a2743e
Compare
PR #33232: Size comparison from 9db03ee to 4a2743e Decreases (3 builds for efr32, esp32, mbed)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
Apr 29, 2024
tcarmelveilleux
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the MCU based platforms had TCP enabled on them without having to use it.
Disabling the flag before landing the TCP PR #30339 to avoid increase in code size.
We can assess the need to enable TCP on these platforms later.