Skip to content

Commit

Permalink
Disable TCP on the MCU based platforms by default.
Browse files Browse the repository at this point in the history
Some of the MCU based platforms had TCP enabled on them without
having to use it.
Disabling the flag before landing the TCP PR #30339 to avoid
increase in code size.
We can assess the need to enable TCP on these platforms later.
  • Loading branch information
pidarped committed Apr 29, 2024
1 parent 9db03ee commit 4a2743e
Show file tree
Hide file tree
Showing 10 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion config/ameba/args.gni
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ lwip_platform = "external"

chip_build_tests = false

chip_inet_config_enable_tcp_endpoint = true
chip_inet_config_enable_tcp_endpoint = false
chip_inet_config_enable_udp_endpoint = true

chip_config_network_layer_ble = true
Expand Down
2 changes: 1 addition & 1 deletion config/beken/args.gni
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ lwip_platform = "external"

chip_build_tests = false

chip_inet_config_enable_tcp_endpoint = true
chip_inet_config_enable_tcp_endpoint = false
chip_inet_config_enable_udp_endpoint = true

chip_config_network_layer_ble = true
Expand Down
2 changes: 1 addition & 1 deletion config/esp32/args.gni
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ lwip_platform = "external"

#Enabling this causes some error
#chip_inet_config_enable_tun_endpoint = false
chip_inet_config_enable_tcp_endpoint = true
chip_inet_config_enable_tcp_endpoint = false
chip_inet_config_enable_udp_endpoint = true

custom_toolchain = "//third_party/connectedhomeip/config/esp32/toolchain:esp32"
Expand Down
2 changes: 1 addition & 1 deletion config/genio/args.gni
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ lwip_platform = "external"

chip_build_tests = true

chip_inet_config_enable_tcp_endpoint = true
chip_inet_config_enable_tcp_endpoint = false
chip_inet_config_enable_udp_endpoint = true

custom_toolchain = "//third_party/connectedhomeip/config/genio/toolchain:genio"
Expand Down
2 changes: 1 addition & 1 deletion config/mbed/chip-gn/args.gni
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ chip_system_project_config_include = ""
chip_device_project_config_include = ""

chip_inet_config_enable_udp_endpoint = true
chip_inet_config_enable_tcp_endpoint = true
chip_inet_config_enable_tcp_endpoint = false

custom_toolchain = "${chip_root}/config/mbed/chip-gn/toolchain:mbed"
mbedtls_target = "${chip_root}/config/mbed/chip-gn/mbedtls:mbedtls"
Expand Down
2 changes: 1 addition & 1 deletion examples/lighting-app/beken/args.gni
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ lwip_platform = "external"

chip_build_tests = false

chip_inet_config_enable_tcp_endpoint = true
chip_inet_config_enable_tcp_endpoint = false
chip_inet_config_enable_udp_endpoint = true

chip_config_network_layer_ble = true
Expand Down
2 changes: 1 addition & 1 deletion src/platform/ASR/args.gni
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ lwip_platform = "asr"
chip_build_tests = false

chip_inet_config_enable_ipv4 = true
chip_inet_config_enable_tcp_endpoint = true
chip_inet_config_enable_tcp_endpoint = false
chip_inet_config_enable_udp_endpoint = true
2 changes: 1 addition & 1 deletion src/platform/Ameba/args.gni
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ mbedtls_target = "//mbedtls:mbedtls"

chip_build_tests = false
chip_inet_config_enable_tun_endpoint = false
chip_inet_config_enable_tcp_endpoint = true
chip_inet_config_enable_tcp_endpoint = false
chip_inet_config_enable_udp_endpoint = true
2 changes: 1 addition & 1 deletion src/platform/Beken/args.gni
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ mbedtls_target = "//mbedtls:mbedtls"

chip_build_tests = false
chip_inet_config_enable_tun_endpoint = false
chip_inet_config_enable_tcp_endpoint = true
chip_inet_config_enable_tcp_endpoint = false
chip_inet_config_enable_udp_endpoint = true
2 changes: 1 addition & 1 deletion src/platform/bouffalolab/BL602/args.gni
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,5 @@ lwip_platform = "bl602"
chip_build_tests = false
chip_inet_config_enable_dns_resolver = false
chip_inet_config_enable_tun_endpoint = false
chip_inet_config_enable_tcp_endpoint = true
chip_inet_config_enable_tcp_endpoint = false
chip_inet_config_enable_udp_endpoint = true

0 comments on commit 4a2743e

Please sign in to comment.