Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K32W] Fix apply action corner case in OTATlvProcessor interface #33214

Merged
merged 5 commits into from
May 13, 2024

Conversation

marius-alex-tache
Copy link
Contributor

OTATlvProcessor::ApplyAction now has a default implementation, but derived classes are still able to overwrite it.

The flag is used by the default ApplyAction implementation. If something goes wrong during ExitAction of the TLV processor,
then mShouldNotApply should be set to true and the image processor should abort. In this case, the BDX transfer was already finished and calling CancelImageUpdate will not abort the transfer, hence the device will reboot even though it should not have. If ApplyAction fails during HandleApply, then the process will be aborted.

Copy link

github-actions bot commented Apr 29, 2024

PR #33214: Size comparison from 040e5bf to 54239ff

Increases (3 builds for nxp)
platform target config section 040e5bf 54239ff change % change
nxp contact k32w0+release (read only) 575916 575948 32 0.0
.text 575380 575412 32 0.0
light k32w0+release (read only) 609944 609976 32 0.0
.text 609408 609440 32 0.0
k32w1+release (read/write) 795208 795216 8 0.0
.text 673040 673048 8 0.0
Decreases (2 builds for efr32)
platform target config section 040e5bf 54239ff change % change
efr32 lighting-app BRD4187C (read/write) 1069888 1069880 -8 -0.0
.text 886460 886452 -8 -0.0
lock-app BRD4338a (read/write) 963708 963700 -8 -0.0
.text 703528 703520 -8 -0.0
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section 040e5bf 54239ff change % change
bl602 lighting-app bl602 (read/write) 1443554 1443554 0 0.0
.bss 85720 85720 0 0.0
.data 9512 9512 0 0.0
.rodata 159220 159220 0 0.0
.text 1108442 1108442 0 0.0
bl602+mfd (read/write) 1457970 1457970 0 0.0
.bss 85888 85888 0 0.0
.data 9488 9488 0 0.0
.rodata 158180 158180 0 0.0
.text 1123760 1123760 0 0.0
bl602+rpc (read/write) 1491194 1491194 0 0.0
.bss 93760 93760 0 0.0
.data 9888 9888 0 0.0
.rodata 166788 166788 0 0.0
.text 1140088 1140088 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1209379 1209379 0 0.0
.bss 11185 11185 0 0.0
.data 3704 3704 0 0.0
.rodata 108816 108816 0 0.0
.text 978712 978712 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1220219 1220219 0 0.0
.bss 11361 11361 0 0.0
.data 3688 3688 0 0.0
.rodata 107756 107756 0 0.0
.text 990466 990466 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1300867 1300867 0 0.0
.bss 19669 19669 0 0.0
.data 4248 4248 0 0.0
.rodata 124188 124188 0 0.0
.text 1053420 1053420 0 0.0
bl706-eth (read/write) 1025897 1025897 0 0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 101904 101904 0 0.0
.text 768670 768670 0 0.0
bl706-wifi (read/write) 1260758 1260758 0 0.0
.bss 10645 10645 0 0.0
.data 3704 3704 0 0.0
.rodata 122904 122904 0 0.0
.text 1000762 1000762 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1178720 1178720 0 0.0
.bss 16396 16396 0 0.0
.data 5072 5072 0 0.0
.rodata 102820 102820 0 0.0
.text 971566 971566 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1190116 1190116 0 0.0
.bss 16572 16572 0 0.0
.data 5048 5048 0 0.0
.rodata 101760 101760 0 0.0
.text 983888 983888 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 784164 784164 0 0.0
(read/write) 176660 176660 0 0.0
.bss 98604 98604 0 0.0
.data 3588 3588 0 0.0
.rodata 83092 83092 0 0.0
.text 700804 700804 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 800020 800020 0 0.0
(read/write) 187148 187148 0 0.0
.bss 109092 109092 0 0.0
.data 3588 3588 0 0.0
.rodata 77084 77084 0 0.0
.text 722672 722672 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 788884 788884 0 0.0
(read/write) 181268 181268 0 0.0
.bss 103212 103212 0 0.0
.data 3588 3588 0 0.0
.rodata 103996 103996 0 0.0
.text 684620 684620 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 741164 741164 0 0.0
(read/write) 175636 175636 0 0.0
.bss 97344 97344 0 0.0
.data 3580 3580 0 0.0
.rodata 78756 78756 0 0.0
.text 662140 662140 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 726804 726804 0 0.0
(read/write) 175844 175844 0 0.0
.bss 97568 97568 0 0.0
.data 3572 3572 0 0.0
.rodata 74540 74540 0 0.0
.text 651996 651996 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 588198 588198 0 0.0
(read/write) 208372 208372 0 0.0
.bss 201596 201596 0 0.0
.data 1652 1652 0 0.0
.rodata 87654 87654 0 0.0
.text 498424 498424 0 0.0
lock CC3235SF_LAUNCHXL (read only) 634382 634382 0 0.0
(read/write) 208636 208636 0 0.0
.bss 202000 202000 0 0.0
.data 1516 1516 0 0.0
.rodata 108342 108342 0 0.0
.text 523916 523916 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 570847 570847 0 0.0
.app_xip_area 460757 460757 0 0.0
.bss 64908 64908 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 553031 553031 0 0.0
.app_xip_area 438269 438269 0 0.0
.bss 69572 69572 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573607 573607 0 0.0
.app_xip_area 465013 465013 0 0.0
.bss 63452 63452 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 566071 566071 0 0.0
.app_xip_area 454293 454293 0 0.0
.bss 66556 66556 0 0.0
.data 800 800 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4187C (read/write) 1069888 1069880 -8 -0.0
.bss 179976 179976 0 0.0
.data 3432 3432 0 0.0
.text 886460 886452 -8 -0.0
lock-app BRD4338a (read/write) 963708 963700 -8 -0.0
.bss 210528 210528 0 0.0
.data 30288 30288 0 0.0
.text 703528 703520 -8 -0.0
window-app BRD4187C (read/write) 1136556 1136556 0 0.0
.bss 164568 164568 0 0.0
.data 3336 3336 0 0.0
.text 968632 968632 0 0.0
esp32 all-clusters-app c3devkit (read only) 1215526 1215526 0 0.0
(read/write) 1751352 1751352 0 0.0
.dram0.bss 74616 74616 0 0.0
.dram0.data 13652 13652 0 0.0
.flash.rodata 253544 253544 0 0.0
.flash.text 1215526 1215526 0 0.0
.iram0.text 75570 75570 0 0.0
m5stack (read only) 1256751 1256751 0 0.0
(read/write) 537732 537732 0 0.0
.dram0.bss 81368 81368 0 0.0
.dram0.data 35196 35196 0 0.0
.flash.rodata 285248 285248 0 0.0
.flash.text 1250587 1250587 0 0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2654389 2654389 0 0.0
(read/write) 130384 130384 0 0.0
.bss 47016 47016 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 75160 75160 0 0.0
.dynamic 608 608 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 184944 184944 0 0.0
.text 2290165 2290165 0 0.0
all-clusters-app debug (read only) 5969961 5969961 0 0.0
(read/write) 482024 482024 0 0.0
.bss 135328 135328 0 0.0
.data 4560 4560 0 0.0
.data.rel.ro 334712 334712 0 0.0
.dynamic 624 624 0 0.0
.got 5328 5328 0 0.0
.init 27 27 0 0.0
.init_array 1440 1440 0 0.0
.rodata 351920 351920 0 0.0
.text 5182611 5182611 0 0.0
all-clusters-minimal-app debug (read only) 5249761 5249761 0 0.0
(read/write) 238008 238008 0 0.0
.bss 128160 128160 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 98296 98296 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 290570 290570 0 0.0
.text 4722419 4722419 0 0.0
bridge-app debug (read only) 4640569 4640569 0 0.0
(read/write) 218888 218888 0 0.0
.bss 118688 118688 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 87248 87248 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 230794 230794 0 0.0
.text 4187427 4187427 0 0.0
chip-tool debug (read only) 12092225 12092225 0 0.0
(read/write) 523456 523456 0 0.0
.bss 95032 95032 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 416064 416064 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 451673 451673 0 0.0
.text 10931955 10931955 0 0.0
chip-tool-ipv6only arm64 (read only) 11408772 11408772 0 0.0
(read/write) 590952 590952 0 0.0
.bss 104008 104008 0 0.0
.data 4520 4520 0 0.0
.data.rel.ro 456016 456016 0 0.0
.dynamic 512 512 0 0.0
.got 17104 17104 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 356276 356276 0 0.0
.text 10170600 10170600 0 0.0
lighting-app debug+rpc+ui (read only) 5564233 5564233 0 0.0
(read/write) 227656 227656 0 0.0
.bss 119632 119632 0 0.0
.data 4896 4896 0 0.0
.data.rel.ro 95616 95616 0 0.0
.dynamic 672 672 0 0.0
.got 5856 5856 0 0.0
.init 27 27 0 0.0
.init_array 976 976 0 0.0
.rodata 354708 354708 0 0.0
.text 4960787 4960787 0 0.0
lock-app debug (read only) 4706417 4706417 0 0.0
(read/write) 206112 206112 0 0.0
.bss 113960 113960 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 81256 81256 0 0.0
.dynamic 624 624 0 0.0
.got 5168 5168 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 256650 256650 0 0.0
.text 4236483 4236483 0 0.0
ota-provider-app debug (read only) 4315569 4315569 0 0.0
(read/write) 194616 194616 0 0.0
.bss 113760 113760 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 70544 70544 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 209418 209418 0 0.0
.text 3911379 3911379 0 0.0
ota-requestor-app debug (read only) 4446481 4446481 0 0.0
(read/write) 198984 198984 0 0.0
.bss 114656 114656 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 73648 73648 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 215530 215530 0 0.0
.text 4031635 4031635 0 0.0
shell debug (read only) 2939033 2939033 0 0.0
(read/write) 157424 157424 0 0.0
.bss 62800 62800 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 87400 87400 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 188384 188384 0 0.0
.text 2575250 2575250 0 0.0
thermostat-no-ble arm64 (read only) 4438156 4438156 0 0.0
(read/write) 245752 245752 0 0.0
.bss 122264 122264 0 0.0
.data 3408 3408 0 0.0
.data.rel.ro 104520 104520 0 0.0
.dynamic 512 512 0 0.0
.got 8720 8720 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 160388 160388 0 0.0
.text 3940648 3940648 0 0.0
tv-app debug (read only) 5782849 5782849 0 0.0
(read/write) 353816 353816 0 0.0
.bss 244528 244528 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 95432 95432 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 295594 295594 0 0.0
.text 5243187 5243187 0 0.0
tv-casting-app debug (read only) 9908481 9908481 0 0.0
(read/write) 343616 343616 0 0.0
.bss 158744 158744 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 174960 174960 0 0.0
.dynamic 624 624 0 0.0
.got 5040 5040 0 0.0
.init 27 27 0 0.0
.init_array 1216 1216 0 0.0
.rodata 385016 385016 0 0.0
.text 9056275 9056275 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2536312 2536312 0 0.0
.bss 220808 220808 0 0.0
.data 5216 5216 0 0.0
.text 1498996 1498996 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1059928 1059928 0 0.0
bss 139171 139171 0 0.0
rodata 101560 101560 0 0.0
text 771904 771904 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1237136 1237136 0 0.0
bss 137443 137443 0 0.0
rodata 151392 151392 0 0.0
text 798268 798268 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1007360 1007360 0 0.0
bss 138029 138029 0 0.0
rodata 88824 88824 0 0.0
text 733216 733216 0 0.0
nxp contact k32w0+release (read only) 575916 575948 32 0.0
(read/write) 83140 83140 0 0.0
.bss 67856 67856 0 0.0
.data 2188 2188 0 0.0
.text 575380 575412 32 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 703300 703300 0 0.0
.bss 71200 71200 0 0.0
.data 2864 2864 0 0.0
.text 589856 589856 0 0.0
light k32w0+release (read only) 609944 609976 32 0.0
(read/write) 82600 82600 0 0.0
.bss 67296 67296 0 0.0
.data 2208 2208 0 0.0
.text 609408 609440 32 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 795208 795216 8 0.0
.bss 80736 80736 0 0.0
.data 2064 2064 0 0.0
.text 673040 673048 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 832008 832008 0 0.0
(read/write) 1806396 1806396 0 0.0
.bss 198644 198644 0 0.0
.data 2688 2688 0 0.0
.text 1596676 1596676 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 835160 835160 0 0.0
(read/write) 1728284 1728284 0 0.0
.bss 195524 195524 0 0.0
.data 2656 2656 0 0.0
.text 1521716 1521716 0 0.0
light cy8ckit_062s2_43012 (read only) 841880 841880 0 0.0
(read/write) 1647028 1647028 0 0.0
.bss 188988 188988 0 0.0
.data 2472 2472 0 0.0
.text 1447180 1447180 0 0.0
lock cy8ckit_062s2_43012 (read only) 814808 814808 0 0.0
(read/write) 1675692 1675692 0 0.0
.bss 216068 216068 0 0.0
.data 2464 2464 0 0.0
.text 1448772 1448772 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1133492 1133492 0 0.0
.bss 102620 102620 0 0.0
.data 856 856 0 0.0
.text 645872 645872 0 0.0
lock-app qpg6105+debug (read/write) 1093460 1093460 0 0.0
.bss 97292 97292 0 0.0
.data 860 860 0 0.0
.text 605844 605844 0 0.0
stm32 light STM32WB5MM-DK (read/write) 605121 605121 0 0.0
.bss 128468 128468 0 0.0
.data 688 688 0 0.0
.rodata 80532 80532 0 0.0
.text 385688 385688 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 834134 834134 0 0.0
bss 49852 49852 0 0.0
text 624794 624794 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1097260 1097260 0 0.0
bss 101568 101568 0 0.0
text 798216 798216 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1058684 1058684 0 0.0
bss 110016 110016 0 0.0
text 772536 772536 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 914268 914268 0 0.0
bss 92772 92772 0 0.0
text 656084 656084 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 836154 836154 0 0.0
bss 49896 49896 0 0.0
text 626894 626894 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 937040 937040 0 0.0
bss 77508 77508 0 0.0
text 703622 703622 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1090756 1090756 0 0.0
bss 99864 99864 0 0.0
text 794168 794168 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 911368 911368 0 0.0
bss 69176 69176 0 0.0
text 660390 660390 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 933104 933104 0 0.0
bss 92476 92476 0 0.0
text 675102 675102 0 0.0
pump-app tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 833688 833688 0 0.0
bss 58140 58140 0 0.0
text 623872 623872 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 799808 799808 0 0.0
bss 56068 56068 0 0.0
text 598778 598778 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676216 676216 0 0.0
bss 73452 73452 0 0.0
text 461890 461890 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 843998 843998 0 0.0
bss 51524 51524 0 0.0
text 633538 633538 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 858697 858697 0 0.0
bss 59692 59692 0 0.0
text 642368 642368 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 825356 825356 0 0.0
bss 56400 56400 0 0.0
text 618328 618328 0 0.0
window-covering tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 838600 838600 0 0.0
bss 58356 58356 0 0.0
text 626360 626360 0 0.0

OTATlvProcessor::ApplyAction now has a default implementation,
but derived classes are still able to overwrite this.

The flag is used by the default ApplyAction implementation.
If something goes wrong during ExitAction of the TLV processor,
then mShouldNotApply should be set to true and the image processor
should abort. In this case, the BDX transfer was already finished
and calling CancelImageUpdate will not abort the transfer, hence
the device will reboot even though it should not have. If ApplyAction
fails during HandleApply, then the process will be aborted.

Signed-off-by: marius-alex-tache <[email protected]>
During ExitAction, set mShouldNotApply to true if an error occurs.
This ensures that the OTA will be aborted and the device does not
reboot.

Also remove the ApplyAction override, since the default implementation
is enough.

Signed-off-by: marius-alex-tache <[email protected]>
All OTA errors should be prefixed with CHIP_ERROR.

Signed-off-by: marius-alex-tache <[email protected]>
@marius-alex-tache marius-alex-tache force-pushed the k32w-fix-ota-corner-case branch from e3211ff to 0f94347 Compare May 8, 2024 07:45
Copy link

github-actions bot commented May 8, 2024

PR #33214: Size comparison from e887e58 to 0f94347

Increases (3 builds for nxp)
platform target config section e887e58 0f94347 change % change
nxp contact k32w0+release (read only) 576668 576700 32 0.0
.text 576132 576164 32 0.0
light k32w0+release (read only) 610776 610808 32 0.0
.text 610240 610272 32 0.0
k32w1+release (read/write) 796064 796072 8 0.0
.text 673848 673856 8 0.0
Decreases (2 builds for efr32)
platform target config section e887e58 0f94347 change % change
efr32 lock-app BRD4338a (read/write) 962252 962244 -8 -0.0
.text 700344 700336 -8 -0.0
window-app BRD4187C (read/write) 1137688 1137680 -8 -0.0
.text 969716 969708 -8 -0.0
Full report (77 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section e887e58 0f94347 change % change
bl602 lighting-app bl602 (read/write) 1444502 1444502 0 0.0
.bss 85776 85776 0 0.0
.data 9512 9512 0 0.0
.rodata 159200 159200 0 0.0
.text 1109346 1109346 0 0.0
bl602+mfd (read/write) 1458918 1458918 0 0.0
.bss 85952 85952 0 0.0
.data 9488 9488 0 0.0
.rodata 158160 158160 0 0.0
.text 1124664 1124664 0 0.0
bl602+rpc (read/write) 1492142 1492142 0 0.0
.bss 93824 93824 0 0.0
.data 9888 9888 0 0.0
.rodata 166768 166768 0 0.0
.text 1140992 1140992 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1210183 1210183 0 0.0
.bss 11185 11185 0 0.0
.data 3712 3712 0 0.0
.rodata 108796 108796 0 0.0
.text 979480 979480 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1220999 1220999 0 0.0
.bss 11361 11361 0 0.0
.data 3688 3688 0 0.0
.rodata 107736 107736 0 0.0
.text 991234 991234 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1301647 1301647 0 0.0
.bss 19669 19669 0 0.0
.data 4248 4248 0 0.0
.rodata 124168 124168 0 0.0
.text 1054188 1054188 0 0.0
bl706-eth (read/write) 1026377 1026377 0 0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 101892 101892 0 0.0
.text 769114 769114 0 0.0
bl706-wifi (read/write) 1262090 1262090 0 0.0
.bss 10645 10645 0 0.0
.data 3704 3704 0 0.0
.rodata 122884 122884 0 0.0
.text 1002052 1002052 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1179504 1179504 0 0.0
.bss 16396 16396 0 0.0
.data 5072 5072 0 0.0
.rodata 102800 102800 0 0.0
.text 972338 972338 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1190908 1190908 0 0.0
.bss 16572 16572 0 0.0
.data 5056 5056 0 0.0
.rodata 101740 101740 0 0.0
.text 984660 984660 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 798564 798564 0 0.0
(read/write) 177644 177644 0 0.0
.bss 99572 99572 0 0.0
.data 3596 3596 0 0.0
.rodata 84924 84924 0 0.0
.text 713376 713376 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 813856 813856 0 0.0
(read/write) 188116 188116 0 0.0
.bss 110060 110060 0 0.0
.data 3588 3588 0 0.0
.rodata 78552 78552 0 0.0
.text 735040 735040 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 803140 803140 0 0.0
(read/write) 182236 182236 0 0.0
.bss 104180 104180 0 0.0
.data 3588 3588 0 0.0
.rodata 105828 105828 0 0.0
.text 697048 697048 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 755388 755388 0 0.0
(read/write) 176596 176596 0 0.0
.bss 98304 98304 0 0.0
.data 3580 3580 0 0.0
.rodata 80580 80580 0 0.0
.text 674544 674544 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 741116 741116 0 0.0
(read/write) 176828 176828 0 0.0
.bss 98536 98536 0 0.0
.data 3580 3580 0 0.0
.rodata 76364 76364 0 0.0
.text 664488 664488 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 605550 605550 0 0.0
(read/write) 209588 209588 0 0.0
.bss 202812 202812 0 0.0
.data 1652 1652 0 0.0
.rodata 89574 89574 0 0.0
.text 513852 513852 0 0.0
lock CC3235SF_LAUNCHXL (read only) 651438 651438 0 0.0
(read/write) 209844 209844 0 0.0
.bss 203208 203208 0 0.0
.data 1516 1516 0 0.0
.rodata 110334 110334 0 0.0
.text 538984 538984 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 (read/write) 742035 742035 0 0.0
.app_xip_area 660277 660277 0 0.0
.bss 75364 75364 0 0.0
.data 932 932 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 757671 757671 0 0.0
.app_xip_area 672713 672713 0 0.0
.bss 77220 77220 0 0.0
.data 2276 2276 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 757671 757671 0 0.0
.app_xip_area 672713 672713 0 0.0
.bss 77220 77220 0 0.0
.data 2276 2276 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW930739M2EVB-02 (read/write) 713891 713891 0 0.0
.app_xip_area 637065 637065 0 0.0
.bss 70488 70488 0 0.0
.data 876 876 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
light-switch CYW30739B2-P5-EVK-01 (read/write) 679551 679551 0 0.0
.app_xip_area 602081 602081 0 0.0
.bss 70956 70956 0 0.0
.data 1052 1052 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 694883 694883 0 0.0
.app_xip_area 614301 614301 0 0.0
.bss 72812 72812 0 0.0
.data 2308 2308 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 694883 694883 0 0.0
.app_xip_area 614301 614301 0 0.0
.bss 72812 72812 0 0.0
.data 2308 2308 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
lock CYW30739B2-P5-EVK-01 (read/write) 698099 698099 0 0.0
.app_xip_area 617613 617613 0 0.0
.bss 74004 74004 0 0.0
.data 1020 1020 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 713503 713503 0 0.0
.app_xip_area 629905 629905 0 0.0
.bss 75860 75860 0 0.0
.data 2276 2276 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 713503 713503 0 0.0
.app_xip_area 629905 629905 0 0.0
.bss 75860 75860 0 0.0
.data 2276 2276 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
efr32 lighting-app BRD4187C (read/write) 1071116 1071116 0 0.0
.bss 180016 180016 0 0.0
.data 3432 3432 0 0.0
.text 887648 887648 0 0.0
lock-app BRD4338a (read/write) 962252 962244 -8 -0.0
.bss 213092 213092 0 0.0
.data 29448 29448 0 0.0
.text 700344 700336 -8 -0.0
window-app BRD4187C (read/write) 1137688 1137680 -8 -0.0
.bss 164608 164608 0 0.0
.data 3344 3344 0 0.0
.text 969716 969708 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1215236 1215236 0 0.0
(read/write) 1751328 1751328 0 0.0
.dram0.bss 74624 74624 0 0.0
.dram0.data 13652 13652 0 0.0
.flash.rodata 253520 253520 0 0.0
.flash.text 1215236 1215236 0 0.0
.iram0.text 75570 75570 0 0.0
m5stack (read only) 1256871 1256871 0 0.0
(read/write) 537748 537748 0 0.0
.dram0.bss 81384 81384 0 0.0
.dram0.data 35196 35196 0 0.0
.flash.rodata 285248 285248 0 0.0
.flash.text 1250707 1250707 0 0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2714541 2714541 0 0.0
(read/write) 132464 132464 0 0.0
.bss 47752 47752 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 76440 76440 0 0.0
.dynamic 608 608 0 0.0
.got 4576 4576 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 186544 186544 0 0.0
.text 2345061 2345061 0 0.0
all-clusters-app debug (read only) 6027337 6027337 0 0.0
(read/write) 484008 484008 0 0.0
.bss 136032 136032 0 0.0
.data 4560 4560 0 0.0
.data.rel.ro 335960 335960 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1440 1440 0 0.0
.rodata 353424 353424 0 0.0
.text 5235267 5235267 0 0.0
all-clusters-minimal-app debug (read only) 5310665 5310665 0 0.0
(read/write) 239960 239960 0 0.0
.bss 128896 128896 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 99496 99496 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 292170 292170 0 0.0
.text 4778659 4778659 0 0.0
bridge-app debug (read only) 4701241 4701241 0 0.0
(read/write) 220872 220872 0 0.0
.bss 119424 119424 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 88464 88464 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 232586 232586 0 0.0
.text 4243235 4243235 0 0.0
chip-tool debug (read only) 12146297 12146297 0 0.0
(read/write) 524256 524256 0 0.0
.bss 95000 95000 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 416904 416904 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 453209 453209 0 0.0
.text 10982451 10982451 0 0.0
chip-tool-ipv6only arm64 (read only) 11474580 11474580 0 0.0
(read/write) 590680 590680 0 0.0
.bss 104008 104008 0 0.0
.data 4520 4520 0 0.0
.data.rel.ro 457000 457000 0 0.0
.dynamic 512 512 0 0.0
.got 17240 17240 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 357508 357508 0 0.0
.text 10232440 10232440 0 0.0
lighting-app debug+rpc+ui (read only) 5624801 5624801 0 0.0
(read/write) 229672 229672 0 0.0
.bss 120368 120368 0 0.0
.data 4896 4896 0 0.0
.data.rel.ro 96880 96880 0 0.0
.dynamic 672 672 0 0.0
.got 5864 5864 0 0.0
.init 27 27 0 0.0
.init_array 976 976 0 0.0
.rodata 356404 356404 0 0.0
.text 5016547 5016547 0 0.0
lock-app debug (read only) 4768249 4768249 0 0.0
(read/write) 208032 208032 0 0.0
.bss 114664 114664 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 82472 82472 0 0.0
.dynamic 624 624 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 258474 258474 0 0.0
.text 4293427 4293427 0 0.0
ota-provider-app debug (read only) 4376153 4376153 0 0.0
(read/write) 196568 196568 0 0.0
.bss 114528 114528 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 71712 71712 0 0.0
.dynamic 624 624 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 211370 211370 0 0.0
.text 3967091 3967091 0 0.0
ota-requestor-app debug (read only) 4506857 4506857 0 0.0
(read/write) 200936 200936 0 0.0
.bss 115424 115424 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 74816 74816 0 0.0
.dynamic 624 624 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 217450 217450 0 0.0
.text 4087171 4087171 0 0.0
shell debug (read only) 2998641 2998641 0 0.0
(read/write) 159408 159408 0 0.0
.bss 63504 63504 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 88640 88640 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 190144 190144 0 0.0
.text 2629538 2629538 0 0.0
thermostat-no-ble arm64 (read only) 4494860 4494860 0 0.0
(read/write) 247104 247104 0 0.0
.bss 123000 123000 0 0.0
.data 3408 3408 0 0.0
.data.rel.ro 105912 105912 0 0.0
.dynamic 512 512 0 0.0
.got 8968 8968 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 161908 161908 0 0.0
.text 3991720 3991720 0 0.0
tv-app debug (read only) 5824449 5824449 0 0.0
(read/write) 355224 355224 0 0.0
.bss 245136 245136 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 96248 96248 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 296682 296682 0 0.0
.text 5281635 5281635 0 0.0
tv-casting-app debug (read only) 9985393 9985393 0 0.0
(read/write) 345704 345704 0 0.0
.bss 159512 159512 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 176208 176208 0 0.0
.dynamic 624 624 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 1224 1224 0 0.0
.rodata 387192 387192 0 0.0
.text 9127331 9127331 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2536936 2536936 0 0.0
.bss 220808 220808 0 0.0
.data 5216 5216 0 0.0
.text 1499620 1499620 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1061288 1061288 0 0.0
bss 139161 139161 0 0.0
rodata 101696 101696 0 0.0
text 773108 773108 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1238632 1238632 0 0.0
bss 137517 137517 0 0.0
rodata 151408 151408 0 0.0
text 799684 799684 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1008928 1008928 0 0.0
bss 138059 138059 0 0.0
rodata 88952 88952 0 0.0
text 734652 734652 0 0.0
nxp contact k32w0+release (read only) 576668 576700 32 0.0
(read/write) 83172 83172 0 0.0
.bss 67888 67888 0 0.0
.data 2196 2196 0 0.0
.text 576132 576164 32 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 704220 704220 0 0.0
.bss 71240 71240 0 0.0
.data 2864 2864 0 0.0
.text 590736 590736 0 0.0
light k32w0+release (read only) 610776 610808 32 0.0
(read/write) 82640 82640 0 0.0
.bss 67336 67336 0 0.0
.data 2216 2216 0 0.0
.text 610240 610272 32 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 796064 796072 8 0.0
.bss 80776 80776 0 0.0
.data 2072 2072 0 0.0
.text 673848 673856 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 826256 826256 0 0.0
(read/write) 1827028 1827028 0 0.0
.bss 204340 204340 0 0.0
.data 2744 2744 0 0.0
.text 1611556 1611556 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 829352 829352 0 0.0
(read/write) 1748300 1748300 0 0.0
.bss 201268 201268 0 0.0
.data 2720 2720 0 0.0
.text 1535924 1535924 0 0.0
light cy8ckit_062s2_43012 (read only) 836072 836072 0 0.0
(read/write) 1666764 1666764 0 0.0
.bss 194732 194732 0 0.0
.data 2536 2536 0 0.0
.text 1461108 1461108 0 0.0
lock cy8ckit_062s2_43012 (read only) 809008 809008 0 0.0
(read/write) 1695428 1695428 0 0.0
.bss 221812 221812 0 0.0
.data 2520 2520 0 0.0
.text 1462708 1462708 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1134324 1134324 0 0.0
.bss 102636 102636 0 0.0
.data 856 856 0 0.0
.text 646704 646704 0 0.0
lock-app qpg6105+debug (read/write) 1094116 1094116 0 0.0
.bss 97308 97308 0 0.0
.data 868 868 0 0.0
.text 606500 606500 0 0.0
stm32 light STM32WB5MM-DK (read/write) 605993 605993 0 0.0
.bss 128500 128500 0 0.0
.data 688 688 0 0.0
.rodata 80516 80516 0 0.0
.text 386544 386544 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 834314 834314 0 0.0
bss 49884 49884 0 0.0
text 624976 624976 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1096704 1096704 0 0.0
bss 101552 101552 0 0.0
text 797694 797694 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1059196 1059196 0 0.0
bss 110048 110048 0 0.0
text 773034 773034 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 914836 914836 0 0.0
bss 92804 92804 0 0.0
text 656628 656628 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 836682 836682 0 0.0
bss 49928 49928 0 0.0
text 627396 627396 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 937488 937488 0 0.0
bss 77540 77540 0 0.0
text 704050 704050 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1091036 1091036 0 0.0
bss 99876 99876 0 0.0
text 794502 794502 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 911792 911792 0 0.0
bss 69208 69208 0 0.0
text 660802 660802 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 933648 933648 0 0.0
bss 92516 92516 0 0.0
text 675614 675614 0 0.0
pump-app tlsr9258a (read only) 52568 52568 0 0.0
(read/write) 831280 831280 0 0.0
bss 58172 58172 0 0.0
text 621440 621440 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 800376 800376 0 0.0
bss 56108 56108 0 0.0
text 599312 599312 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676080 676080 0 0.0
bss 73388 73388 0 0.0
text 461778 461778 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 844534 844534 0 0.0
bss 51556 51556 0 0.0
text 634064 634064 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 859201 859201 0 0.0
bss 59724 59724 0 0.0
text 642852 642852 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 825924 825924 0 0.0
bss 56432 56432 0 0.0
text 618874 618874 0 0.0
window-covering tlsr9258a (read only) 52568 52568 0 0.0
(read/write) 835968 835968 0 0.0
bss 58388 58388 0 0.0
text 623708 623708 0 0.0

@marius-alex-tache marius-alex-tache changed the title [K32W] Add mShouldNotApply flag in OTATlvProcessor interface [K32W] Fix apply action corner case in OTATlvProcessor interface May 8, 2024
@mergify mergify bot merged commit 3f9bac2 into project-chip:master May 13, 2024
66 checks passed
@marius-alex-tache marius-alex-tache deleted the k32w-fix-ota-corner-case branch October 1, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants