-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Replace all usages of chip::Optional with std::optional in src/lib/dnssd #33200
Merged
mergify
merged 33 commits into
project-chip:master
from
andy31415:more_std_optional_in_dnssd
Apr 30, 2024
Merged
[chore] Replace all usages of chip::Optional with std::optional in src/lib/dnssd #33200
mergify
merged 33 commits into
project-chip:master
from
andy31415:more_std_optional_in_dnssd
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi and
harimau-qirex
April 26, 2024 17:37
PR #33200: Size comparison from 10886ac to b4734e5 Increases above 0.2%:
Increases (47 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, qpg, stm32)
Decreases (39 builds for bl702l, cc32xx, efr32, linux, psoc6, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33200: Size comparison from 10886ac to d25aeba Increases above 0.2%:
Increases (32 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, linux, mbed, nrfconnect, nxp, qpg, stm32)
Decreases (9 builds for bl702l, cc32xx, linux, psoc6)
Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
PR #33200: Size comparison from 10886ac to b670c53 Increases (2 builds for mbed, stm32)
Decreases (2 builds for cc32xx)
Full report (4 builds for cc32xx, mbed, stm32)
|
PR #33200: Size comparison from 10886ac to d5861b8 Increases above 0.2%:
Increases (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, qpg, stm32, telink)
Decreases (39 builds for cc32xx, efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33200: Size comparison from 7bd2409 to 052657c Increases (38 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, linux, nrfconnect, nxp, qpg, stm32)
Decreases (46 builds for bl602, bl702, cc32xx, efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Damian-Nordic
approved these changes
Apr 29, 2024
bzbarsky-apple
approved these changes
Apr 29, 2024
PR #33200: Size comparison from 416f6a3 to 1a68a9b Increases above 0.2%:
Increases (43 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, linux, nrfconnect, nxp, qpg, stm32)
Decreases (40 builds for cc32xx, efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace remaining usages of chip optional in src/lib/dnssd with std::optional.
Expecting some minor flash savings.