-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some interface cleanup and make AttributeValueEncoder/Decoder more similar #33028
Some interface cleanup and make AttributeValueEncoder/Decoder more similar #33028
Conversation
PR #33028: Size comparison from b4a6213 to eb410b4 Increases (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (4 builds for linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "this makes no sense" bit and the AccessingFabricIndex bit are why I'm requesting changes...
src/app/clusters/access-control-server/access-control-server.cpp
Outdated
Show resolved
Hide resolved
PR #33028: Size comparison from b4a6213 to 7a9b56c Increases (6 builds for cc32xx, mbed, qpg, stm32)
Full report (6 builds for cc32xx, mbed, qpg, stm32)
|
PR #33028: Size comparison from b4a6213 to ff78944 Increases (64 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (9 builds for bl602, bl702, bl702l, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33028: Size comparison from 4322a88 to e1d22c6 Increases (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (8 builds for bl602, bl702, bl702l, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
0e398d7
to
448c26d
Compare
PR #33028: Size comparison from 10886ac to 448c26d Increases above 0.2%:
Increases (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (6 builds for bl702, bl702l, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Changes
SubjectDescriptor
. Expectation is that in the future we may want to act based on these descriptors (e.g. if our interfaces are also required to validate access permissions).