Skip to content

Commit

Permalink
Update ZAP to fix codegen for nullable attributes. (#33834)
Browse files Browse the repository at this point in the history
Fixes #33413

MIN_ZAP_VERSION is set differently from the tag being used, because the actual
changeset tagged with that tag is from 2024-06-06, not 2024-06-10.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Aug 20, 2024
1 parent 3cbc17b commit 3934104
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions scripts/setup/zap.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
"mac-amd64",
"windows-amd64"
],
"tags": ["version:2@v2024.04.15-nightly.1"]
"tags": ["version:2@v2024.06.10-nightly.1"]
},
{
"_comment": "Always get the amd64 version on mac until usable arm64 zap build is available",
"path": "fuchsia/third_party/zap/mac-amd64",
"platforms": ["mac-arm64"],
"tags": ["version:2@v2024.04.15-nightly.1"]
"tags": ["version:2@v2024.06.10-nightly.1"]
}
]
}
2 changes: 1 addition & 1 deletion scripts/setup/zap.version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v2024.04.15-nightly
v2024.06.10-nightly
2 changes: 1 addition & 1 deletion scripts/tools/zap/zap_execution.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
# Use scripts/tools/zap/version_update.py to manage ZAP versioning as many
# files may need updating for versions
#
MIN_ZAP_VERSION = '2024.4.15'
MIN_ZAP_VERSION = '2024.6.6'


class ZapTool:
Expand Down

0 comments on commit 3934104

Please sign in to comment.