Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ZAP to fix codegen for nullable attributes. #33834

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Update ZAP to fix codegen for nullable attributes. #33834

merged 1 commit into from
Jun 10, 2024

Conversation

bzbarsky-apple
Copy link
Contributor

Fixes #33413

@bzbarsky-apple
Update ZAP to fix codegen for nullable attributes.
a78c95b 
Fixes project-chip#33413

MIN_ZAP_VERSION is set differently from the tag being used, because the actual
changeset tagged with that tag is from 2024-06-06, not 2024-06-10.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 10, 2024 •
edited
Loading

PR #33834: Size comparison from 17cda5a to a78c95b

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 17cda5a a78c95b change % change
bl602 lighting-app bl602 FLASH 1267840 1267840 0 0.0
RAM 95424 95424 0 0.0
bl602+mfd FLASH 1282118 1282118 0 0.0
RAM 95576 95576 0 0.0
bl602+rpc FLASH 1307062 1307062 0 0.0
RAM 103856 103856 0 0.0
bl702 lighting-app bl702 FLASH 1088740 1088740 0 0.0
RAM 14897 14897 0 0.0
bl702+mfd FLASH 1099434 1099434 0 0.0
RAM 15049 15049 0 0.0
bl702+rpc FLASH 1178564 1178564 0 0.0
RAM 23925 23925 0 0.0
bl706-eth FLASH 871916 871916 0 0.0
RAM 27016 27016 0 0.0
bl706-wifi FLASH 1123682 1123682 0 0.0
RAM 14349 14349 0 0.0
bl702l lighting-app bl702l FLASH 1075626 1075626 0 0.0
RAM 21468 21468 0 0.0
bl702l+mfd FLASH 1086888 1086888 0 0.0
RAM 21628 21628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798044 798044 0 0.0
RAM 103184 103184 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813632 813632 0 0.0
RAM 113664 113664 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 802916 802916 0 0.0
RAM 107784 107784 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 755684 755684 0 0.0
RAM 101884 101884 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 741340 741340 0 0.0
RAM 102132 102132 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 604846 604846 0 0.0
RAM 204608 204608 0 0.0
lock CC3235SF_LAUNCHXL FLASH 650298 650298 0 0.0
RAM 204868 204868 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661693 661693 0 0.0
RAM 74608 74608 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 681545 681545 0 0.0
RAM 77240 77240 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 681545 681545 0 0.0
RAM 77240 77240 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 638473 638473 0 0.0
RAM 69676 69676 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 603765 603765 0 0.0
RAM 70312 70312 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 623401 623401 0 0.0
RAM 72864 72864 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 623401 623401 0 0.0
RAM 72864 72864 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619373 619373 0 0.0
RAM 73328 73328 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 639097 639097 0 0.0
RAM 75880 75880 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 639097 639097 0 0.0
RAM 75880 75880 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 587909 587909 0 0.0
RAM 67296 67296 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 607753 607753 0 0.0
RAM 69928 69928 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 607753 607753 0 0.0
RAM 69928 69928 0 0.0
efr32 lighting-app BRD4187C FLASH 888288 888280 -8 -0.0
RAM 183520 183520 0 0.0
lock-app BRD4338a FLASH 701208 701200 -8 -0.0
RAM 242804 242804 0 0.0
window-app BRD4187C FLASH 968588 968588 0 0.0
RAM 167952 167952 0 0.0
esp32 all-clusters-app c3devkit DRAM 88420 88420 0 0.0
FLASH 1466124 1466124 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114892 114892 0 0.0
FLASH 1535367 1535367 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4576 4576 0 0.0
FLASH 2532240 2532240 0 0.0
RAM 129104 129104 0 0.0
all-clusters-app debug unknown 5344 5344 0 0.0
FLASH 5568382 5568382 0 0.0
RAM 482216 482216 0 0.0
all-clusters-minimal-app debug unknown 5264 5264 0 0.0
FLASH 5052264 5052264 0 0.0
RAM 236792 236792 0 0.0
bridge-app debug unknown 5232 5232 0 0.0
FLASH 4477768 4477768 0 0.0
RAM 216816 216816 0 0.0
chip-tool debug unknown 5744 5744 0 0.0
FLASH 11518679 11518679 0 0.0
RAM 521762 521762 0 0.0
chip-tool-ipv6only arm64 unknown 17384 17384 0 0.0
FLASH 10666900 10666900 0 0.0
RAM 569744 569744 0 0.0
fabric-admin debug unknown 5600 5600 0 0.0
FLASH 11288759 11288759 0 0.0
RAM 515330 515330 0 0.0
fabric-bridge-app debug unknown 5240 5240 0 0.0
FLASH 4347352 4347352 0 0.0
RAM 208864 208864 0 0.0
lighting-app debug+rpc+ui unknown 5864 5864 0 0.0
FLASH 5366002 5366002 0 0.0
RAM 225424 225424 0 0.0
lock-app debug unknown 5184 5184 0 0.0
FLASH 4542616 4542616 0 0.0
RAM 204240 204240 0 0.0
ota-provider-app debug unknown 4552 4552 0 0.0
FLASH 4177528 4177528 0 0.0
RAM 193200 193200 0 0.0
ota-requestor-app debug unknown 4488 4488 0 0.0
FLASH 4301896 4301896 0 0.0
RAM 197712 197712 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2799949 2799949 0 0.0
RAM 154424 154424 0 0.0
thermostat-no-ble arm64 unknown 9160 9160 0 0.0
FLASH 4149604 4149604 0 0.0
RAM 234616 234616 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5588696 5588696 0 0.0
RAM 344872 344872 0 0.0
tv-casting-app debug unknown 5104 5104 0 0.0
FLASH 9567878 9567878 0 0.0
RAM 340288 340288 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497452 1497452 0 0.0
RAM 226168 226168 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 873744 873744 0 0.0
RAM 139225 139225 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 948980 948980 0 0.0
RAM 137653 137653 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 822268 822268 0 0.0
RAM 138123 138123 0 0.0
nxp contact k32w0+release FLASH 575652 575652 0 0.0
RAM 70120 70120 0 0.0
k32w1+release FLASH 590912 590912 0 0.0
RAM 74152 74152 0 0.0
light k32w0+release FLASH 609672 609672 0 0.0
RAM 69596 69596 0 0.0
k32w1+release FLASH 674088 674088 0 0.0
RAM 82904 82904 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1610156 1610156 0 0.0
RAM 207228 207228 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534356 1534356 0 0.0
RAM 204132 204132 0 0.0
light cy8ckit_062s2_43012 FLASH 1460652 1460652 0 0.0
RAM 197412 197412 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462628 1462628 0 0.0
RAM 224476 224476 0 0.0
qpg lighting-app qpg6105+debug FLASH 650656 650656 0 0.0
RAM 104652 104652 0 0.0
lock-app qpg6105+debug FLASH 610348 610348 0 0.0
RAM 99328 99328 0 0.0
stm32 light STM32WB5MM-DK FLASH 472124 472124 0 0.0
RAM 141748 141748 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 625098 625098 0 0.0
RAM 49952 49952 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 600616 600616 0 0.0
RAM 130384 130384 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 770236 770236 0 0.0
RAM 110148 110148 0 0.0
bridge-app tlsr9258a FLASH 668228 668228 0 0.0
RAM 94768 94768 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 626850 626850 0 0.0
RAM 49996 49996 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 713740 713740 0 0.0
RAM 76588 76588 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 558492 558492 0 0.0
RAM 126640 126640 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 793558 793558 0 0.0
RAM 99996 99996 0 0.0
lock-app-dfu tlsr9528a FLASH 660038 660038 0 0.0
RAM 69276 69276 0 0.0
ota-requestor-app tlsr9258a FLASH 687226 687226 0 0.0
RAM 94492 94492 0 0.0
pump-app tlsr9518adk80d FLASH 609050 609050 0 0.0
RAM 56376 56376 0 0.0
pump-controller-app tlsr9518adk80d FLASH 599398 599398 0 0.0
RAM 56176 56176 0 0.0
shell tlsr9518adk80d FLASH 462618 462618 0 0.0
RAM 71852 71852 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 633244 633244 0 0.0
RAM 51624 51624 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 642898 642898 0 0.0
RAM 59812 59812 0 0.0
thermostat tlsr9518adk80d FLASH 618300 618300 0 0.0
RAM 56500 56500 0 0.0
window-covering tlsr9118bdk40d FLASH 464616 464616 0 0.0
RAM 82272 82272 0 0.0
tizen all-clusters-app arm unknown 1552 1552 0 0.0
FLASH 1612948 1612948 0 0.0
RAM 45460 45460 0 0.0
chip-tool-ubsan arm unknown 2360 2360 0 0.0
FLASH 1563540 1563540 0 0.0
RAM 6825656 6825656 0 0.0

@mergify mergify bot merged commit e1b5fbe into project-chip:master Jun 10, 2024
68 checks passed
@bzbarsky-apple bzbarsky-apple deleted the update-zap branch June 10, 2024 23:57
Alami-Amine pushed a commit to Alami-Amine/connectedhomeip that referenced this pull request Jun 12, 2024
@bzbarsky-apple @Alami-Amine
Update ZAP to fix codegen for nullable attributes. (project-chip#33834)
840b0b9 
Fixes project-chip#33413

MIN_ZAP_VERSION is set differently from the tag being used, because the actual
changeset tagged with that tag is from 2024-06-06, not 2024-06-10.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@andy31415 andy31415 Awaiting requested review from andy31415

@arkq arkq Awaiting requested review from arkq

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.3] The default null values from the Thermostat cluster are not correctly set
2 participants
@bzbarsky-apple @andy31415