-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timesync improvements - part 1 #32848
Timesync improvements - part 1 #32848
Conversation
a289027
to
1e5de9c
Compare
PR #32848: Size comparison from 6a7961d to 1e5de9c Increases (10 builds for cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
src/app/clusters/time-synchronization-server/DefaultTimeSyncDelegate.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-delegate.h
Outdated
Show resolved
Hide resolved
PR #32848: Size comparison from 6a7961d to c8196ac Increases (10 builds for cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
src/app/clusters/time-synchronization-server/time-synchronization-delegate.h
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-delegate.h
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-delegate.h
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.h
Show resolved
Hide resolved
c8196ac
to
78e78fb
Compare
PR #32848: Size comparison from bcebbc6 to 78e78fb Increases (10 builds for cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, once @cecille's concerns are addressed.
Thank you for breaking this up into pieces!
- free readclient memory after read is complete
78e78fb
to
049d625
Compare
PR #32848: Size comparison from 5570be9 to 049d625 Increases (10 builds for cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Fixes for issues form #27575 and more: