-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Enable extended ble announcement for esp32 platform #32389
[ESP32] Enable extended ble announcement for esp32 platform #32389
Conversation
PR #32389: Size comparison from bd6866b to b842b9a Increases (2 builds for esp32)
Decreases (4 builds for efr32, esp32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
@sayondeep Please update the PR description about the expected behavior with this feature and the things you've tested. Thanks! |
PR #32389: Size comparison from d8f5bf1 to 845776a Increases (2 builds for esp32)
Decreases (7 builds for bl602, bl702, bl702l, efr32, esp32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32389: Size comparison from c1ae85c to bf0d913 Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
PR #32389: Size comparison from c1ae85c to 1665748 Increases (5 builds for bl602, bl702, bl702l, esp32)
Decreases (4 builds for efr32, esp32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
LGTM |
PR #32389: Size comparison from ea29531 to 79f4e0a Full report (41 builds for cc13x4_26x4, cc32xx, cyw30739, k32w, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32389: Size comparison from d26d2e5 to 21f72d5 Increases (2 builds for esp32)
Decreases (2 builds for efr32, esp32)
Full report (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
PR #32389: Size comparison from 72bd295 to b8d886a Increases (2 builds for esp32)
Decreases (3 builds for efr32, esp32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
@sayondeep Please create a backport PR on this branch https://github.com/espressif/connectedhomeip/tree/v1.3-branch |
…chip#32389) * enable extended ble advertisement for esp32 platform * changed extended advertisement to extended announcement * restlyed * made discoverty timeout range and default dependent on extended announcement. * help section for extended ble announcement * fixed eliding of extended data during extended announcement. * fixed setting of Additional data flag
…deinit crash fix (#33159) * [ESP32] Enable extended ble announcement for esp32 platform (#32389) * enable extended ble advertisement for esp32 platform * changed extended advertisement to extended announcement * restlyed * made discoverty timeout range and default dependent on extended announcement. * help section for extended ble announcement * fixed eliding of extended data during extended announcement. * fixed setting of Additional data flag * [ESP32] Implement BLE Manager Shutdown for nimble host (#33109) * [ESP32] Implement BLE Manager Shutdown for nimble host - Replace ble deinit imple in Esp32AppServer with BLEMgr().Shutdown() - Replace few ESP_LOG with ChipLog in Esp32AppServer - Move ble deinit kCommissioningComplete switch case - Make USE_BLE_ONLY_FOR_COMMISSIONING depends on BT_ENABLED * Restyled by clang-format * address reviews * Add checks for timer handler --------- Co-authored-by: Restyled.io <[email protected]> --------- Co-authored-by: SAYON DEEP <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Extended BLE advertisement was recently introduced in this PR.
This PR enables extended BLE advertisement for ESP32 platform.
The extended BLE advertisement increases the advertisement duration to up to 48 hr before closing the commissioning window.
Tests Performed: