Skip to content

Commit

Permalink
Making this new protocol optional, so as to not break clients (#32676)
Browse files Browse the repository at this point in the history
  • Loading branch information
woody-apple authored Mar 21, 2024
1 parent 88afa33 commit ea29531
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions src/darwin/Framework/CHIP/MTRDeviceController+XPC.h
Original file line number Diff line number Diff line change
Expand Up @@ -94,14 +94,6 @@ typedef void (^MTRValuesHandler)(id _Nullable values, NSError * _Nullable error)
*/
@protocol MTRDeviceControllerServerProtocol <NSObject>

@optional
/**
* Gets device controller ID corresponding to a specific fabric ID
*/
- (void)getDeviceControllerWithFabricId:(uint64_t)fabricId
completion:(MTRDeviceControllerGetterHandler)completion
MTR_DEPRECATED("This never called.", ios(16.1, 16.4), macos(13.0, 13.3), watchos(9.1, 9.4), tvos(16.1, 16.4));

@required
/**
* Gets any available device controller ID
Expand Down Expand Up @@ -184,6 +176,15 @@ typedef void (^MTRValuesHandler)(id _Nullable values, NSError * _Nullable error)
attributeId:(NSNumber * _Nullable)attributeId
completion:(MTRValuesHandler)completion;

@optional

/**
* Gets device controller ID corresponding to a specific fabric ID
*/
- (void)getDeviceControllerWithFabricId:(uint64_t)fabricId
completion:(MTRDeviceControllerGetterHandler)completion
MTR_DEPRECATED("This never called.", ios(16.1, 16.4), macos(13.0, 13.3), watchos(9.1, 9.4), tvos(16.1, 16.4));

/**
* Requests downloading some logs
*/
Expand Down

0 comments on commit ea29531

Please sign in to comment.