Example for nRF5 platform #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan-apple
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
gerickson,
hawk248,
jelderton,
robszewczyk,
tpmanley and
woody-apple
as code owners
woody-apple
reviewed
Apr 9, 2020
woody-apple
requested changes
Apr 9, 2020
|
@woody-apple , the latest commit should cleanup the code, and add copyrights to the modified files. |
|
Can we get a review on these today if possible? |
woody-apple
approved these changes
Apr 10, 2020
hawk248
approved these changes
Apr 10, 2020
|
@BroderickCarlin @jelderton can you take a peek please? @gerickson - can we get eyes on this today so we can make progress? |
suryanshup
reviewed
Apr 13, 2020
|
@jelderton the outstanding review comment is resolved. Is this good to go? |
suryanshup
reviewed
Apr 14, 2020
suryanshup
reviewed
Apr 14, 2020
suryanshup
reviewed
Apr 14, 2020
BroderickCarlin
approved these changes
Apr 14, 2020
suryanshup
reviewed
Apr 14, 2020
suryanshup
reviewed
Apr 14, 2020
suryanshup
reviewed
Apr 14, 2020
suryanshup
reviewed
Apr 14, 2020
suryanshup
approved these changes
Apr 14, 2020
gerickson
approved these changes
Apr 14, 2020
rerasool
pushed a commit
to SiliconLabs/matter
that referenced
this pull request
Dec 19, 2022
…ror.h when MBEDTLS_ERROR_C is defined (project-chip#23645) Merge in WMN_TOOLS/matter from cherry-pick/cf45410520c to silabs_1.0 Squashed commit of the following: commit a7207146a768fba5c047cfa2a26c73431de4c6aa Author: lpbeliveau-silabs <[email protected]> Date: Wed Nov 16 23:43:29 2022 -0500 Added a missing include for mdetlds/error.h when MBEDTLS_ERROR_C is defined (project-chip#23645)
mkardous-silabs
referenced
this pull request
in mkardous-silabs/connectedhomeip
Dec 19, 2022
…BEDTLS_ERROR_C is defined (project-chip#23645) Merge in WMN_TOOLS/matter from cherry-pick/cf45410520c to silabs_1.0 Squashed commit of the following: commit a7207146a768fba5c047cfa2a26c73431de4c6aa Author: lpbeliveau-silabs <[email protected]> Date: Wed Nov 16 23:43:29 2022 -0500 Added a missing include for mdetlds/error.h when MBEDTLS_ERROR_C is defined (project-chip#23645)
jamesharrow
added a commit
that referenced
this pull request
Dec 4, 2023
DSRR-158 RebasingBranch Approved-by: Farzad Raiyat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some nRF5 platform code is already part of CHIP project. But, its missing an example application that builds, and uses this piece of code.
Summary of Changes
A sample app that links to CHIP platform, and boots up nRF5 device. It's a minimal stack right now. More code will be integrated in future PRs.
fixes #304