Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Silabs] bugfix/missing_mbedtls_define_crypto_pal #23645

Merged
merged 1 commit into from
Nov 17, 2022
Merged

[Silabs] bugfix/missing_mbedtls_define_crypto_pal #23645

merged 1 commit into from
Nov 17, 2022

Conversation

lpbeliveau-silabs
Copy link
Contributor

Added include in CHIPCryptoPALPsaEfr32.cpp to make sure mbedtls_strerror is declared when MBEDTLS_ERROR_C is defined.

@jmartinez-silabs jmartinez-silabs force-pushed the bugfix/missing_mbedtls_define_crypto_pal branch from 4aae389 to 58a5226 Compare November 17, 2022 00:46
@github-actions
Copy link

github-actions bot commented Nov 17, 2022 •
edited
Loading

PR #23645: Size comparison from 6221fe1 to 58a5226

Increases (2 builds for esp32, nrfconnect)
platform target config section 6221fe1 58a5226 change % change
esp32 all-clusters-app c3devkit (read/write) 1788614 1788622 8 0.0
.flash.rodata 258184 258192 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 817280 817284 4 0.0
Decreases (11 builds for bl602, bl702, nrfconnect, psoc6, telink)
platform target config section 6221fe1 58a5226 change % change
bl602 lighting-app bl602 .text 1059742 1059740 -2 -0.0
bl602+rpc .text 1091238 1091234 -4 -0.0
bl702 lighting-app bl702 (read/write) 1195703 1195687 -16 -0.0
.debug_info 39163724 39163722 -2 -0.0
.text 956004 956000 -4 -0.0
bl702+rpc .debug_info 43432924 43432923 -1 -0.0
.text 1029700 1029698 -2 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1167587 1167571 -16 -0.0
text 805834 805830 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27027489 27027488 -1 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26764119 26764118 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 22462954 22462953 -1 -0.0
telink all-clusters-app tlsr9518adk80d text 649056 649054 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d text 613044 613042 -2 -0.0
ota-requestor-app tlsr9518adk80d text 565886 565882 -4 -0.0
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 6221fe1 58a5226 change % change
bl602 lighting-app bl602 (read/write) 1375890 1375890 0 0.0
.bss 90041 90041 0 0.0
.data 9984 9984 0 0.0
.text 1059742 1059740 -2 -0.0
bl602+rpc (read/write) 1421714 1421714 0 0.0
.bss 98081 98081 0 0.0
.data 10376 10376 0 0.0
.text 1091238 1091234 -4 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195703 1195687 -16 -0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67166 67166 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1524147 1524147 0 0.0
.debug_aranges 132328 132328 0 0.0
.debug_frame 485344 485344 0 0.0
.debug_info 39163724 39163722 -2 -0.0
.debug_line 5273288 5273288 0 0.0
.debug_loc 3368311 3368311 0 0.0
.debug_ranges 360440 360440 0 0.0
.debug_str 3463740 3463740 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116568 116568 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 566910 566910 0 0.0
.symtab 171888 171888 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956004 956000 -4 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1283843 1283843 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75214 75214 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1668177 1668177 0 0.0
.debug_aranges 140392 140392 0 0.0
.debug_frame 512548 512548 0 0.0
.debug_info 43432924 43432923 -1 -0.0
.debug_line 5668657 5668657 0 0.0
.debug_loc 3562561 3562561 0 0.0
.debug_ranges 383464 383464 0 0.0
.debug_str 3861055 3861055 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130200 130200 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 627125 627125 0 0.0
.symtab 190000 190000 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1029700 1029698 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 678427 678427 0 0.0
(read/write) 173108 173108 0 0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89851 89851 0 0.0
.text 588264 588264 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642723 642723 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 78987 78987 0 0.0
.text 563416 563416 0 0.0
lock-ftd LP_CC2652R7 (read only) 676559 676559 0 0.0
(read/write) 172544 172544 0 0.0
.bss 78884 78884 0 0.0
.data 3304 3304 0 0.0
.rodata 77271 77271 0 0.0
.text 598808 598808 0 0.0
lock-mtd LP_CC2652R7 (read only) 661115 661115 0 0.0
(read/write) 183244 183244 0 0.0
.bss 74140 74140 0 0.0
.data 3304 3304 0 0.0
.rodata 103315 103315 0 0.0
.text 557320 557320 0 0.0
pump-app LP_CC2652R7 (read only) 689055 689055 0 0.0
(read/write) 160784 160784 0 0.0
.bss 78852 78852 0 0.0
.data 3296 3296 0 0.0
.rodata 90767 90767 0 0.0
.text 597804 597804 0 0.0
pump-controller-app LP_CC2652R7 (read only) 673339 673339 0 0.0
(read/write) 176596 176596 0 0.0
.bss 78948 78948 0 0.0
.data 3292 3292 0 0.0
.rodata 86315 86315 0 0.0
.text 586544 586544 0 0.0
shell LP_CC2652R7 (read only) 669646 669646 0 0.0
(read/write) 184208 184208 0 0.0
.bss 83548 83548 0 0.0
.data 3376 3376 0 0.0
.rodata 86598 86598 0 0.0
.text 582732 582732 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587494 587494 0 0.0
.app_xip_area 463704 463704 0 0.0
.bss 66208 66208 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591602 591602 0 0.0
.app_xip_area 462516 462516 0 0.0
.bss 71496 71496 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543978 543978 0 0.0
.app_xip_area 425708 425708 0 0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974500 974500 0 0.0
.bss 152260 152260 0 0.0
.data 2168 2168 0 0.0
.text 820052 820052 0 0.0
BRD4161A+rs911x (read/write) 1035280 1035280 0 0.0
.bss 186736 186736 0 0.0
.data 2012 2012 0 0.0
.text 846508 846508 0 0.0
BRD4187C (read/write) 1147096 1147096 0 0.0
.bss 138656 138656 0 0.0
.data 2516 2516 0 0.0
.text 981328 981328 0 0.0
lock-app BRD4161A+wf200 (read/write) 1160480 1160480 0 0.0
.bss 158264 158264 0 0.0
.data 2020 2020 0 0.0
.text 1000172 1000172 0 0.0
window-app BRD4187C (read/write) 1140316 1140316 0 0.0
.bss 140072 140072 0 0.0
.data 2540 2540 0 0.0
.text 973108 973108 0 0.0
esp32 all-clusters-app c3devkit (read only) 1224826 1224826 0 0.0
(read/write) 1788614 1788622 8 0.0
.dram0.bss 76944 76944 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 258184 258192 8 0.0
.flash.text 1224826 1224826 0 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1234527 1234527 0 0.0
(read/write) 564420 564420 0 0.0
.dram0.bss 82320 82320 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 315136 315136 0 0.0
.flash.text 1229143 1229143 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 662052 662052 0 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 563724 563724 0 0.0
light k32w0+release (read/write) 672112 672112 0 0.0
.bss 74912 74912 0 0.0
.data 2060 2060 0 0.0
.text 592412 592412 0 0.0
lock k32w0+release (read/write) 633612 633612 0 0.0
.bss 75672 75672 0 0.0
.data 2080 2080 0 0.0
.text 553132 553132 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10436044 10436044 0 0.0
(read/write) 706529 706529 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650832 650832 0 0.0
.dynamic 560 560 0 0.0
.got 13928 13928 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518412 518412 0 0.0
.text 8261844 8261844 0 0.0
thermostat-no-ble arm64 (read only) 2395292 2395292 0 0.0
(read/write) 143665 143665 0 0.0
.bss 55329 55329 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144980 144980 0 0.0
.text 2006416 2006416 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452664 2452664 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1415308 1415308 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188159 1188159 0 0.0
bss 145285 145285 0 0.0
rodata 144516 144516 0 0.0
text 817280 817284 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1167587 1167571 -16 -0.0
bss 144512 144512 0 0.0
rodata 136304 136304 0 0.0
text 805834 805830 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1746780 1746780 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235901 1235901 0 0.0
.debug_aranges 110728 110728 0 0.0
.debug_frame 371396 371396 0 0.0
.debug_info 27027489 27027488 -1 -0.0
.debug_line 3687553 3687553 0 0.0
.debug_loc 3606214 3606214 0 0.0
.debug_ranges 339928 339928 0 0.0
.debug_str 3432635 3432635 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570636 570636 0 0.0
.symtab 421600 421600 0 0.0
.text 1547016 1547016 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1689316 1689316 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1227744 1227744 0 0.0
.debug_aranges 110200 110200 0 0.0
.debug_frame 374476 374476 0 0.0
.debug_info 26764119 26764118 -1 -0.0
.debug_line 3708537 3708537 0 0.0
.debug_loc 3593820 3593820 0 0.0
.debug_ranges 338544 338544 0 0.0
.debug_str 3421655 3421655 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 534725 534725 0 0.0
.symtab 408032 408032 0 0.0
.text 1490288 1490288 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850888 850888 0 0.0
(read/write) 1607492 1607492 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180000 180000 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1062205 1062205 0 0.0
.debug_aranges 102400 102400 0 0.0
.debug_frame 344788 344788 0 0.0
.debug_info 22229329 22229329 0 0.0
.debug_line 3277662 3277662 0 0.0
.debug_loc 3291305 3291305 0 0.0
.debug_ranges 303824 303824 0 0.0
.debug_str 3227190 3227190 0 0.0
.heap 850888 850888 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 471050 471050 0 0.0
.symtab 376400 376400 0 0.0
.text 1416648 1416648 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1641500 1641500 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1064180 1064180 0 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 346664 346664 0 0.0
.debug_info 22462954 22462953 -1 -0.0
.debug_line 3274782 3274782 0 0.0
.debug_loc 3319158 3319158 0 0.0
.debug_ranges 305784 305784 0 0.0
.debug_str 3246547 3246547 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473453 473453 0 0.0
.symtab 378096 378096 0 0.0
.text 1445664 1445664 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151104 1151104 0 0.0
.bss 111116 111116 0 0.0
.data 848 848 0 0.0
.text 598204 598204 0 0.0
lock-app qpg6105+debug (read/write) 1116800 1116800 0 0.0
.bss 106564 106564 0 0.0
.data 836 836 0 0.0
.text 563896 563896 0 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 937728 937728 0 0.0
bss 81620 81620 0 0.0
noinit 43440 43440 0 0.0
text 649056 649054 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 875720 875720 0 0.0
bss 80844 80844 0 0.0
noinit 43440 43440 0 0.0
text 613044 613042 -2 -0.0
light-switch-app tlsr9518adk80d (read/write) 791076 791076 0 0.0
bss 72468 72468 0 0.0
noinit 43520 43520 0 0.0
text 554504 554504 0 0.0
lighting-app tlsr9518adk80d (read/write) 875300 875300 0 0.0
bss 82232 82232 0 0.0
noinit 43520 43520 0 0.0
text 624468 624468 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 805568 805568 0 0.0
bss 74040 74040 0 0.0
noinit 43520 43520 0 0.0
text 565886 565882 -4 -0.0

@yufengwangca yufengwangca merged commit cf45410 into project-chip:master Nov 17, 2022
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@lpbeliveau-silabs @adbridge
Added a missing include for mdetlds/error.h when MBEDTLS_ERROR_C is d…
7386919 
…efined (project-chip#23645)
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@lpbeliveau-silabs @adbridge
Added a missing include for mdetlds/error.h when MBEDTLS_ERROR_C is d…
3e98625 
…efined (project-chip#23645)
rerasool pushed a commit to SiliconLabs/matter that referenced this pull request Dec 19, 2022
@jmartinez-silabs @rerasool
Pull request project-chip#319: Added a missing include for mdetlds/er…
cc73fb1 
…ror.h when MBEDTLS_ERROR_C is defined (project-chip#23645)

Merge in WMN_TOOLS/matter from cherry-pick/cf45410520c to silabs_1.0

Squashed commit of the following:

commit a7207146a768fba5c047cfa2a26c73431de4c6aa
Author: lpbeliveau-silabs <[email protected]>
Date:   Wed Nov 16 23:43:29 2022 -0500

    Added a missing include for mdetlds/error.h when MBEDTLS_ERROR_C is defined (project-chip#23645)
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Dec 19, 2022
@jmartinez-silabs @rerasool
Pull request #319: Added a missing include for mdetlds/error.h when M…
c04f700 
…BEDTLS_ERROR_C is defined (project-chip#23645)

Merge in WMN_TOOLS/matter from cherry-pick/cf45410520c to silabs_1.0

Squashed commit of the following:

commit a7207146a768fba5c047cfa2a26c73431de4c6aa
Author: lpbeliveau-silabs <[email protected]>
Date:   Wed Nov 16 23:43:29 2022 -0500

    Added a missing include for mdetlds/error.h when MBEDTLS_ERROR_C is defined (project-chip#23645)
@lpbeliveau-silabs lpbeliveau-silabs deleted the bugfix/missing_mbedtls_define_crypto_pal branch December 10, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@emargolis emargolis emargolis approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
efr32 platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lpbeliveau-silabs @emargolis @bzbarsky-apple @jmartinez-silabs @yufengwangca