-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to Linux examples to report 5GHz Wi-Fi support #31670
Merged
mergify
merged 3 commits into
project-chip:master
from
tcarmelveilleux:linux-5g-support
Jan 25, 2024
Merged
Add support to Linux examples to report 5GHz Wi-Fi support #31670
mergify
merged 3 commits into
project-chip:master
from
tcarmelveilleux:linux-5g-support
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Linux has noo easy/portable API to determine 5GHz Wi-Fisupport that could be used in Linux platform examples without large changes. - To be able to test SupportedWiFiBands attribute, we have to allow reporting the support for 5GHz Wi-Fi when available. - A workaround was found by adding `--wifi-supports-5g` command line argument to examples, and the requisite plumbing in Linux Wi-Fi driver. Fixes project-chip#30109 Testing done: - Automated test of TC-CNET-* that use this support the new argument will come in a follow-up. - Manually testing between invocations with the following: ``` Terminal1: rm -f kvs1 && out/debug/standalone/chip-all-clusters-app --KVS kvs1 --wifi --wifi-supports-5g Terminal2: ./out/debug/standalone/chip-tool pairing onnetwork 1 20202021 Terminal2: ./out/debug/standalone/chip-tool networkcommissioning read supported-wi-fi-bands 1 0 Verify read has 2 entries: [0, 2] Terminal1: killall chip-all-clusters-app Terminal1: out/debug/standalone/chip-all-clusters-app --KVS kvs1 --wifi Terminal2: ./out/debug/standalone/chip-tool networkcommissioning read supported-wi-fi-bands 1 0 Verify read has 1 entry: [0] ```
andy31415
approved these changes
Jan 24, 2024
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
January 24, 2024 22:08
pullapprove
bot
requested review from
mhazley,
mkardous-silabs,
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
January 24, 2024 22:08
PR #31670: Size comparison from 57898b9 to a06cf49 Increases above 0.2%:
Increases (11 builds for linux)
Decreases (2 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
jmartinez-silabs
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--wifi-supports-5g
command line argument to examples, and the requisite plumbing in Linux Wi-Fi driver.Fixes #30109
Testing done: