Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Matter 1.3][TCR] Add Wi-Fi network driver support to get supported bands for Linux platform #30109

Closed
tcarmelveilleux opened this issue Oct 30, 2023 · 0 comments · Fixed by #31670
Assignees
Labels
commissioning Involves placing devices on the network, initial setup linux TCR

Comments

@tcarmelveilleux
Copy link
Contributor

To support the new SupportedWiFiBands enum in Network Commissioning cluster (see Matter 1.3 TCR https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7571), support for the band listing must be added to the Linux Wi-Fi commissioning driver.

@tcarmelveilleux tcarmelveilleux added commissioning Involves placing devices on the network, initial setup TCR labels Oct 30, 2023
@tcarmelveilleux tcarmelveilleux self-assigned this Oct 30, 2023
@github-actions github-actions bot added the linux label Oct 30, 2023
@woody-apple woody-apple added this to the 1.3 Feature Complete milestone Oct 31, 2023
@github-project-automation github-project-automation bot moved this to Open Cert Blockers in [Certification] Blockers Jan 8, 2024
tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this issue Jan 24, 2024
- Linux has noo easy/portable API to determine 5GHz Wi-Fisupport that
  could be used in Linux platform examples without large changes.
- To be able to test SupportedWiFiBands attribute, we have to allow
  reporting the support for 5GHz Wi-Fi when available.
- A workaround was found by adding `--wifi-supports-5g` command line
  argument to examples, and the requisite plumbing in Linux Wi-Fi driver.

Fixes project-chip#30109

Testing done:
- Automated test of TC-CNET-* that use this support the new argument will
  come in a follow-up.
- Manually testing between invocations with the following:

```
Terminal1: rm -f kvs1 && out/debug/standalone/chip-all-clusters-app --KVS kvs1 --wifi --wifi-supports-5g
Terminal2: ./out/debug/standalone/chip-tool pairing onnetwork 1 20202021
Terminal2: ./out/debug/standalone/chip-tool networkcommissioning read supported-wi-fi-bands 1 0

Verify read has 2 entries: [0, 2]

Terminal1: killall chip-all-clusters-app
Terminal1: out/debug/standalone/chip-all-clusters-app --KVS kvs1 --wifi
Terminal2: ./out/debug/standalone/chip-tool networkcommissioning read supported-wi-fi-bands 1 0

Verify read has 1 entry: [0]
```
@mergify mergify bot closed this as completed in #31670 Jan 25, 2024
mergify bot pushed a commit that referenced this issue Jan 25, 2024
* Add support to Linux examples to report 5GHz Wi-Fi support

- Linux has noo easy/portable API to determine 5GHz Wi-Fisupport that
  could be used in Linux platform examples without large changes.
- To be able to test SupportedWiFiBands attribute, we have to allow
  reporting the support for 5GHz Wi-Fi when available.
- A workaround was found by adding `--wifi-supports-5g` command line
  argument to examples, and the requisite plumbing in Linux Wi-Fi driver.

Fixes #30109

Testing done:
- Automated test of TC-CNET-* that use this support the new argument will
  come in a follow-up.
- Manually testing between invocations with the following:

```
Terminal1: rm -f kvs1 && out/debug/standalone/chip-all-clusters-app --KVS kvs1 --wifi --wifi-supports-5g
Terminal2: ./out/debug/standalone/chip-tool pairing onnetwork 1 20202021
Terminal2: ./out/debug/standalone/chip-tool networkcommissioning read supported-wi-fi-bands 1 0

Verify read has 2 entries: [0, 2]

Terminal1: killall chip-all-clusters-app
Terminal1: out/debug/standalone/chip-all-clusters-app --KVS kvs1 --wifi
Terminal2: ./out/debug/standalone/chip-tool networkcommissioning read supported-wi-fi-bands 1 0

Verify read has 1 entry: [0]
```

* Restyled by clang-format

* Improve comments

---------

Co-authored-by: Restyled.io <[email protected]>
@github-project-automation github-project-automation bot moved this from Open Cert Blockers to Complete in [Certification] Blockers Jan 25, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in [TCR] 1.3 TCRs Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commissioning Involves placing devices on the network, initial setup linux TCR
Projects
Archived in project
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants