Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects the constraint of FanMode to exclude deprecated values #31291

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

mhazley
Copy link
Contributor

@mhazley mhazley commented Jan 8, 2024

Corrects the constraint of FanMode to exclude deprecated values.

Fixes #31230

Copy link

github-actions bot commented Jan 8, 2024

PR #31291: Size comparison from 7381d76 to 9fe51f6

Full report (8 builds for cc32xx, mbed, nrfconnect, qpg)
platform target config section 7381d76 9fe51f6 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 567706 567706 0 0.0
(read/write) 207748 207748 0 0.0
.bss 201212 201212 0 0.0
.data 1412 1412 0 0.0
.rodata 83970 83970 0 0.0
.text 481616 481616 0 0.0
lock CC3235SF_LAUNCHXL (read only) 621026 621026 0 0.0
(read/write) 208144 208144 0 0.0
.bss 201576 201576 0 0.0
.data 1448 1448 0 0.0
.rodata 105834 105834 0 0.0
.text 513072 513072 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2526776 2526776 0 0.0
.bss 220312 220312 0 0.0
.data 5144 5144 0 0.0
.text 1489460 1489460 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1069532 1069532 0 0.0
bss 129520 129520 0 0.0
rodata 105580 105580 0 0.0
text 786856 786856 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1195652 1195652 0 0.0
bss 121730 121730 0 0.0
rodata 139336 139336 0 0.0
text 784244 784244 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1041184 1041184 0 0.0
bss 129444 129444 0 0.0
rodata 98896 98896 0 0.0
text 765184 765184 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1117556 1117556 0 0.0
.bss 101296 101296 0 0.0
.data 740 740 0 0.0
.text 629932 629932 0 0.0
lock-app qpg6105+debug (read/write) 1081476 1081476 0 0.0
.bss 97592 97592 0 0.0
.data 784 784 0 0.0
.text 593856 593856 0 0.0

Copy link

github-actions bot commented Jan 8, 2024

PR #31291: Size comparison from 7381d76 to d0b561c

Decreases (1 build for efr32)
platform target config section 7381d76 d0b561c change % change
efr32 lighting-app BRD4161A+rs9116 (read/write) 1020992 1020984 -8 -0.0
.text 846364 846356 -8 -0.0
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 7381d76 d0b561c change % change
bl602 lighting-app bl602 (read/write) 1419642 1419642 0 0.0
.bss 85256 85256 0 0.0
.data 9416 9416 0 0.0
.rodata 156984 156984 0 0.0
.text 1087338 1087338 0 0.0
bl602+mfd (read/write) 1434114 1434114 0 0.0
.bss 85424 85424 0 0.0
.data 9384 9384 0 0.0
.rodata 155944 155944 0 0.0
.text 1102706 1102706 0 0.0
bl602+rpc (read/write) 1467162 1467162 0 0.0
.bss 93288 93288 0 0.0
.data 9784 9784 0 0.0
.rodata 164600 164600 0 0.0
.text 1118826 1118826 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1184355 1184355 0 0.0
.bss 11197 11197 0 0.0
.data 3584 3584 0 0.0
.rodata 106356 106356 0 0.0
.text 956746 956746 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1195487 1195487 0 0.0
.bss 11373 11373 0 0.0
.data 3568 3568 0 0.0
.rodata 105296 105296 0 0.0
.text 968810 968810 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1276367 1276367 0 0.0
.bss 19677 19677 0 0.0
.data 4144 4144 0 0.0
.rodata 121776 121776 0 0.0
.text 1031808 1031808 0 0.0
bl706-eth (read/write) 1003745 1003745 0 0.0
.bss 23772 23772 0 0.0
.data 3160 3160 0 0.0
.rodata 99688 99688 0 0.0
.text 749408 749408 0 0.0
bl706-wifi (read/write) 1242654 1242654 0 0.0
.bss 10641 10641 0 0.0
.data 3600 3600 0 0.0
.rodata 120668 120668 0 0.0
.text 977476 977476 0 0.0
bl702l lighting-app bl702l (read/write) 1154572 1154572 0 0.0
.bss 16392 16392 0 0.0
.data 4952 4952 0 0.0
.rodata 100360 100360 0 0.0
.text 949872 949872 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1165512 1165512 0 0.0
.bss 16568 16568 0 0.0
.data 4928 4928 0 0.0
.rodata 99300 99300 0 0.0
.text 962248 962248 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 772624 772624 0 0.0
(read/write) 168180 168180 0 0.0
.bss 90516 90516 0 0.0
.data 3460 3460 0 0.0
.rodata 89560 89560 0 0.0
.text 682796 682796 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 788712 788712 0 0.0
(read/write) 178408 178408 0 0.0
.bss 100692 100692 0 0.0
.data 3488 3488 0 0.0
.rodata 83808 83808 0 0.0
.text 704640 704640 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 776960 776960 0 0.0
(read/write) 172864 172864 0 0.0
.bss 95148 95148 0 0.0
.data 3488 3488 0 0.0
.rodata 110416 110416 0 0.0
.text 666280 666280 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 729552 729552 0 0.0
(read/write) 167168 167168 0 0.0
.bss 89280 89280 0 0.0
.data 3448 3448 0 0.0
.rodata 85136 85136 0 0.0
.text 644148 644148 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 715072 715072 0 0.0
(read/write) 167356 167356 0 0.0
.bss 89472 89472 0 0.0
.data 3444 3444 0 0.0
.rodata 80968 80968 0 0.0
.text 633836 633836 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 567706 567706 0 0.0
(read/write) 207748 207748 0 0.0
.bss 201212 201212 0 0.0
.data 1412 1412 0 0.0
.rodata 83970 83970 0 0.0
.text 481616 481616 0 0.0
lock CC3235SF_LAUNCHXL (read only) 621026 621026 0 0.0
(read/write) 208144 208144 0 0.0
.bss 201576 201576 0 0.0
.data 1448 1448 0 0.0
.rodata 105834 105834 0 0.0
.text 513072 513072 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 562031 562031 0 0.0
.app_xip_area 452185 452185 0 0.0
.bss 64760 64760 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 544263 544263 0 0.0
.app_xip_area 429681 429681 0 0.0
.bss 69456 69456 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 562959 562959 0 0.0
.app_xip_area 454569 454569 0 0.0
.bss 63376 63376 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 558431 558431 0 0.0
.app_xip_area 446817 446817 0 0.0
.bss 66496 66496 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1020992 1020984 -8 -0.0
.bss 171896 171896 0 0.0
.data 2708 2708 0 0.0
.text 846364 846356 -8 -0.0
BRD4187C (read/write) 1105044 1105044 0 0.0
.bss 195004 195004 0 0.0
.data 3316 3316 0 0.0
.text 906704 906704 0 0.0
lock-app BRD4161A+wf200 (read/write) 1117928 1117928 0 0.0
.bss 188112 188112 0 0.0
.data 2732 2732 0 0.0
.text 927064 927064 0 0.0
window-app BRD4187C (read/write) 1138296 1138296 0 0.0
.bss 167036 167036 0 0.0
.data 3188 3188 0 0.0
.text 968052 968052 0 0.0
esp32 all-clusters-app c3devkit (read only) 1140180 1140180 0 0.0
(read/write) 1671220 1671220 0 0.0
.dram0.bss 72224 72224 0 0.0
.dram0.data 12996 12996 0 0.0
.flash.rodata 242128 242128 0 0.0
.flash.text 1140180 1140180 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1185075 1185075 0 0.0
(read/write) 520404 520404 0 0.0
.dram0.bss 78880 78880 0 0.0
.dram0.data 34004 34004 0 0.0
.flash.rodata 273156 273156 0 0.0
.flash.text 1179691 1179691 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 606416 606416 0 0.0
(read/write) 81176 81176 0 0.0
.bss 69024 69024 0 0.0
.data 2168 2168 0 0.0
.text 605880 605880 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 691680 691680 0 0.0
.bss 67680 67680 0 0.0
.data 2716 2716 0 0.0
.text 577808 577808 0 0.0
light k32w0+release (read only) 595816 595816 0 0.0
(read/write) 79192 79192 0 0.0
.bss 67088 67088 0 0.0
.data 2120 2120 0 0.0
.text 595280 595280 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 783508 783508 0 0.0
.bss 77356 77356 0 0.0
.data 1928 1928 0 0.0
.text 660768 660768 0 0.0
lock k32w0+release (read only) 577304 577304 0 0.0
(read/write) 78648 78648 0 0.0
.bss 66568 66568 0 0.0
.data 2096 2096 0 0.0
.text 576768 576768 0 0.0
linux air-purifier-app debug (read only) 2534077 2534077 0 0.0
(read/write) 127248 127248 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72856 72856 0 0.0
.dynamic 608 608 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 179592 179592 0 0.0
.text 2179061 2179061 0 0.0
all-clusters-app debug (read only) 5429401 5429401 0 0.0
(read/write) 456704 456704 0 0.0
.bss 131760 131760 0 0.0
.data 3840 3840 0 0.0
.data.rel.ro 313832 313832 0 0.0
.dynamic 624 624 0 0.0
.got 5336 5336 0 0.0
.init 27 27 0 0.0
.init_array 1288 1288 0 0.0
.rodata 313372 313372 0 0.0
.text 4704899 4704899 0 0.0
all-clusters-minimal-app debug (read only) 4961953 4961953 0 0.0
(read/write) 234728 234728 0 0.0
.bss 127856 127856 0 0.0
.data 3776 3776 0 0.0
.data.rel.ro 95992 95992 0 0.0
.dynamic 624 624 0 0.0
.got 5296 5296 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 272813 272813 0 0.0
.text 4456659 4456659 0 0.0
bridge-app debug (read only) 4424921 4424921 0 0.0
(read/write) 215968 215968 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 85312 85312 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 219477 219477 0 0.0
.text 3986851 3986851 0 0.0
chip-tool debug (read only) 11741833 11741833 0 0.0
(read/write) 505880 505880 0 0.0
.bss 94200 94200 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 399440 399440 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 426601 426601 0 0.0
.text 10622707 10622707 0 0.0
chip-tool-ipv6only arm64 (read only) 11321288 11321288 0 0.0
(read/write) 575216 575216 0 0.0
.bss 103272 103272 0 0.0
.data 4384 4384 0 0.0
.data.rel.ro 438688 438688 0 0.0
.dynamic 512 512 0 0.0
.got 19928 19928 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 338036 338036 0 0.0
.text 10110732 10110732 0 0.0
lighting-app debug+rpc+ui (read only) 5310977 5310977 0 0.0
(read/write) 225040 225040 0 0.0
.bss 119360 119360 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 93728 93728 0 0.0
.dynamic 672 672 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 968 968 0 0.0
.rodata 340724 340724 0 0.0
.text 4725443 4725443 0 0.0
lock-app debug (read only) 4509961 4509961 0 0.0
(read/write) 203688 203688 0 0.0
.bss 113760 113760 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79544 79544 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 247317 247317 0 0.0
.text 4052595 4052595 0 0.0
ota-provider-app debug (read only) 4174097 4174097 0 0.0
(read/write) 192736 192736 0 0.0
.bss 113632 113632 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 69312 69312 0 0.0
.dynamic 624 624 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 201589 201589 0 0.0
.text 3780611 3780611 0 0.0
ota-requestor-app debug (read only) 4264673 4264673 0 0.0
(read/write) 197048 197048 0 0.0
.bss 114656 114656 0 0.0
.data 4176 4176 0 0.0
.data.rel.ro 72320 72320 0 0.0
.dynamic 624 624 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 205397 205397 0 0.0
.text 3862979 3862979 0 0.0
shell debug (read only) 2799041 2799041 0 0.0
(read/write) 152672 152672 0 0.0
.bss 62440 62440 0 0.0
.data 768 768 0 0.0
.data.rel.ro 83656 83656 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 1104 1104 0 0.0
.rodata 182560 182560 0 0.0
.text 2445154 2445154 0 0.0
thermostat-no-ble arm64 (read only) 4353368 4353368 0 0.0
(read/write) 247840 247840 0 0.0
.bss 122056 122056 0 0.0
.data 2880 2880 0 0.0
.data.rel.ro 102752 102752 0 0.0
.dynamic 512 512 0 0.0
.got 12088 12088 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 155644 155644 0 0.0
.text 3855212 3855212 0 0.0
tv-app debug (read only) 5411201 5411201 0 0.0
(read/write) 349216 349216 0 0.0
.bss 244608 244608 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 92312 92312 0 0.0
.dynamic 624 624 0 0.0
.got 5512 5512 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 273493 273493 0 0.0
.text 4899843 4899843 0 0.0
tv-casting-app debug (read only) 9619833 9619833 0 0.0
(read/write) 339240 339240 0 0.0
.bss 156384 156384 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 173536 173536 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 364232 364232 0 0.0
.text 8789971 8789971 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2526776 2526776 0 0.0
.bss 220312 220312 0 0.0
.data 5144 5144 0 0.0
.text 1489460 1489460 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1069532 1069532 0 0.0
bss 129520 129520 0 0.0
rodata 105580 105580 0 0.0
text 786856 786856 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1195652 1195652 0 0.0
bss 121730 121730 0 0.0
rodata 139336 139336 0 0.0
text 784244 784244 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1041184 1041184 0 0.0
bss 129444 129444 0 0.0
rodata 98896 98896 0 0.0
text 765184 765184 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835720 835720 0 0.0
(read/write) 1753220 1753220 0 0.0
.bss 195140 195140 0 0.0
.data 2480 2480 0 0.0
.text 1547212 1547212 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837816 837816 0 0.0
(read/write) 1707132 1707132 0 0.0
.bss 193052 193052 0 0.0
.data 2472 2472 0 0.0
.text 1503220 1503220 0 0.0
light cy8ckit_062s2_43012 (read only) 844504 844504 0 0.0
(read/write) 1632052 1632052 0 0.0
.bss 186476 186476 0 0.0
.data 2360 2360 0 0.0
.text 1434828 1434828 0 0.0
lock cy8ckit_062s2_43012 (read only) 817384 817384 0 0.0
(read/write) 1658948 1658948 0 0.0
.bss 213572 213572 0 0.0
.data 2384 2384 0 0.0
.text 1434604 1434604 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1117556 1117556 0 0.0
.bss 101296 101296 0 0.0
.data 740 740 0 0.0
.text 629932 629932 0 0.0
lock-app qpg6105+debug (read/write) 1081476 1081476 0 0.0
.bss 97592 97592 0 0.0
.data 784 784 0 0.0
.text 593856 593856 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 822262 822262 0 0.0
bss 55104 55104 0 0.0
text 614538 614538 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1088632 1088632 0 0.0
bss 100536 100536 0 0.0
text 768824 768824 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1085128 1085128 0 0.0
bss 109860 109860 0 0.0
text 754332 754332 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 935608 935608 0 0.0
bss 94368 94368 0 0.0
text 647590 647590 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 822490 822490 0 0.0
bss 55148 55148 0 0.0
text 614908 614908 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 979784 979784 0 0.0
bss 79132 79132 0 0.0
text 695200 695200 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1094156 1094156 0 0.0
bss 99932 99932 0 0.0
text 770684 770684 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 966208 966208 0 0.0
bss 97396 97396 0 0.0
text 648674 648674 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 949484 949484 0 0.0
bss 92476 92476 0 0.0
text 663900 663900 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 881400 881400 0 0.0
bss 69124 69124 0 0.0
text 623022 623022 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 822004 822004 0 0.0
bss 57360 57360 0 0.0
text 589898 589898 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705596 705596 0 0.0
bss 73588 73588 0 0.0
text 462092 462092 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 824226 824226 0 0.0
bss 55284 55284 0 0.0
text 617652 617652 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 879193 879193 0 0.0
bss 60836 60836 0 0.0
text 631736 631736 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 846376 846376 0 0.0
bss 57656 57656 0 0.0
text 608364 608364 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 840548 840548 0 0.0
bss 58008 58008 0 0.0
text 602294 602294 0 0.0

@mergify mergify bot merged commit 6ce2bed into project-chip:master Jan 8, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TC-FAN-2.1: Deprecated Values should be removed from Step 2
3 participants