Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TC-FAN-2.1: Deprecated Values should be removed from Step 2 #31230

Closed
mhazley opened this issue Jan 3, 2024 · 0 comments · Fixed by #31291
Closed

TC-FAN-2.1: Deprecated Values should be removed from Step 2 #31230

mhazley opened this issue Jan 3, 2024 · 0 comments · Fixed by #31291
Assignees
@mhazley
Labels
fan control tests

Comments

@mhazley
Copy link
Contributor

mhazley commented Jan 3, 2024 •
edited
Loading

Follow up from this issue in the Test Plan.

    - label: "Step 2: TH reads from the DUT the the FanMode attribute"
      PICS: FAN.S.A0000
      command: "readAttribute"
      attribute: "FanMode"
      response:
          constraints:
              type: enum8
              minValue: 0
              maxValue: 6

The range 0-6 includes deprecated values so is the wrong expected outcome.

Should be:

          constraints:
              type: enum8
              anyOf: [0, 1, 2, 3, 5]

On hold until Test Plan update is merged
@mhazley mhazley self-assigned this Jan 3, 2024
@mhazley mhazley moved this from Todo to In Progress in [Feature] Air Quality Jan 8, 2024
mhazley added a commit to dysonltd/connectedhomeip that referenced this issue Jan 8, 2024
@mhazley
Fixes project-chip#31230, corrects the constraint of FanMode to exclu…
9fe51f6 
…de deprecated values
@mhazley mhazley mentioned this issue Jan 8, 2024
Merged
@mhazley mhazley moved this from In Progress to In Review in [Feature] Air Quality Jan 8, 2024
@mergify mergify bot closed this as completed in #31291 Jan 8, 2024
mergify bot pushed a commit that referenced this issue Jan 8, 2024
@mhazley
Corrects the constraint of FanMode to exclude deprecated values (#31291)
6ce2bed 
* Fixes #31230, corrects the constraint of FanMode to exclude deprecated values

* Regen after test change
@github-project-automation github-project-automation bot moved this from In Review to Done in [Feature] Air Quality Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhazley mhazley

Labels
fan control tests
Projects
[Feature] Air Quality
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Corrects the constraint of FanMode to exclude deprecated values dysonltd/connectedhomeip
1 participant
@mhazley