-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable op state pause and resume for compatible states #30795
Enable op state pause and resume for compatible states #30795
Conversation
…tible state to receive this command.
…patible states to receive this command.
PR #30795: Size comparison from 4db8c38 to 8e94e82 Full report (8 builds for cc32xx, mbed, nrfconnect, qpg)
|
…tional state server API
PR #30795: Size comparison from 4db8c38 to bdd2eae Increases (1 build for linux)
Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30795: Size comparison from 1583a24 to 96beb6f Increases (1 build for linux)
Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better, thank you!
PR #30795: Size comparison from 2980e51 to adec6d9 Decreases (1 build for efr32)
Full report (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
… of github.com:dysonltd/connectedhomeip into enable_op_state_pause_and_resume_for_compatible_states
PR #30795: Size comparison from 2980e51 to 1005d57 Full report (8 builds for cc32xx, mbed, nrfconnect, qpg)
|
PR #30795: Size comparison from 2980e51 to 4e9de50 Increases (1 build for linux)
Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/clusters/operational-state-server/operational-state-server.h
Outdated
Show resolved
Hide resolved
PR #30795: Size comparison from c4dd75e to 4af68ac Increases (1 build for linux)
Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Fixes #30742.
Makes the private variables
mClusterId
andmEndpointId
in the Operational State server Instanceconst
. This may allow compilers to compile out code that is not reachable.