Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ICD] Fix comment placement #30659

Merged

Conversation

jepenven-silabs
Copy link
Contributor

Mini PR to address @bzbarsky-apple comment : #30385 (comment)

Copy link

github-actions bot commented Nov 27, 2023

PR #30659: Size comparison from b74fef0 to d2d153c

Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section b74fef0 d2d153c change % change
bl602 lighting-app bl602 (read/write) 1411490 1411490 0 0.0
.bss 85048 85048 0 0.0
.data 9376 9376 0 0.0
.rodata 156860 156860 0 0.0
.text 1079546 1079546 0 0.0
bl602+mfd (read/write) 1425930 1425930 0 0.0
.bss 85216 85216 0 0.0
.data 9344 9344 0 0.0
.rodata 155820 155820 0 0.0
.text 1094898 1094898 0 0.0
bl602+rpc (read/write) 1459010 1459010 0 0.0
.bss 93080 93080 0 0.0
.data 9744 9744 0 0.0
.rodata 164476 164476 0 0.0
.text 1111034 1111034 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1175911 1175911 0 0.0
.bss 11197 11197 0 0.0
.data 3560 3560 0 0.0
.rodata 106232 106232 0 0.0
.text 948686 948686 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1187035 1187035 0 0.0
.bss 11373 11373 0 0.0
.data 3536 3536 0 0.0
.rodata 105172 105172 0 0.0
.text 960750 960750 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1275979 1275979 0 0.0
.bss 19677 19677 0 0.0
.data 4112 4112 0 0.0
.rodata 121648 121648 0 0.0
.text 1023748 1023748 0 0.0
bl706-eth (read/write) 995877 995877 0 0.0
.bss 23772 23772 0 0.0
.data 3128 3128 0 0.0
.rodata 99572 99572 0 0.0
.text 741922 741922 0 0.0
bl706-wifi (read/write) 1232062 1232062 0 0.0
.bss 10657 10657 0 0.0
.data 3568 3568 0 0.0
.rodata 120544 120544 0 0.0
.text 967260 967260 0 0.0
bl702l lighting-app bl702l (read/write) 1146140 1146140 0 0.0
.bss 16408 16408 0 0.0
.data 4920 4920 0 0.0
.rodata 100236 100236 0 0.0
.text 941784 941784 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1157088 1157088 0 0.0
.bss 16584 16584 0 0.0
.data 4904 4904 0 0.0
.rodata 99176 99176 0 0.0
.text 954160 954160 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 740187 740187 0 0.0
(read/write) 167064 167064 0 0.0
.bss 89476 89476 0 0.0
.data 3424 3424 0 0.0
.rodata 84607 84607 0 0.0
.text 655192 655192 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 757547 757547 0 0.0
(read/write) 177244 177244 0 0.0
.bss 99612 99612 0 0.0
.data 3444 3444 0 0.0
.rodata 79695 79695 0 0.0
.text 677460 677460 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 744491 744491 0 0.0
(read/write) 171692 171692 0 0.0
.bss 94060 94060 0 0.0
.data 3444 3444 0 0.0
.rodata 105455 105455 0 0.0
.text 638648 638648 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 698547 698547 0 0.0
(read/write) 166100 166100 0 0.0
.bss 88280 88280 0 0.0
.data 3412 3412 0 0.0
.rodata 80383 80383 0 0.0
.text 617776 617776 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 684187 684187 0 0.0
(read/write) 166240 166240 0 0.0
.bss 88432 88432 0 0.0
.data 3408 3408 0 0.0
.rodata 76215 76215 0 0.0
.text 607584 607584 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 565042 565042 0 0.0
(read/write) 207520 207520 0 0.0
.bss 200980 200980 0 0.0
.data 1416 1416 0 0.0
.rodata 83858 83858 0 0.0
.text 479064 479064 0 0.0
lock CC3235SF_LAUNCHXL (read only) 617898 617898 0 0.0
(read/write) 207860 207860 0 0.0
.bss 201296 201296 0 0.0
.data 1444 1444 0 0.0
.rodata 105730 105730 0 0.0
.text 510048 510048 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 558591 558591 0 0.0
.app_xip_area 448985 448985 0 0.0
.bss 64520 64520 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 540775 540775 0 0.0
.app_xip_area 426489 426489 0 0.0
.bss 69168 69168 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 559951 559951 0 0.0
.app_xip_area 451801 451801 0 0.0
.bss 63136 63136 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 555071 555071 0 0.0
.app_xip_area 443745 443745 0 0.0
.bss 66208 66208 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1013468 1013468 0 0.0
.bss 172464 172464 0 0.0
.data 2696 2696 0 0.0
.text 838288 838288 0 0.0
BRD4187C (read/write) 1098308 1098308 0 0.0
.bss 196068 196068 0 0.0
.data 3304 3304 0 0.0
.text 898916 898916 0 0.0
lock-app BRD4161A+wf200 (read/write) 1105160 1105160 0 0.0
.bss 187064 187064 0 0.0
.data 2708 2708 0 0.0
.text 915364 915364 0 0.0
window-app BRD4187C (read/write) 1133152 1133152 0 0.0
.bss 168420 168420 0 0.0
.data 3176 3176 0 0.0
.text 961536 961536 0 0.0
esp32 all-clusters-app c3devkit (read only) 1134040 1134040 0 0.0
(read/write) 1671116 1671116 0 0.0
.dram0.bss 72432 72432 0 0.0
.dram0.data 12996 12996 0 0.0
.flash.rodata 241816 241816 0 0.0
.flash.text 1134040 1134040 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1178463 1178463 0 0.0
(read/write) 520728 520728 0 0.0
.dram0.bss 79072 79072 0 0.0
.dram0.data 34020 34020 0 0.0
.flash.rodata 273272 273272 0 0.0
.flash.text 1173079 1173079 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 592844 592844 0 0.0
(read/write) 88088 88088 0 0.0
.bss 71328 71328 0 0.0
.data 2136 2136 0 0.0
.text 592308 592308 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 688408 688408 0 0.0
.bss 67528 67528 0 0.0
.data 2720 2720 0 0.0
.text 574680 574680 0 0.0
light k32w0+release (read only) 592548 592548 0 0.0
(read/write) 87764 87764 0 0.0
.bss 71016 71016 0 0.0
.data 2124 2124 0 0.0
.text 592012 592012 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 780252 780252 0 0.0
.bss 77196 77196 0 0.0
.data 1932 1932 0 0.0
.text 657664 657664 0 0.0
lock k32w0+release (read only) 564356 564356 0 0.0
(read/write) 85584 85584 0 0.0
.bss 68896 68896 0 0.0
.data 2064 2064 0 0.0
.text 563820 563820 0 0.0
linux air-purifier-app debug (read only) 2507797 2507797 0 0.0
(read/write) 126864 126864 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72456 72456 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 177512 177512 0 0.0
.text 2155573 2155573 0 0.0
all-clusters-app debug (read only) 5333521 5333521 0 0.0
(read/write) 430184 430184 0 0.0
.bss 130064 130064 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 289008 289008 0 0.0
.dynamic 624 624 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 1232 1232 0 0.0
.rodata 303036 303036 0 0.0
.text 4641619 4641619 0 0.0
all-clusters-minimal-app debug (read only) 4933665 4933665 0 0.0
(read/write) 234472 234472 0 0.0
.bss 127856 127856 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 95680 95680 0 0.0
.dynamic 624 624 0 0.0
.got 5312 5312 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 270861 270861 0 0.0
.text 4430787 4430787 0 0.0
bridge-app debug (read only) 4406521 4406521 0 0.0
(read/write) 215744 215744 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 85056 85056 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 218517 218517 0 0.0
.text 3969763 3969763 0 0.0
chip-tool debug (read only) 10748673 10748673 0 0.0
(read/write) 465232 465232 0 0.0
.bss 94072 94072 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 358936 358936 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 400905 400905 0 0.0
.text 9718819 9718819 0 0.0
chip-tool-ipv6only arm64 (read only) 10599528 10599528 0 0.0
(read/write) 530960 530960 0 0.0
.bss 103352 103352 0 0.0
.data 4296 4296 0 0.0
.data.rel.ro 396872 396872 0 0.0
.dynamic 512 512 0 0.0
.got 18936 18936 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 325040 325040 0 0.0
.text 9471064 9471064 0 0.0
lighting-app debug+rpc+ui (read only) 5278009 5278009 0 0.0
(read/write) 224496 224496 0 0.0
.bss 119168 119168 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 93312 93312 0 0.0
.dynamic 672 672 0 0.0
.got 5896 5896 0 0.0
.init 27 27 0 0.0
.init_array 968 968 0 0.0
.rodata 338196 338196 0 0.0
.text 4695667 4695667 0 0.0
lock-app debug (read only) 4491041 4491041 0 0.0
(read/write) 203296 203296 0 0.0
.bss 113632 113632 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79288 79288 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 246517 246517 0 0.0
.text 4034867 4034867 0 0.0
ota-provider-app debug (read only) 4155697 4155697 0 0.0
(read/write) 192544 192544 0 0.0
.bss 113632 113632 0 0.0
.data 3920 3920 0 0.0
.data.rel.ro 69072 69072 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 200789 200789 0 0.0
.text 3763363 3763363 0 0.0
ota-requestor-app debug (read only) 4241953 4241953 0 0.0
(read/write) 196792 196792 0 0.0
.bss 114656 114656 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 72032 72032 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 204565 204565 0 0.0
.text 3841539 3841539 0 0.0
shell debug (read only) 2767857 2767857 0 0.0
(read/write) 149640 149640 0 0.0
.bss 60616 60616 0 0.0
.data 784 784 0 0.0
.data.rel.ro 82440 82440 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 180768 180768 0 0.0
.text 2416690 2416690 0 0.0
thermostat-no-ble arm64 (read only) 4392944 4392944 0 0.0
(read/write) 245312 245312 0 0.0
.bss 122248 122248 0 0.0
.data 2800 2800 0 0.0
.data.rel.ro 102120 102120 0 0.0
.dynamic 512 512 0 0.0
.got 11944 11944 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 161980 161980 0 0.0
.text 3891176 3891176 0 0.0
tv-app debug (read only) 5276737 5276737 0 0.0
(read/write) 345240 345240 0 0.0
.bss 242592 242592 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 90344 90344 0 0.0
.dynamic 624 624 0 0.0
.got 5520 5520 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 267285 267285 0 0.0
.text 4774691 4774691 0 0.0
tv-casting-app debug (read only) 8688873 8688873 0 0.0
(read/write) 322208 322208 0 0.0
.bss 156192 156192 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 156704 156704 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 346568 346568 0 0.0
.text 7918675 7918675 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2523816 2523816 0 0.0
.bss 220032 220032 0 0.0
.data 5136 5136 0 0.0
.text 1486500 1486500 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1057980 1057980 0 0.0
bss 128917 128917 0 0.0
rodata 104140 104140 0 0.0
text 777276 777276 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1185168 1185168 0 0.0
bss 121139 121139 0 0.0
rodata 138400 138400 0 0.0
text 775292 775292 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1043116 1043116 0 0.0
bss 129204 129204 0 0.0
rodata 99316 99316 0 0.0
text 766948 766948 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 836320 836320 0 0.0
(read/write) 1738236 1738236 0 0.0
.bss 194540 194540 0 0.0
.data 2480 2480 0 0.0
.text 1532828 1532828 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 838048 838048 0 0.0
(read/write) 1701964 1701964 0 0.0
.bss 192812 192812 0 0.0
.data 2480 2480 0 0.0
.text 1498284 1498284 0 0.0
light cy8ckit_062s2_43012 (read only) 844736 844736 0 0.0
(read/write) 1628036 1628036 0 0.0
.bss 186236 186236 0 0.0
.data 2368 2368 0 0.0
.text 1431044 1431044 0 0.0
lock cy8ckit_062s2_43012 (read only) 817664 817664 0 0.0
(read/write) 1655044 1655044 0 0.0
.bss 213292 213292 0 0.0
.data 2384 2384 0 0.0
.text 1430980 1430980 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1114384 1114384 0 0.0
.bss 101152 101152 0 0.0
.data 748 748 0 0.0
.text 626760 626760 0 0.0
lock-app qpg6105+debug (read/write) 1075740 1075740 0 0.0
.bss 95920 95920 0 0.0
.data 780 780 0 0.0
.text 588116 588116 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 817422 817422 0 0.0
bss 53688 53688 0 0.0
text 611062 611062 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1075460 1075460 0 0.0
bss 99960 99960 0 0.0
text 758324 758324 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1080176 1080176 0 0.0
bss 109652 109652 0 0.0
text 749904 749904 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 932404 932404 0 0.0
bss 94160 94160 0 0.0
text 644800 644800 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 817550 817550 0 0.0
bss 53740 53740 0 0.0
text 611278 611278 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 971696 971696 0 0.0
bss 77548 77548 0 0.0
text 689302 689302 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1090064 1090064 0 0.0
bss 99724 99724 0 0.0
text 767034 767034 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 958332 958332 0 0.0
bss 95812 95812 0 0.0
text 643256 643256 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 945660 945660 0 0.0
bss 92268 92268 0 0.0
text 660514 660514 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 873904 873904 0 0.0
bss 67576 67576 0 0.0
text 617680 617680 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 814588 814588 0 0.0
bss 55812 55812 0 0.0
text 584634 584634 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705404 705404 0 0.0
bss 73588 73588 0 0.0
text 461922 461922 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 819274 819274 0 0.0
bss 53824 53824 0 0.0
text 614002 614002 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 871341 871341 0 0.0
bss 59288 59288 0 0.0
text 626032 626032 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 838640 838640 0 0.0
bss 56108 56108 0 0.0
text 602800 602800 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 833140 833140 0 0.0
bss 56460 56460 0 0.0
text 597028 597028 0 0.0

@mergify mergify bot merged commit 503cbc5 into project-chip:master Nov 27, 2023
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app icd Intermittently Connected Devices review - approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants