[ICD] Add ICD CheckInSender class #30385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepenven-silabs
force-pushed
the
icd_checkinsender_class
branch
from
13c2d69 to
ed4d436
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
|
PR #30385: Size comparison from f50e12b to 789e304 Increases (1 build for qpg)
Decreases (11 builds for telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
requested changes
Nov 10, 2023
|
PR #30385: Size comparison from f50e12b to 31086dc Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for cc32xx, linux, mbed)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jepenven-silabs
force-pushed
the
icd_checkinsender_class
branch
from
31086dc to
3cb83ee
Compare
|
PR #30385: Size comparison from baa1d7a to 3cb83ee Increases (1 build for qpg)
Decreases (11 builds for telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #30385: Size comparison from baa1d7a to 31249a8 Increases above 0.2%:
Increases (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (22 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, psoc6, qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mkardous-silabs
approved these changes
Nov 14, 2023
|
PR #30385: Size comparison from baa1d7a to 02be3b3 Increases above 0.2%:
Increases (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (22 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, psoc6, qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 14, 2023
jepenven-silabs
force-pushed
the
icd_checkinsender_class
branch
from
02be3b3 to
bc16fb0
Compare
jepenven-silabs
force-pushed
the
icd_checkinsender_class
branch
from
bc16fb0 to
2c45f09
Compare
|
PR #30385: Size comparison from 26ec08f to 2c45f09 Increases (1 build for qpg)
Decreases (11 builds for telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Nov 16, 2023
| @@ -109,7 +109,8 @@ static_library("Linux") { | |||
| "${chip_root}/third_party/inipp", | |||
| ] | |||
|
|
|||
| public_configs = [] | |||
| public_configs = | |||
| [ "${chip_root}/src/lib/address_resolve:default_address_resolve_config" ] | |||
There was a problem hiding this comment.
why? this was not needed before. Something went wrong here.
There was a problem hiding this comment.
may be related to #30527
This was referenced Nov 27, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break-out PR for the ICD Check-In message feature.
This class was tested along with the complete changes manually with an All-cluster-app -icd build, Chip-tool and Wireshark to monitored the sending of the Check-in Message on the network.
Standard behavior is :
Since DNS resolution, and exchangeCtx message sending are already covered by other Unit tests, no Unit test were added for this class. Instead integration tests will be added once the feature is completed (ICD Check-In sending AND Receiving)