-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/electrical energy measurement #30389
Feature/electrical energy measurement #30389
Conversation
PR #30389: Size comparison from f50e12b to 6d8daca Full report (5 builds for cc32xx, mbed, qpg)
|
PR #30389: Size comparison from f50e12b to ab70458 Increases above 0.2%:
Increases (8 builds for linux, nrfconnect, telink)
Full report (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, k32w, linux, mbed, nrfconnect, qpg, telink)
|
src/app/clusters/electrical-energy-measurement-server/electrical-energy-measurement-server.cpp
Show resolved
Hide resolved
src/app/clusters/electrical-energy-measurement-server/electrical-energy-measurement-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/electrical-energy-measurement-server/electrical-energy-measurement-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/electrical-energy-measurement-server/electrical-energy-measurement-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/electrical-energy-measurement-server/electrical-energy-measurement-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/electrical-energy-measurement-server/electrical-energy-measurement-server.h
Show resolved
Hide resolved
src/app/clusters/electrical-energy-measurement-server/electrical-energy-measurement-server.h
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/electrical-energy-measurement-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/electrical-energy-measurement-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/clusters/electrical-energy-measurement-server/electrical-energy-measurement-server.h
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/electrical-energy-measurement-cluster.xml
Outdated
Show resolved
Hide resolved
PR #30389: Size comparison from 44ea4eb to daa999b Increases above 0.2%:
Increases (38 builds for bl602, bl702, bl702l, esp32, linux, nrfconnect, psoc6, telink)
Decreases (17 builds for bl702l, efr32, esp32, linux, psoc6)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30389: Size comparison from 88b2d0c to 2c86bc7 Increases above 0.2%:
Increases (11 builds for esp32, linux, nrfconnect, psoc6, telink)
Decreases (1 build for psoc6)
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30389: Size comparison from 2675b00 to 742c52a Increases above 0.2%:
Increases (11 builds for esp32, linux, nrfconnect, psoc6, telink)
Decreases (2 builds for efr32, psoc6)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the XML needs updating to the latest spec PR. Other than that it looks good.
src/app/zap-templates/zcl/data-model/chip/electrical-energy-measurement-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/electrical-energy-measurement-cluster.xml
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/electrical-energy-measurement-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/electrical-energy-measurement-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/electrical-energy-measurement-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/electrical-energy-measurement-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/electrical-energy-measurement-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/electrical-energy-measurement-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/electrical-energy-measurement-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/clusters/electrical-energy-measurement-server/electrical-energy-measurement-server.cpp
Outdated
Show resolved
Hide resolved
…empelg/connectedhomeip into feature/electrical_energy_measurement
PR #30389: Size comparison from 360ab99 to f876441 Increases above 0.2%:
Increases (11 builds for esp32, linux, nrfconnect, psoc6, telink)
Decreases (1 build for psoc6)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30389: Size comparison from 360ab99 to 5e55f0b Increases above 0.2%:
Increases (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for linux, psoc6)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now - thanks
PR #30389: Size comparison from 0d9332e to 2121ea2 Increases above 0.2%:
Increases (11 builds for esp32, linux, nrfconnect, psoc6, telink)
Decreases (2 builds for efr32, psoc6)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30389: Size comparison from ba8ab24 to 8c132a2 Increases above 0.2%:
Increases (11 builds for esp32, linux, nrfconnect, psoc6, telink)
Decreases (2 builds for efr32, psoc6)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
This doesn't seem like it compiles correctly: |
This PR adds the XML for the Electrical Energy Measurement Cluster and some functions for sending the events from the server.
This is based on https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7830
Changes
src/app/zap-templates/zcl/data-model/chip/electrical-energy-measurement-cluster.xml
src/app/clusters/electrical-energy-measurement-server/
Testing