Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"zap convert" and running the ZAP GUI produce different .zap file output #1237

Closed
bzbarsky-apple opened this issue Dec 13, 2023 · 1 comment
Closed

"zap convert" and running the ZAP GUI produce different .zap file output #1237

bzbarsky-apple opened this issue Dec 13, 2023 · 1 comment
Labels
matter Important to Matter SDK

Comments

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Dec 13, 2023 •
edited
Loading

When "zap convert" gets run, it adds this to the ZAP file:

  "log": []

When the ZAP UI is run, it removes that line.

So using "convert" and the UI keeps editing the file back and forth. This leads to a lot of noise in Matter PRs. See https://github.com/project-chip/connectedhomeip/pull/30389/files for a prime example.
@bzbarsky-apple bzbarsky-apple added the matter Important to Matter SDK label Dec 13, 2023
@tecimovic
Copy link
Collaborator

This was addressed in #1238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
matter Important to Matter SDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tecimovic @bzbarsky-apple