-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a way to trigger lock/unlock in linux lock-app by writing JSON to the FIFO. #29919
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:add-lock-unlock-json-commands
Oct 23, 2023
Merged
Add a way to trigger lock/unlock in linux lock-app by writing JSON to the FIFO. #29919
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:add-lock-unlock-json-commands
Oct 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley and
mkardous-silabs
October 23, 2023 17:48
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
October 23, 2023 17:48
woody-apple
approved these changes
Oct 23, 2023
PR #29919: Size comparison from be604dd to 54c3d0a Increases above 0.2%:
Increases (1 build for linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 23, 2023
yufengwangca
approved these changes
Oct 23, 2023
… the FIFO. Adds support for lock/unlock, with or without PIN. PIN can specified as either hex or ASCII digits.
bzbarsky-apple
force-pushed
the
add-lock-unlock-json-commands
branch
from
October 23, 2023 21:01
54c3d0a
to
5a95aa9
Compare
PR #29919: Size comparison from 947b6e2 to 5a95aa9 Increases above 0.2%:
Increases (1 build for linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
… the FIFO. (project-chip#29919) Adds support for lock/unlock, with or without PIN. PIN can specified as either hex or ASCII digits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for lock/unlock, with or without PIN. PIN can specified as either hex or ASCII digits.