Skip to content

Commit

Permalink
TC-CC-5.4: Remove read steps (#29897)
Browse files Browse the repository at this point in the history
* TC-CC-5.4: Rmove read steps

As discussed at the MM, most clients don't use individual reads to
verify attributes. The reads in the test do not test any real client
behaviour and are not requird in the spec.

* zap

* Restyled by whitespace

---------

Co-authored-by: Restyled.io <[email protected]>
  • Loading branch information
cecille and restyled-commits authored Oct 23, 2023
1 parent d996ef1 commit 947b6e2
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 282 deletions.
82 changes: 0 additions & 82 deletions src/app/tests/suites/certification/Test_TC_CC_5_4_Simulated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,6 @@ tests:
PICS: CC.C.C07.Tx && CC.C.F03
wait: "MoveToColor"

- label: "DUT reads CurrentX attribute from TH(potentially multiple times)"
PICS: CC.C.C07.Tx && CC.C.A0003 && CC.C.F03
wait: "readAttribute"
attribute: "CurrentX"

- label: "DUT reads CurrentY attribute from TH(potentially multiple times)"
PICS: CC.C.C07.Tx && CC.C.A0004 && CC.C.F03
wait: "readAttribute"
attribute: "CurrentY"

- label: "Wait for ConfigTransitionTime"
cluster: "DelayCommands"
command: "WaitForMs"
Expand All @@ -57,30 +47,10 @@ tests:
- name: "ms"
value: ConfigTransitionTime

- label: "DUT reads CurrentX attribute from TH(potentially multiple times)"
PICS: CC.C.C07.Tx && CC.C.A0003 && CC.C.F03
wait: "readAttribute"
attribute: "CurrentX"

- label: "DUT reads CurrentY attribute from TH(potentially multiple times)"
PICS: CC.C.C07.Tx && CC.C.A0004 && CC.C.F03
wait: "readAttribute"
attribute: "CurrentY"

- label: "DUT sends MoveColor command to TH"
PICS: CC.C.C08.Tx && CC.C.F03
wait: "MoveColor"

- label: "DUT reads CurrentX attribute from TH(potentially multiple times)"
PICS: CC.C.C08.Tx && CC.C.A0003 && CC.C.F03
wait: "readAttribute"
attribute: "CurrentX"

- label: "DUT reads CurrentY attribute from TH(potentially multiple times)"
PICS: CC.C.C08.Tx && CC.C.A0004 && CC.C.F03
wait: "readAttribute"
attribute: "CurrentY"

- label: "Wait for ConfigTransitionTime"
cluster: "DelayCommands"
command: "WaitForMs"
Expand All @@ -89,30 +59,10 @@ tests:
- name: "ms"
value: ConfigTransitionTime

- label: "DUT reads CurrentX attribute from TH(potentially multiple times)"
PICS: CC.C.C08.Tx && CC.C.A0003 && CC.C.F03
wait: "readAttribute"
attribute: "CurrentX"

- label: "DUT reads CurrentY attribute from TH(potentially multiple times)"
PICS: CC.C.C08.Tx && CC.C.A0004 && CC.C.F03
wait: "readAttribute"
attribute: "CurrentY"

- label: "DUT sends StepColor command to TH"
PICS: CC.C.C09.Tx
wait: "StepColor"

- label: "DUT reads CurrentX attribute from TH(potentially multiple times)"
PICS: CC.C.C09.Tx && CC.C.A0003 && CC.C.F03
wait: "readAttribute"
attribute: "CurrentX"

- label: "DUT reads CurrentY attribute from TH(potentially multiple times)"
PICS: CC.C.C09.Tx && CC.C.A0004 && CC.C.F03
wait: "readAttribute"
attribute: "CurrentY"

- label: "Wait for ConfigTransitionTime"
cluster: "DelayCommands"
command: "WaitForMs"
Expand All @@ -121,46 +71,14 @@ tests:
- name: "ms"
value: ConfigTransitionTime

- label: "DUT reads CurrentX attribute from TH(potentially multiple times)"
PICS: CC.C.C09.Tx && CC.C.A0003 && CC.C.F03
wait: "readAttribute"
attribute: "CurrentX"

- label: "DUT reads CurrentY attribute from TH(potentially multiple times)"
PICS: CC.C.C09.Tx && CC.C.A0004 && CC.C.F03
wait: "readAttribute"
attribute: "CurrentY"

- label: "DUT sends StopMoveStep command to TH"
PICS: CC.C.C47.Tx
wait: "StopMoveStep"

- label: "DUT reads CurrentX attribute from TH(potentially multiple times)"
PICS: CC.C.C47.Tx && CC.C.A0003 && CC.C.F03
wait: "readAttribute"
attribute: "CurrentX"

- label: "DUT reads CurrentY attribute from TH(potentially multiple times)"
PICS: CC.C.C47.Tx && CC.C.A0004 && CC.C.F03
wait: "readAttribute"
attribute: "CurrentY"

- label: "Wait for ConfigTransitionTime"
cluster: "DelayCommands"
command: "WaitForMs"
arguments:
values:
- name: "ms"
value: ConfigTransitionTime

- label: "DUT reads CurrentX attribute from TH(potentially multiple times)"
PICS: CC.C.C47.Tx && CC.C.A0003 && CC.C.F03
wait: "readAttribute"
attribute: "CurrentX"

- label:
"DUT reads CurrentY attribute from ConfiguredTime: type: int16u
defaultValue: 30000TH(potentially multiple times)"
PICS: CC.C.C47.Tx && CC.C.A0004 && CC.C.F03
wait: "readAttribute"
attribute: "CurrentY"
118 changes: 18 additions & 100 deletions zzz_generated/placeholder/app1/zap-generated/test/Commands.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 947b6e2

Please sign in to comment.