-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose some more information on MTRDevice/MTRCluster*. #29769
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:expose-more-info-on-things
Oct 26, 2023
Merged
Expose some more information on MTRDevice/MTRCluster*. #29769
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:expose-more-info-on-things
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
October 13, 2023 21:45
pullapprove
bot
requested review from
sharadb-amazon,
tcarmelveilleux,
tecimovic and
tehampson
October 13, 2023 21:45
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
October 13, 2023 21:45
PR #29769: Size comparison from a7c96f0 to 3367135 Full report (19 builds for cc13x4_26x4, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
bzbarsky-apple
force-pushed
the
expose-more-info-on-things
branch
from
October 13, 2023 22:31
3367135
to
4800245
Compare
PR #29769: Size comparison from efad829 to 4800245 Increases (1 build for bl702)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Oct 18, 2023
woody-apple
approved these changes
Oct 19, 2023
andy31415
approved these changes
Oct 23, 2023
jtung-apple
approved these changes
Oct 23, 2023
* Node ID and controller on MTRDevice. * Endpoint ID and device on MTRCluster. The ids are NS_REFINED_FOR_SWIFT so we can add a nicer-typed Swift version once we can do that.
bzbarsky-apple
force-pushed
the
expose-more-info-on-things
branch
from
October 26, 2023 01:34
4800245
to
e552fe2
Compare
PR #29769: Size comparison from df468d4 to e552fe2 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
…29769) * Node ID and controller on MTRDevice. * Endpoint ID and device on MTRCluster. The ids are NS_REFINED_FOR_SWIFT so we can add a nicer-typed Swift version once we can do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ids are NS_REFINED_FOR_SWIFT so we can add a nicer-typed Swift version once we can do that.