Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Use CancellableReader for PW RPC clients #29567

Merged
merged 1 commit into from
Oct 5, 2023
Merged

tests: Use CancellableReader for PW RPC clients #29567

merged 1 commit into from
Oct 5, 2023

Conversation

ChinchillaWithGoggles
Copy link
Contributor

The CancellableReader provides a clean teardown of an RpcClient reader thread at exit.
Switching from using readers and RpcClients directly to context statements makes sure
the teardown is done. This comes from a recent change in Pigweed's RPC Python library:
https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/172051

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023 •
edited
Loading

PR #29567: Size comparison from 73c327e to 52bf44c

Full report (2 builds for cc32xx, mbed)
platform target config section 73c327e 52bf44c change % change
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 618642 618642 0 0.0
(read/write) 206900 206900 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 200344 200344 0 0.0
.comment 206 206 0 0.0
.data 1436 1436 0 0.0
.debug_abbrev 935714 935714 0 0.0
.debug_aranges 107568 107568 0 0.0
.debug_frame 363556 363556 0 0.0
.debug_info 20815624 20815624 0 0.0
.debug_line 2726142 2726142 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1556412 1556412 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 101480 101480 0 0.0
.debug_str 3387495 3387495 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106282 106282 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 511343 511343 0 0.0
.symtab 297024 297024 0 0.0
.text 510240 510240 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2523336 2523336 0 0.0
.bss 219064 219064 0 0.0
.data 5128 5128 0 0.0
.text 1486020 1486020 0 0.0

@ChinchillaWithGoggles ChinchillaWithGoggles force-pushed the pw_rpc_with_cancellable_reader branch from 52bf44c to fa52694 Compare October 4, 2023 20:12
@ChinchillaWithGoggles
tests: Use CancellableReader for PW RPC clients
4d2d9d2 
The CancellableReader provides a clean teardown of an RpcClient
reader thread at exit. Switching from using readers and RpcClients
directly to context statements makes sure the teardown is done.
This change is adapts to a recent change in Pigweed's RPC Python library:
https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/172051
@ChinchillaWithGoggles ChinchillaWithGoggles force-pushed the pw_rpc_with_cancellable_reader branch from fa52694 to 4d2d9d2 Compare October 4, 2023 20:25
@github-actions
Copy link

github-actions bot commented Oct 4, 2023 •
edited
Loading

PR #29567: Size comparison from 73c327e to 4d2d9d2

Increases (1 build for telink)
platform target config section 73c327e 4d2d9d2 change % change
telink light-switch-app tlsr9518adk80d (read/write) 866980 866988 8 0.0
text 629868 629870 2 0.0
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 73c327e 4d2d9d2 change % change
bl602 lighting-app bl602 (read/write) 1390018 1390018 0 0.0
.bss 88176 88176 0 0.0
.data 9368 9368 0 0.0
.text 1066224 1066224 0 0.0
bl602+mfd (read/write) 1403930 1403930 0 0.0
.bss 88344 88344 0 0.0
.data 9344 9344 0 0.0
.text 1081030 1081030 0 0.0
bl602+rpc (read/write) 1437190 1437190 0 0.0
.bss 96200 96200 0 0.0
.data 9728 9728 0 0.0
.text 1097956 1097956 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1193519 1193519 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 30893 30893 0 0.0
.bss_psram 65744 65744 0 0.0
.comment 48 48 0 0.0
.data 3568 3568 0 0.0
.debug_abbrev 1547703 1547703 0 0.0
.debug_aranges 138448 138448 0 0.0
.debug_frame 507972 507972 0 0.0
.debug_info 41901984 41901984 0 0.0
.debug_line 5407002 5407002 0 0.0
.debug_loc 3503024 3503024 0 0.0
.debug_ranges 378152 378152 0 0.0
.debug_str 3966498 3966498 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106804 106804 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 597029 597029 0 0.0
.symtab 177296 177296 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
960460 960460 0 0.0
bl702+mfd (read only) 3358 3358 0 0.0
(read/write) 1204099 1204099 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 31069 31069 0 0.0
.bss_psram 65744 65744 0 0.0
.comment 48 48 0 0.0
.data 3544 3544 0 0.0
.debug_abbrev 1549776 1549776 0 0.0
.debug_aranges 139616 139616 0 0.0
.debug_frame 513044 513044 0 0.0
.debug_info 41942602 41942602 0 0.0
.debug_line 5446389 5446389 0 0.0
.debug_loc 3541455 3541455 0 0.0
.debug_ranges 380152 380152 0 0.0
.debug_str 3972029 3972029 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 105744 105744 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 600789 600789 0 0.0
.symtab 179056 179056 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
971978 971978 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1292071 1292071 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 39357 39357 0 0.0
.bss_psram 65728 65728 0 0.0
.comment 48 48 0 0.0
.data 4088 4088 0 0.0
.debug_abbrev 1728597 1728597 0 0.0
.debug_aranges 147168 147168 0 0.0
.debug_frame 537316 537316 0 0.0
.debug_info 47052256 47052256 0 0.0
.debug_line 5825094 5825094 0 0.0
.debug_loc 3710009 3710009 0 0.0
.debug_ranges 405704 405704 0 0.0
.debug_str 4394574 4394574 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121868 121868 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 661770 661770 0 0.0
.symtab 196624 196624 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1034450 1034450 0 0.0
bl706-eth (read/write) 1042743 1042743 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 30006 30006 0 0.0
.bss_psram 97687 97687 0 0.0
.comment 48 48 0 0.0
.data 3248 3248 0 0.0
.debug_abbrev 1083452 1083452 0 0.0
.debug_aranges 115456 115456 0 0.0
.debug_frame 427372 427372 0 0.0
.debug_info 22654369 22654369 0 0.0
.debug_line 4339637 4339637 0 0.0
.debug_loc 3012053 3012053 0 0.0
.debug_ranges 313960 313960 0 0.0
.debug_str 3545733 3545733 0 0.0
.hbn 184 184 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 152 152 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 96504 96504 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 465324 465324 0 0.0
.symtab 139984 139984 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3338 3338 0 0.0
.text 0 0 0 0.0
786610 786610 0 0.0
bl706-wifi (read only) 3870 3870 0 0.0
(read/write) 1206306 1206306 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 14597 14597 0 0.0
.bss_psram 98455 98455 0 0.0
.comment 48 48 0 0.0
.data 3560 3560 0 0.0
.debug_abbrev 1176562 1176562 0 0.0
.debug_aranges 119632 119632 0 0.0
.debug_frame 619944 619944 0 0.0
.debug_info 23824425 23824425 0 0.0
.debug_line 4583772 4583772 0 0.0
.debug_loc 3111880 3111880 0 0.0
.debug_ranges 323776 323776 0 0.0
.debug_str 3618024 3618024 0 0.0
.hbn 468 468 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 109632 109632 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 506051 506051 0 0.0
.symtab 152848 152848 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3870 3870 0 0.0
.text 0 0 0 0.0
953578 953578 0 0.0
bl702l lighting-app bl702l (read only) 278 278 0 0.0
(read/write) 1156664 1156664 0 0.0
.boot2 292 292 0 0.0
.bss 20368 20368 0 0.0
.bss_psram 77184 77184 0 0.0
.comment 48 48 0 0.0
.data 4512 4512 0 0.0
.debug_abbrev 1541991 1541991 0 0.0
.debug_aranges 133312 133312 0 0.0
.debug_frame 488612 488612 0 0.0
.debug_info 41359981 41359981 0 0.0
.debug_line 5310137 5310137 0 0.0
.debug_loc 3447281 3447281 0 0.0
.debug_ranges 384688 384688 0 0.0
.debug_str 3991094 3991094 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 144 144 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 100784 100784 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 286 286 0 0.0
.stack 2048 2048 0 0.0
.strtab 598655 598655 0 0.0
.symtab 176736 176736 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
943274 943274 0 0.0
bl702l+mfd (read only) 278 278 0 0.0
(read/write) 1167540 1167540 0 0.0
.boot2 292 292 0 0.0
.bss 20544 20544 0 0.0
.bss_psram 77184 77184 0 0.0
.comment 48 48 0 0.0
.data 4488 4488 0 0.0
.debug_abbrev 1544079 1544079 0 0.0
.debug_aranges 134480 134480 0 0.0
.debug_frame 493680 493680 0 0.0
.debug_info 41402642 41402642 0 0.0
.debug_line 5349401 5349401 0 0.0
.debug_loc 3485712 3485712 0 0.0
.debug_ranges 386688 386688 0 0.0
.debug_str 3996615 3996615 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 144 144 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 99724 99724 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 286 286 0 0.0
.stack 2048 2048 0 0.0
.strtab 602483 602483 0 0.0
.symtab 178528 178528 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
955058 955058 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 737331 737331 0 0.0
(read/write) 166444 166444 0 0.0
.bss 88860 88860 0 0.0
.data 3420 3420 0 0.0
.rodata 84383 84383 0 0.0
.text 652556 652556 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 757987 757987 0 0.0
(read/write) 176700 176700 0 0.0
.bss 99084 99084 0 0.0
.data 3436 3436 0 0.0
.rodata 80087 80087 0 0.0
.text 677512 677512 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 745523 745523 0 0.0
(read/write) 171172 171172 0 0.0
.bss 93556 93556 0 0.0
.data 3436 3436 0 0.0
.rodata 106111 106111 0 0.0
.text 639024 639024 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 696075 696075 0 0.0
(read/write) 165536 165536 0 0.0
.bss 87728 87728 0 0.0
.data 3408 3408 0 0.0
.rodata 80271 80271 0 0.0
.text 615412 615412 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 681739 681739 0 0.0
(read/write) 165676 165676 0 0.0
.bss 87872 87872 0 0.0
.data 3404 3404 0 0.0
.rodata 76111 76111 0 0.0
.text 605236 605236 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 618642 618642 0 0.0
(read/write) 206900 206900 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 200344 200344 0 0.0
.comment 206 206 0 0.0
.data 1436 1436 0 0.0
.debug_abbrev 935714 935714 0 0.0
.debug_aranges 107568 107568 0 0.0
.debug_frame 363556 363556 0 0.0
.debug_info 20815624 20815624 0 0.0
.debug_line 2726142 2726142 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1556412 1556412 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 101480 101480 0 0.0
.debug_str 3387495 3387495 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106282 106282 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 511343 511343 0 0.0
.symtab 297024 297024 0 0.0
.text 510240 510240 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 554495 554495 0 0.0
.app_xip_area 445697 445697 0 0.0
.bss 63768 63768 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 539791 539791 0 0.0
.app_xip_area 426201 426201 0 0.0
.bss 68536 68536 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 575063 575063 0 0.0
.app_xip_area 467593 467593 0 0.0
.bss 62512 62512 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 551655 551655 0 0.0
.app_xip_area 441089 441089 0 0.0
.bss 65512 65512 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1009020 1009020 0 0.0
.bss 171940 171940 0 0.0
.data 2684 2684 0 0.0
.text 834372 834372 0 0.0
BRD4187C (read/write) 1091560 1091560 0 0.0
.bss 196064 196064 0 0.0
.data 3268 3268 0 0.0
.text 892208 892208 0 0.0
lock-app BRD4161A+wf200 (read/write) 1105344 1105344 0 0.0
.bss 186628 186628 0 0.0
.data 2696 2696 0 0.0
.text 916000 916000 0 0.0
window-app BRD4187C (read/write) 1125436 1125436 0 0.0
.bss 168472 168472 0 0.0
.data 3140 3140 0 0.0
.text 953804 953804 0 0.0
esp32 all-clusters-app c3devkit (read only) 1165668 1165668 0 0.0
(read/write) 1701860 1701860 0 0.0
.dram0.bss 77640 77640 0 0.0
.dram0.data 13060 13060 0 0.0
.flash.rodata 268432 268432 0 0.0
.flash.text 1165668 1165668 0 0.0
.iram0.text 75244 75244 0 0.0
m5stack (read only) 1208107 1208107 0 0.0
(read/write) 551794 551794 0 0.0
.dram0.bss 84288 84288 0 0.0
.dram0.data 34020 34020 0 0.0
.flash.rodata 299868 299868 0 0.0
.flash.text 1202723 1202723 0 0.0
.iram0.text 123287 123287 0 0.0
k32w contact k32w0+release (read only) 590268 590268 0 0.0
(read/write) 87512 87512 0 0.0
.bss 70760 70760 0 0.0
.data 2128 2128 0 0.0
.text 589732 589732 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 685504 685504 0 0.0
.bss 66976 66976 0 0.0
.data 2716 2716 0 0.0
.text 572336 572336 0 0.0
light k32w0+release (read only) 589964 589964 0 0.0
(read/write) 87188 87188 0 0.0
.bss 70448 70448 0 0.0
.data 2116 2116 0 0.0
.text 589428 589428 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 777188 777188 0 0.0
.bss 76628 76628 0 0.0
.data 1928 1928 0 0.0
.text 655176 655176 0 0.0
lock k32w0+release (read only) 561412 561412 0 0.0
(read/write) 85016 85016 0 0.0
.bss 68336 68336 0 0.0
.data 2056 2056 0 0.0
.text 560876 560876 0 0.0
linux all-clusters-app debug (read only) 5546217 5546217 0 0.0
(read/write) 420584 420584 0 0.0
.bss 130480 130480 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 278880 278880 0 0.0
.dynamic 624 624 0 0.0
.got 5384 5384 0 0.0
.init 27 27 0 0.0
.init_array 1328 1328 0 0.0
.rodata 336236 336236 0 0.0
.text 4829139 4829139 0 0.0
all-clusters-minimal-app debug (read only) 4908601 4908601 0 0.0
(read/write) 232688 232688 0 0.0
.bss 126512 126512 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 95280 95280 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 270781 270781 0 0.0
.text 4406707 4406707 0 0.0
bridge-app debug (read only) 2765161 2765161 0 0.0
(read/write) 133168 133168 0 0.0
.bss 51736 51736 0 0.0
.data 3680 3680 0 0.0
.data.rel.ro 71648 71648 0 0.0
.dynamic 624 624 0 0.0
.got 4640 4640 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213472 213472 0 0.0
.text 2373923 2373923 0 0.0
chip-tool debug (read only) 10323889 10323889 0 0.0
(read/write) 443064 443064 0 0.0
.bss 93688 93688 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 337136 337136 0 0.0
.dynamic 624 624 0 0.0
.got 5808 5808 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 387369 387369 0 0.0
.text 9339475 9339475 0 0.0
chip-tool-ipv6only arm64 (read only) 10188940 10188940 0 0.0
(read/write) 505544 505544 0 0.0
.bss 103032 103032 0 0.0
.data 4288 4288 0 0.0
.data.rel.ro 374400 374400 0 0.0
.dynamic 512 512 0 0.0
.got 18368 18368 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 316152 316152 0 0.0
.text 9106520 9106520 0 0.0
lighting-app debug+rpc+ui (read only) 5239553 5239553 0 0.0
(read/write) 222792 222792 0 0.0
.bss 118160 118160 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 92640 92640 0 0.0
.dynamic 672 672 0 0.0
.got 5928 5928 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 336724 336724 0 0.0
.text 4660035 4660035 0 0.0
lock-app debug (read only) 4468273 4468273 0 0.0
(read/write) 203128 203128 0 0.0
.bss 113424 113424 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79288 79288 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 247069 247069 0 0.0
.text 4011587 4011587 0 0.0
ota-provider-app debug (read only) 4125761 4125761 0 0.0
(read/write) 192064 192064 0 0.0
.bss 113568 113568 0 0.0
.data 3920 3920 0 0.0
.data.rel.ro 68656 68656 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 200221 200221 0 0.0
.text 3734979 3734979 0 0.0
ota-requestor-app debug (read only) 4216025 4216025 0 0.0
(read/write) 196280 196280 0 0.0
.bss 114592 114592 0 0.0
.data 4160 4160 0 0.0
.data.rel.ro 71632 71632 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 203485 203485 0 0.0
.text 3817651 3817651 0 0.0
shell debug (read only) 2945297 2945297 0 0.0
(read/write) 153248 153248 0 0.0
.bss 61000 61000 0 0.0
.data 784 784 0 0.0
.data.rel.ro 85544 85544 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 211968 211968 0 0.0
.text 2559890 2559890 0 0.0
thermostat-no-ble arm64 (read only) 4359916 4359916 0 0.0
(read/write) 242008 242008 0 0.0
.bss 122168 122168 0 0.0
.data 2792 2792 0 0.0
.data.rel.ro 100696 100696 0 0.0
.dynamic 512 512 0 0.0
.got 11896 11896 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 161164 161164 0 0.0
.text 3863960 3863960 0 0.0
tv-app debug (read only) 5306545 5306545 0 0.0
(read/write) 350696 350696 0 0.0
.bss 241888 241888 0 0.0
.data 5024 5024 0 0.0
.data.rel.ro 96384 96384 0 0.0
.dynamic 624 624 0 0.0
.got 5608 5608 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 271405 271405 0 0.0
.text 4791059 4791059 0 0.0
tv-casting-app debug (read only) 8264241 8264241 0 0.0
(read/write) 211720 211720 0 0.0
.bss 54752 54752 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 147696 147696 0 0.0
.dynamic 624 624 0 0.0
.got 5080 5080 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 337368 337368 0 0.0
.text 7525379 7525379 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2523336 2523336 0 0.0
.bss 219064 219064 0 0.0
.data 5128 5128 0 0.0
.text 1486020 1486020 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1232704 1232704 0 0.0
bss 155134 155134 0 0.0
rodata 142740 142740 0 0.0
text 855888 855888 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1351428 1351428 0 0.0
bss 140544 140544 0 0.0
rodata 136848 136848 0 0.0
text 783356 783356 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1164500 1164500 0 0.0
bss 154564 154564 0 0.0
rodata 113768 113768 0 0.0
text 817204 817204 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 837512 837512 0 0.0
(read/write) 1782684 1782684 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 193300 193300 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2528 2528 0 0.0
.debug_abbrev 1379226 1379226 0 0.0
.debug_aranges 144272 144272 0 0.0
.debug_frame 479340 479340 0 0.0
.debug_info 32400215 32400215 0 0.0
.debug_line 4107753 4107753 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2239146 2239146 0 0.0
.debug_rnglists 145380 145380 0 0.0
.debug_str 4141332 4141332 0 0.0
.heap 837512 837512 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 837205 837205 0 0.0
.symtab 511936 511936 0 0.0
.text 1578468 1578468 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 840168 840168 0 0.0
(read/write) 1683564 1683564 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190708 190708 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1260221 1260221 0 0.0
.debug_aranges 136072 136072 0 0.0
.debug_frame 457768 457768 0 0.0
.debug_info 28740650 28740650 0 0.0
.debug_line 3866903 3866903 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2112531 2112531 0 0.0
.debug_rnglists 136947 136947 0 0.0
.debug_str 3942972 3942972 0 0.0
.heap 840168 840168 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 734961 734961 0 0.0
.symtab 472784 472784 0 0.0
.text 1482004 1482004 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 846496 846496 0 0.0
(read/write) 1609668 1609668 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184492 184492 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2352 2352 0 0.0
.debug_abbrev 1101193 1101193 0 0.0
.debug_aranges 126136 126136 0 0.0
.debug_frame 420700 420700 0 0.0
.debug_info 23861976 23861976 0 0.0
.debug_line 3441685 3441685 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1949255 1949255 0 0.0
.debug_rnglists 126499 126499 0 0.0
.debug_str 3750054 3750054 0 0.0
.heap 846496 846496 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 650153 650153 0 0.0
.symtab 435024 435024 0 0.0
.text 1414436 1414436 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 819232 819232 0 0.0
(read/write) 1641628 1641628 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 211740 211740 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2368 2368 0 0.0
.debug_abbrev 1093384 1093384 0 0.0
.debug_aranges 124768 124768 0 0.0
.debug_frame 415724 415724 0 0.0
.debug_info 23665319 23665319 0 0.0
.debug_line 3392303 3392303 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1924820 1924820 0 0.0
.debug_rnglists 124440 124440 0 0.0
.debug_str 3712044 3712044 0 0.0
.heap 819232 819232 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 623083 623083 0 0.0
.symtab 426192 426192 0 0.0
.text 1419132 1419132 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1177680 1177680 0 0.0
.bss 100616 100616 0 0.0
.data 740 740 0 0.0
.text 624520 624520 0 0.0
lock-app qpg6105+debug (read/write) 1134296 1134296 0 0.0
.bss 95320 95320 0 0.0
.data 744 744 0 0.0
.text 581140 581140 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1152020 1152020 0 0.0
bss 113224 113224 0 0.0
text 803172 803172 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1096016 1096016 0 0.0
bss 122244 122244 0 0.0
text 760820 760820 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 949676 949676 0 0.0
bss 106888 106888 0 0.0
text 656310 656310 0 0.0
contact-sensor-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 878648 878648 0 0.0
bss 78124 78124 0 0.0
text 622714 622714 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 866980 866988 8 0.0
bss 67036 67036 0 0.0
text 629868 629870 2 0.0
lighting-app-rpc-shell-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1001904 1001904 0 0.0
bss 109148 109148 0 0.0
text 704830 704830 0 0.0
tlsr9528a (read only) 4 4 0 0.0
(read/write) 1046964 1046964 0 0.0
bss 120896 120896 0 0.0
text 728116 728116 0 0.0
lock-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 934792 934792 0 0.0
bss 78816 78816 0 0.0
text 652076 652076 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 963268 963268 0 0.0
bss 104988 104988 0 0.0
text 672328 672328 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 882396 882396 0 0.0
bss 78228 78228 0 0.0
text 626780 626780 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 823236 823236 0 0.0
bss 66240 66240 0 0.0
text 593822 593822 0 0.0
resource-monitoring-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 839064 839064 0 0.0
bss 66656 66656 0 0.0
text 604554 604554 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 716020 716020 0 0.0
bss 86424 86424 0 0.0
text 469654 469654 0 0.0
smoke_co_alarm-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 880576 880576 0 0.0
bss 78208 78208 0 0.0
text 625576 625576 0 0.0
temperature-measurement-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 865844 865844 0 0.0
bss 77928 77928 0 0.0
text 613000 613000 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 844612 844612 0 0.0
bss 66540 66540 0 0.0
text 609458 609458 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 841800 841800 0 0.0
bss 66892 66892 0 0.0
text 606232 606232 0 0.0

@mergify mergify bot merged commit 3f34c52 into project-chip:master Oct 5, 2023
52 checks passed
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this pull request Oct 23, 2023
@ChinchillaWithGoggles @HunsupJung
tests: Use CancellableReader for PW RPC clients (project-chip#29567)
3fe6d76 
The CancellableReader provides a clean teardown of an RpcClient
reader thread at exit. Switching from using readers and RpcClients
directly to context statements makes sure the teardown is done.
This change is adapts to a recent change in Pigweed's RPC Python library:
https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/172051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tehampson tehampson tehampson approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track review - pending test driver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChinchillaWithGoggles @CLAassistant @tehampson @andy31415