Skip to content

Commit

Permalink
Update Test_TC_OO_2_4 to reflect testspec PR#2464 update (#26314)
Browse files Browse the repository at this point in the history
* Update Test_TC_OO_2_4 to reflectup testspec PR#2464 update

* Address PR comment
  • Loading branch information
tehampson authored and pull[bot] committed Jan 19, 2024
1 parent 0fe50a2 commit 2726142
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 32 deletions.
24 changes: 6 additions & 18 deletions src/app/tests/suites/certification/Test_TC_OO_2_4.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -238,24 +238,12 @@ tests:
PICS: OO.S.C00.Rsp
command: "Off"

# We get an acknowledgment that the command off above is received, but it takes
# a few milliseconds for the off command to actually turn it off. Without this
# delay the preceding reboot command might happen before the command is fully
# processed resulting in flaky test failure that comes from the readAddribute
# verification after the reboot.
# TODO once https://github.com/CHIP-Specifications/chip-test-plans/pull/2464 is
# merged, change this command to a readAtribute and update PICS code to
# OO.S.A0000. PR is blocked from being merged at this time due to freeze for
# SVE. Likely after March 17th, 2023 this PR can be merged and associated
# changes made here to officially fix the flake discovered by CI.
- label: "Wait for send Off command to take affect"
PICS: PICS_SDK_CI_ONLY
cluster: "DelayCommands"
command: "WaitForMs"
arguments:
values:
- name: "ms"
value: 10
- label: "TH reads the OnOff attribute from the DUT"
PICS: OO.S.A0000
command: "readAttribute"
attribute: "OnOff"
response:
value: 0

- label: "Reboot target device"
PICS: PICS_SDK_CI_ONLY
Expand Down
15 changes: 8 additions & 7 deletions zzz_generated/chip-tool/zap-generated/test/Commands.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 22 additions & 7 deletions zzz_generated/darwin-framework-tool/zap-generated/test/Commands.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 2726142

Please sign in to comment.