Look for more flash space savings in cluster-objects.cpp #29561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
pullapprove
bot
requested review from
younghak-hwang,
yufengwangca and
yunhanw-google
andy31415
commented
Oct 4, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
woody-apple
approved these changes
Oct 4, 2023
This comment was marked as outdated.
This comment was marked as outdated.
…ro invocation seems to make code even smaller
This comment was marked as outdated.
This comment was marked as outdated.
tcarmelveilleux
approved these changes
Oct 4, 2023
… code on empty structs (mainly command inputs)
This comment was marked as outdated.
This comment was marked as outdated.
|
PR #29561: Size comparison from 1d21df9 to c735e5c Increases above 0.2%:
Increases (12 builds for bl702, bl702l, cc32xx, psoc6)
Decreases (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 5, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…p#29561) * Updates to cluster objects: use direct context tag comparisons * Also optimize code size usage for structure decoding * Completely split struct iterations and use std::variant based returns on an iterator * Another space save: using a common err for all decodes and single macro invocation seems to make code even smaller * One more cleanup return and proper use of first/last to remove unused code on empty structs (mainly command inputs) * Added a comment and a missed auto keyword * Missed some first/last iterations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can have some space savings by reducing repeated code in this file.
Changes for now:
We may iterate a bit over size deltas here.