[crypto] Extract common X509 functions for mbedTLS and PSA #29484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damian-Nordic
changed the title
Damian-Nordic
force-pushed
the
psa-unify
branch
from
6673bc5 to
5b26800
Compare
|
PR #29484: Size comparison from aedf2d5 to 5b26800 Increases above 0.2%:
Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (4 builds for cc32xx, mbed, qpg)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #29484: Size comparison from aedf2d5 to 81b6ecd Increases above 0.2%:
Increases (17 builds for bl602, bl702, bl702l, cc32xx, psoc6, telink)
Decreases (12 builds for bl702, bl702l, cc32xx, psoc6)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
approved these changes
Oct 2, 2023
PSA crypto backend uses mbedTLS API to implement functions for certificate generation and parsing, so the functions are duplicated between PSA and mbedTLS backends. Extract the functions to reduce the code duplication.
Damian-Nordic
force-pushed
the
psa-unify
branch
from
81b6ecd to
b65bfaf
Compare
|
PR #29484: Size comparison from a40b53c to b65bfaf Increases above 0.2%:
Increases (17 builds for bl602, bl702, bl702l, cc32xx, psoc6, telink)
Decreases (12 builds for bl702, bl702l, cc32xx, psoc6)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…hip#29484) * [crypto] Extract X509 functions for mbedTLS and PSA PSA crypto backend uses mbedTLS API to implement functions for certificate generation and parsing, so the functions are duplicated between PSA and mbedTLS backends. Extract the functions to reduce the code duplication. * Restyled by whitespace * Restyled by gn * Code review --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PSA crypto backend uses mbedTLS API to implement functions for certificate generation and parsing, so the functions are duplicated between PSA and mbedTLS backends.
Extract the functions to reduce the code duplication.
This is related to #27831, but the issue also mentions other crypto backends defined in
src/platformfor which the functions are not 100% the same and I am not able to test the code changes on these platforms.