You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If possible, move all x509 common code for mbedtls in a new .ipp file that is includable from all mbedtls-based CryptoPALs ? The duplication is a lot and keeps growing. See comment in this PR for the reference: #26913 (review)
Currently, there are 6 variations of very similar mbedTLS-based implementations in these files:
src/crypto/CHIPCryptoPALPSA.cpp
src/crypto/CHIPCryptoPALmbedTLS.cpp
src/platform/nxp/common/crypto/CHIPCryptoPALTinyCrypt.cpp
src/platform/nxp/k32w/k32w0/crypto/CHIPCryptoPALNXPUltrafastP256.cpp
src/platform/silabs/SiWx917/CHIPCryptoPALTinyCrypt.cpp
src/platform/silabs/efr32/CHIPCryptoPALPsaEfr32.cpp
Updating and maintaining each one of them manually may lead to errors and inconsistencies.
Reproduction steps
If possible, move all x509 common code for mbedtls in a new .ipp file that is includable from all mbedtls-based CryptoPALs ? The duplication is a lot and keeps growing. See comment in this PR for the reference:
#26913 (review)
Currently, there are 6 variations of very similar mbedTLS-based implementations in these files:
src/crypto/CHIPCryptoPALPSA.cpp
src/crypto/CHIPCryptoPALmbedTLS.cpp
src/platform/nxp/common/crypto/CHIPCryptoPALTinyCrypt.cpp
src/platform/nxp/k32w/k32w0/crypto/CHIPCryptoPALNXPUltrafastP256.cpp
src/platform/silabs/SiWx917/CHIPCryptoPALTinyCrypt.cpp
src/platform/silabs/efr32/CHIPCryptoPALPsaEfr32.cpp
Updating and maintaining each one of them manually may lead to errors and inconsistencies.
Bug prevalence
100% of the time
GitHub hash of the SDK that was being used
9f664e1
Platform
core
Platform Version(s)
No response
Type
Core SDK Performance Improvement
Anything else?
No response
The text was updated successfully, but these errors were encountered: