Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.2] Extract Common mbedTLS Code into New IPP File #27831

Open
emargolis opened this issue Jul 8, 2023 · 0 comments
Open

[1.2] Extract Common mbedTLS Code into New IPP File #27831

emargolis opened this issue Jul 8, 2023 · 0 comments
Labels
bug Something isn't working needs triage

Comments

@emargolis
Copy link
Contributor

Reproduction steps

If possible, move all x509 common code for mbedtls in a new .ipp file that is includable from all mbedtls-based CryptoPALs ? The duplication is a lot and keeps growing. See comment in this PR for the reference:
#26913 (review)

Currently, there are 6 variations of very similar mbedTLS-based implementations in these files:
src/crypto/CHIPCryptoPALPSA.cpp
src/crypto/CHIPCryptoPALmbedTLS.cpp
src/platform/nxp/common/crypto/CHIPCryptoPALTinyCrypt.cpp
src/platform/nxp/k32w/k32w0/crypto/CHIPCryptoPALNXPUltrafastP256.cpp
src/platform/silabs/SiWx917/CHIPCryptoPALTinyCrypt.cpp
src/platform/silabs/efr32/CHIPCryptoPALPsaEfr32.cpp

Updating and maintaining each one of them manually may lead to errors and inconsistencies.

Bug prevalence

100% of the time

GitHub hash of the SDK that was being used

9f664e1

Platform

core

Platform Version(s)

No response

Type

Core SDK Performance Improvement

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

No branches or pull requests

1 participant