-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Add units to configs and variables #29417
Merged
mkardous-silabs
merged 6 commits into
project-chip:master
from
mkardous-silabs:fix/add_unit
Sep 22, 2023
Merged
[ICD] Add units to configs and variables #29417
mkardous-silabs
merged 6 commits into
project-chip:master
from
mkardous-silabs:fix/add_unit
Sep 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
September 22, 2023 15:06
pullapprove
bot
requested review from
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
September 22, 2023 15:06
PR #29417: Size comparison from 55607f4 to 6b50a81 Increases (3 builds for cc32xx, psoc6)
Decreases (3 builds for cc32xx, psoc6)
Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, psoc6, qpg)
|
jmartinez-silabs
approved these changes
Sep 22, 2023
andy31415
reviewed
Sep 22, 2023
andy31415
reviewed
Sep 22, 2023
andy31415
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
PR #29417: Size comparison from 55607f4 to d1df53e Increases (10 builds for bl702, bl702l, cc32xx, psoc6)
Decreases (7 builds for cc32xx, efr32, linux, psoc6, qpg)
Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, psoc6, qpg)
|
jtung-apple
approved these changes
Sep 22, 2023
jtung-apple
reviewed
Sep 22, 2023
mkardous-silabs
force-pushed
the
fix/add_unit
branch
from
September 22, 2023 18:27
26c956e
to
9d927f9
Compare
mkardous-silabs
force-pushed
the
fix/add_unit
branch
from
September 22, 2023 18:40
9d927f9
to
1a8fb4c
Compare
PR #29417: Size comparison from 181b7a9 to e24d2c6 Increases (3 builds for cc32xx, psoc6)
Decreases (3 builds for cc32xx, psoc6)
Full report (77 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Add units to defines and variables * restyle * rename functions and remove comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
core
icd
Intermittently Connected Devices
lib
nrf connect
platform
review - approved
silabs
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add units to the name of the different configurations and variables.
Addresses #27272 (comment)