-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample Manufacturer Extension Cluster #29162
Merged
mergify
merged 36 commits into
project-chip:master
from
rochaferraz:chef_custom_clusters_to_github_smashed
Sep 12, 2023
Merged
Sample Manufacturer Extension Cluster #29162
mergify
merged 36 commits into
project-chip:master
from
rochaferraz:chef_custom_clusters_to_github_smashed
Sep 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
examples
scripts
darwin
controller
app
github
workflows
labels
Sep 11, 2023
PR #29162: Size comparison from b274b9e to 3f4aba2 Increases above 0.2%:
Increases (23 builds for bl702, bl702l, cc32xx, linux, psoc6)
Decreases (2 builds for efr32, esp32)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/zap-templates/zcl/data-model/chip/sample-mei-cluster.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
PR #29162: Size comparison from b274b9e to 8a56771 Increases above 0.2%:
Increases (12 builds for bl702, bl702l, cc32xx, linux, psoc6)
Decreases (2 builds for efr32, esp32)
Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #29162: Size comparison from b274b9e to 8d4ef76 Increases above 0.2%:
Increases (23 builds for bl702, bl702l, cc32xx, linux, psoc6)
Decreases (9 builds for bl602, bl702, bl702l, efr32, esp32)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
rochaferraz
commented
Sep 12, 2023
PR #29162: Size comparison from b274b9e to 42588d6 Increases above 0.2%:
Increases (23 builds for bl702, bl702l, cc32xx, linux, psoc6)
Decreases (9 builds for bl602, bl702, bl702l, efr32, esp32)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Sep 12, 2023
PR #29162: Size comparison from b274b9e to cb3dbca Increases above 0.2%:
Increases (23 builds for bl702, bl702l, cc32xx, linux, psoc6)
Decreases (9 builds for bl602, bl702, bl702l, efr32, esp32)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cecille
reviewed
Sep 12, 2023
cecille
approved these changes
Sep 12, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* new: chef test custom cluster * MEI sample cluster. Chef device sample * renamed some symbols * fix: sampleMei doesn't need zap-generated command callbacks * chg: new implementation of cluster supports many endpoints * chg: zap regen * chg: removed unused variable captured in closure * chg: changed %lu to %zu for size_t types * commands made non-optional. Restyle * removed reference for availability.yaml * fix: controller-clusters.zap as a samplemei client cluster, not server * fix: sample mei command handling on adding, availability.yaml * chg: replaced %zu to type castings. Lint doesn't like %zu * fix: removed event list from data model * fix: event list removed from controller-clusters.zap * chg: sample mei <code> tag doc * fix: last bits of controller-clusters.zap got cut when rebased * chg: zap regen after new zap version installed * changed MEI to Mei in cluster name * Restyled by whitespace * Restyled by clang-format * Update src/darwin/Framework/CHIP/templates/availability.yaml Co-authored-by: Boris Zbarsky <[email protected]> * Update src/app/zap-templates/zcl/data-model/chip/sample-mei-cluster.xml Co-authored-by: Boris Zbarsky <[email protected]> * Update src/app/clusters/sample-mei-server/sample-mei-server.cpp Co-authored-by: Boris Zbarsky <[email protected]> * capitalized MEI * chg: cluster added to ClustersWithShutdownFunctions * chg: included app/util/config.h in sample-mei-server.h * fix: shutdown calls UnregisterEndpoint * fix: shutdown calls UnregisterEndpoint * fix: name of cluster in config-data.yaml * Restyled by clang-format * chg: removed dead code * chg: error codes for r/w * Restyled by clang-format * chg: issue number in config-data.yaml --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds a sample for a Manufacturer Extension Cluster
The
Sample MEI
cluster is defined insrc/app/zap-templates/zcl/data-model/chip/sample-mei-cluster.xml
This cluster has
flip-flop
ping
command with no argumentsadd-arguments
. The command takes twouint8
arguments and the response command returns their sum.
Tested using chip-tool using the following commands:
To be merged after project-chip/zap#1133 has been reflected here @bzbarsky-apple
@cecille