fix: shutdown calls UnregisterEndpoint

project-chip · Sep 11, 2023 · 8d4ef76 · 8d4ef76
1 parent 9a865fd
commit 8d4ef76
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/app/clusters/sample-mei-server/sample-mei-server.cpp b/src/app/clusters/sample-mei-server/sample-mei-server.cpp
@@ -47,6 +47,8 @@ void MatterSampleMeiPluginServerInitCallback()
 
 void MatterSampleMeiClusterServerShutdownCallback(chip::EndpointId endpoint)
 {
+    // There's currently no whole-cluster shutdown callback. That would trigger
+    // call to `Shutdown`. Thus ep-based shutdown calls `UnregisterEndpoint`
     sampleMeiServer.UnregisterEndpoint(endpoint);
 }
 

diff --git a/src/app/clusters/sample-mei-server/sample-mei-server.h b/src/app/clusters/sample-mei-server/sample-mei-server.h
@@ -52,6 +52,9 @@ class SampleMeiServer : public AttributeAccessInterface, public CommandHandlerIn
         CommandHandlerInterface(Optional<EndpointId>(), Id)
     {}
     static SampleMeiServer & Instance();
+
+    // Currently not used, but should be called from a whole-cluster shutdown
+    // callback once cluster lifecycle is clearer
     void Shutdown();
 
     // Attributes