-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for [CERT-TEST-FAILURE]-TC-FAN-1.1
#28830
Merged
mergify
merged 4 commits into
project-chip:master
from
dysonltd:hotfix/fan-control-tc-1-1
Aug 23, 2023
Merged
Fix for [CERT-TEST-FAILURE]-TC-FAN-1.1
#28830
mergify
merged 4 commits into
project-chip:master
from
dysonltd:hotfix/fan-control-tc-1-1
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ep and to also look for the correct value. Also regenned the tests.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
August 23, 2023 11:12
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yufengwangca
August 23, 2023 11:12
p0fi
approved these changes
Aug 23, 2023
PR #28830: Size comparison from 4e5cf29 to de8276f Decreases (1 build for efr32)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Aug 23, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
* Added cluster revision to XML so it defaults in zaptool * Updated cluster revision for Fan COntrol to 4, as per XML * Regenned the code * Updated TC_FAN_1_1 to make the cluster revision check an automated step and to also look for the correct value. Also regenned the tests.
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Added cluster revision to XML so it defaults in zaptool * Updated cluster revision for Fan COntrol to 4, as per XML * Regenned the code * Updated TC_FAN_1_1 to make the cluster revision check an automated step and to also look for the correct value. Also regenned the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the Cert Test Failure raised in #27320.
fan-control
to have cluster revisionLinks
Fixes #27320