-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ReadHandler] ReportScheduler Injection #28497
Merged
mergify
merged 9 commits into
project-chip:master
from
lpbeliveau-silabs:feature/report_scheduler_injection
Aug 4, 2023
Merged
[ReadHandler] ReportScheduler Injection #28497
mergify
merged 9 commits into
project-chip:master
from
lpbeliveau-silabs:feature/report_scheduler_injection
Aug 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a pointer to a report scheduler in ServerInitParams so it gets injected
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
August 3, 2023 15:01
PR #28497: Size comparison from e149350 to 53ba76b Increases above 0.2%:
Increases (65 builds for bl602, bl702, bl702l, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (17 builds for bl702, bl702l, cc32xx, linux, psoc6, telink)
Full report (67 builds for bl602, bl702, bl702l, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28497: Size comparison from e149350 to 55bccd6 Increases above 0.2%:
Increases (63 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (15 builds for bl702, bl702l, cc32xx, linux, psoc6)
Full report (65 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28497: Size comparison from e149350 to ae40e28 Increases above 0.2%:
Increases (65 builds for bl602, bl702, bl702l, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (16 builds for bl702, bl702l, cc32xx, esp32, linux, psoc6)
Full report (67 builds for bl602, bl702, bl702l, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28497: Size comparison from e149350 to fc152e6 Increases above 0.2%:
Increases (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (31 builds for bl602, bl702, bl702l, cyw30739, k32w, linux, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…s now in Common Server Init params
lpbeliveau-silabs
force-pushed
the
feature/report_scheduler_injection
branch
from
August 4, 2023 18:20
fc152e6
to
9ebd8b5
Compare
…tore CHIPConfig Synchronous reports to 0
lpbeliveau-silabs
force-pushed
the
feature/report_scheduler_injection
branch
from
August 4, 2023 18:36
4e19b3f
to
1e89639
Compare
PR #28497: Size comparison from 1465733 to 1e89639 Increases above 0.2%:
Increases (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (39 builds for bl602, bl702, bl702l, cc32xx, cyw30739, esp32, k32w, linux, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Aug 4, 2023
jmartinez-silabs
approved these changes
Aug 4, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 15, 2023
* Moved the default report scheduler to the application code and added a pointer to a report scheduler in ServerInitParams so it gets injected * Restyled by clang-format * Added a default ReportScheduler to the server init * Restyled by clang-format * Removed the double instanciation of report scheduler in ESP32 to reduce ram usage * Restyled by clang-format * Removed instanciation of ReportScheduler in examples as the default is now in Common Server Init params * Restyled by clang-format * Removed un-necessary mention to CommonCaseDeviceServerInitParams, restore CHIPConfig Synchronous reports to 0 --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowed injection of ReportScheduler from app layer without having a static default scheduler in place in the Server instance.
The default scheduler needs to be manually is still instantiated in CommonCaseDeviceServerInitParams. It can also be injected in the the server's initParams like such:
This resolves the issue: #28183