Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReadHandler] Allow custom ReportScheduler Injection #28183

Closed
lpbeliveau-silabs opened this issue Jul 21, 2023 · 2 comments · Fixed by #28497
Closed

[ReadHandler] Allow custom ReportScheduler Injection #28183

lpbeliveau-silabs opened this issue Jul 21, 2023 · 2 comments · Fixed by #28497

Comments

@lpbeliveau-silabs
Copy link
Contributor

lpbeliveau-silabs commented Jul 21, 2023

Currently, we are choosing between unsynchronized and synchronized report scheduler by a define in CHIPConfig.h :
CHIP_CONFIG_SYNCHRONOUS_REPORTS_ENABLED

We could allow users to define their own scheduler by allowing injection from the app layer by passing a pointer to a reportscheduler implementaiton in the Server::Init()

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Jul 21, 2023

We could allow users to define their own scheduler by allowing injection from the app layer

Uh... that is in fact what you have currently implemented, no? You can set any scheduler you want in the params passed to server init. I am very unclear as to what this issue is about @lpbeliveau-silabs .

@lpbeliveau-silabs
Copy link
Contributor Author

While it was the case at some point during the merge of integration, it was removed on a request in the integration PR: #28104 (comment)

We currently offer the option between the Synchronized Scheduler and the default one from config, however it is not in ServerInitParams anymore.

A user would need to edit Server.cpp/.h to be able to change the scheduling logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants