-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ReadHandler] Integration of ReportScheduler into the ReadHandler and IM engine. #28104
[ReadHandler] Integration of ReportScheduler into the ReadHandler and IM engine. #28104
Conversation
141aa07
to
3905775
Compare
PR #28104: Size comparison from 484dcd8 to eef08a8 Increases above 0.2%:
Increases (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for psoc6)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Co-authored-by: Boris Zbarsky <[email protected]>
PR #28104: Size comparison from 484dcd8 to 53b0c8a Increases above 0.2%:
Increases (25 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Decreases (4 builds for psoc6)
Full report (25 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
…ng causing failure in linux CI
PR #28104: Size comparison from 484dcd8 to 00cd10e Increases above 0.2%:
Increases (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for psoc6)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
… after #28104 (#28276) Co-authored-by: Andrei Litvin <[email protected]>
… after project-chip#28104 (project-chip#28276) Co-authored-by: Andrei Litvin <[email protected]>
This PR has caused a regression in my linux-based bridge application. For some reason, the report engine keeps generating a The problem appears with c9ce7f2, it does not happen with the immediately preceeding commit fe4c679, everything else untouched. See a log excerpt of the repeating part below. I tried to debug into it, but with no success. The only thing I found so far is that the faulty report has a curiously small payload of only 11 bytes.
|
@plan44 Please file an issue? Something is very broken here... This message:
is wrong. It's happening before the subscription has been set up, but not on the subscription-setup exchange, which is why the other side is rejecting it: it carries a subscription id which is not for a subscription that "exists" yet. |
@plan44 Thanks for the comprehensive description, I'm working on solving this as soon as possible. |
ReadHandler now offload the timing logic to the ReportScheduler
ReportScheduler lives in the Server and is injected in the IM engine.
Added a static report scheduler to use in all test relying on the IM engine, also added test flags in ReportScheduler replace ReadHandler timing flags for testing purpose only (TestReadInteraction relies on flags rather than timing at some points).
Refactored TestReadInteraction also manually calls the nodes callback when the flags force the handlers in a reportable state.
fixes #27672
partly addresses #25085