-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ReplacementProductList in resource monitoring #27877
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliffamzn
force-pushed
the
rep_compat
branch
2 times, most recently
from
July 11, 2023 04:40
0eae56d
to
d3448bf
Compare
src/app/zap-templates/zcl/data-model/chip/resource-monitoring-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/resource-monitoring-cluster.xml
Outdated
Show resolved
Hide resolved
Adding the replacement product list array in the resource monitoring cluster. Fixes issue project-chip#27571 Code generation ran with zap_regen_all.py
PR #27877: Size comparison from 17efcdd to a5acc99 Increases above 0.2%:
Increases (18 builds for bl602, bl702, bl702l, cc32xx, esp32, linux, psoc6, telink)
Decreases (10 builds for bl602, bl702l, esp32, nrfconnect, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
carol-apple,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex and
harsha-rajendran
July 12, 2023 01:56
pullapprove
bot
requested review from
mhazley,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
plauric,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
July 12, 2023 01:56
PR #27877: Size comparison from 7fc3ccb to 63bb0c6 Increases above 0.2%:
Increases (19 builds for bl702, bl702l, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Decreases (7 builds for bl602, bl702, esp32, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jul 12, 2023
andy31415
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the replacement product list array in the resource monitoring cluster.
Fixes issue #27571
Implements the ReplacementProductList.
Code generation ran with zap_regen_all.py