Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ReplacementProductList to Resource Monitoring Cluster Definition #27571

Closed
p0fi opened this issue Jun 30, 2023 · 2 comments · Fixed by #27877
Closed

Add ReplacementProductList to Resource Monitoring Cluster Definition #27571

p0fi opened this issue Jun 30, 2023 · 2 comments · Fixed by #27877
Assignees
@cliffamzn
Labels
app-clusters Application cluster work cluster xml for 1.2 Spec XML align SDK XML does not match the spec (including naming, etc) spec Mismatch between spec and implementation v1.2
Milestone
1.2

Comments

@p0fi
Copy link
Contributor

p0fi commented Jun 30, 2023

📖 Description

The discussion around the replacement product list caused spec changes. It added 2 new attributes. This issue should only add the ReplacementProductList to the cluster definition since LastChangedTime is being handled in #27570
@p0fi p0fi added app-clusters Application cluster work v1.2 Spec XML align SDK XML does not match the spec (including naming, etc) cluster xml for 1.2 labels Jun 30, 2023
@robszewczyk
Copy link
Contributor

Possible dup of #27562. If tracking this one for ongoing work / resolution, please note this issue number in the spec PR

@p0fi
Copy link
Contributor Author

p0fi commented Jun 30, 2023 •
edited
Loading

This is no straight forward dup. It's by design split up into more than one issue (see #27570) to track the work and help make the PRs the right scope and size. Although I was not aware of #27562 existing :)

This was referenced Jun 30, 2023
Closed
Closed
@tobiasgraf tobiasgraf mentioned this issue Jul 5, 2023
Merged
@bzbarsky-apple bzbarsky-apple mentioned this issue Jul 6, 2023
Closed
@bzbarsky-apple bzbarsky-apple added the spec Mismatch between spec and implementation label Jul 6, 2023
@p0fi p0fi added this to the 1.2 milestone Jul 7, 2023
cliffamzn added a commit to cliffamzn/connectedhomeip that referenced this issue Jul 11, 2023
@cliffamzn
Adding ReplacementProductList in resource monitoring
6af689a 
Adding the replacement product list array in the resource monitoring
cluster.

Fixes issue project-chip#27571

Code generation ran with zap_regen_all.py
@cliffamzn cliffamzn mentioned this issue Jul 11, 2023
Merged
@cliffamzn cliffamzn linked a pull request Jul 11, 2023 that will close this issue
Adding ReplacementProductList in resource monitoring #27877
Merged
cliffamzn added a commit to cliffamzn/connectedhomeip that referenced this issue Jul 11, 2023
@cliffamzn
Adding ReplacementProductList in resource monitoring
0eae56d 
Adding the replacement product list array in the resource monitoring
cluster.

Fixes issue project-chip#27571

Code generation ran with zap_regen_all.py
cliffamzn added a commit to cliffamzn/connectedhomeip that referenced this issue Jul 11, 2023
@cliffamzn
Adding ReplacementProductList in resource monitoring
d3448bf 
Adding the replacement product list array in the resource monitoring
cluster.

Fixes issue project-chip#27571

Code generation ran with zap_regen_all.py
cliffamzn added a commit to cliffamzn/connectedhomeip that referenced this issue Jul 11, 2023
@cliffamzn
Adding ReplacementProductList in resource monitoring
a5acc99 
Adding the replacement product list array in the resource monitoring
cluster.

Fixes issue project-chip#27571

Code generation ran with zap_regen_all.py
@mergify mergify bot closed this as completed in #27877 Jul 12, 2023
mergify bot pushed a commit that referenced this issue Jul 12, 2023
@cliffamzn
Adding ReplacementProductList in resource monitoring (#27877)
6e696b6 
Adding the replacement product list array in the resource monitoring
cluster.

Fixes issue #27571

Code generation ran with zap_regen_all.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cliffamzn cliffamzn

Labels
app-clusters Application cluster work cluster xml for 1.2 Spec XML align SDK XML does not match the spec (including naming, etc) spec Mismatch between spec and implementation v1.2
Projects
[Enhancements] Spec/XML Alignment
Archived in project
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Adding ReplacementProductList in resource monitoring cliffamzn/connectedhomeip
4 participants
@robszewczyk @p0fi @bzbarsky-apple @cliffamzn