-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase our "waiting for subscription to time out" timer slack. #27870
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:more-slack-TestRead
Jul 11, 2023
Merged
Increase our "waiting for subscription to time out" timer slack. #27870
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:more-slack-TestRead
Jul 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100ms is not enough: we have tests losing the timeslice for that long, and then we break out of our "waiting for timeout" loop before we process the firing of the timeout timer. Fixes project-chip#27829
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
July 10, 2023 19:01
pullapprove
bot
requested review from
lpbeliveau-silabs,
LuDuda,
mhazley,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
p0fi,
plauric,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
July 10, 2023 19:01
PR #27870: Size comparison from c7d9a11 to 30fb1b6 Increases (12 builds for bl602, cyw30739, efr32, esp32, qpg, telink)
Decreases (7 builds for bl702, bl702l, efr32, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
100ms is not enough: we have tests losing the timeslice for that long, and then we break out of our "waiting for timeout" loop before we process the firing of the timeout timer.
Fixes #27829