-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor network commissioning setup in Linux example apps. #27861
Merged
mergify
merged 2 commits into
project-chip:master
from
bzbarsky-apple:linux-network-commissioning
Jul 12, 2023
Merged
Refactor network commissioning setup in Linux example apps. #27861
mergify
merged 2 commits into
project-chip:master
from
bzbarsky-apple:linux-network-commissioning
Jul 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock and
kkasperczyk-no
July 10, 2023 15:55
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
younghak-hwang
July 10, 2023 15:55
PR #27861: Size comparison from c7d9a11 to b1f591b Increases (1 build for qpg)
Decreases (2 builds for cc32xx, qpg)
Full report (4 builds for cc32xx, mbed, qpg)
|
Linux (and Mac) example apps were inconsistent in terms of how they handled network commissioning, with most of them being buggy in terms of not setting things up properly on Mac or not setting things up properly at all. The changes here move the setup into AppMain, so it's handled consistently across all example apps.
bzbarsky-apple
force-pushed
the
linux-network-commissioning
branch
from
July 10, 2023 16:25
b1f591b
to
b6914ca
Compare
PR #27861: Size comparison from c7d9a11 to b6914ca Increases above 0.2%:
Increases (27 builds for bl602, bl702, cc32xx, cyw30739, efr32, linux, nrfconnect, psoc6, telink)
Decreases (19 builds for bl702, bl702l, cc32xx, efr32, esp32, linux, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
krypton36
approved these changes
Jul 10, 2023
cliffamzn
approved these changes
Jul 12, 2023
andy31415
reviewed
Jul 12, 2023
andy31415
reviewed
Jul 12, 2023
andy31415
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux (and Mac) example apps were inconsistent in terms of how they handled network commissioning, with most of them being buggy in terms of not setting things up properly on Mac or not setting things up properly at all.
The changes here move the setup into AppMain, so it's handled consistently across all example apps.