-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Implement Java TLV Decoder API #27586
Merged
mergify
merged 9 commits into
project-chip:master
from
joonhaengHeo:implement_android_decode_tlv
Jul 18, 2023
Merged
[Android] Implement Java TLV Decoder API #27586
mergify
merged 9 commits into
project-chip:master
from
joonhaengHeo:implement_android_decode_tlv
Jul 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kkasperczyk-no and
ksperling-apple
July 3, 2023 05:26
pullapprove
bot
requested review from
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
July 3, 2023 05:26
PR #27586: Size comparison from 7ae5919 to 1b1e501 Increases (10 builds for bl702, bl702l, psoc6, qpg, telink)
Decreases (5 builds for esp32, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #27586: Size comparison from a9773c9 to 6716127 Increases (11 builds for cyw30739, esp32, nrfconnect, telink)
Decreases (12 builds for bl602, bl702, cc32xx, cyw30739, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
reviewed
Jul 5, 2023
yufengwangca
approved these changes
Jul 6, 2023
yunhanw-google
approved these changes
Jul 7, 2023
PR #27586: Size comparison from c80c789 to 007e61b Increases (8 builds for bl702l, psoc6, qpg, telink)
Decreases (9 builds for bl602, bl702, cc32xx, esp32, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@joonhaengHeo we added ktfmt and detekt support, this needs some merge fixes. |
… implement_android_decode_tlv
…o/connectedhomeip into implement_android_decode_tlv
pullapprove
bot
requested review from
hicklin,
mhazley,
p0fi,
plauric,
tima-q and
tobiasgraf
July 10, 2023 00:09
PR #27586: Size comparison from 488aabf to d10fe45 Increases (8 builds for bl602, bl702l, esp32, psoc6, qpg, telink)
Decreases (9 builds for cyw30739, efr32, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Jul 21, 2023
* Implement Android TLV Decoder * Restyled by google-java-format * Restyled by clang-format * fix merge conflict * restyle --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For decouple generated API(#27398), this API has to use in application Layer.
(e.g., ClusterInfoMapping.java)
This APIs can parse tlv data to ChipStructs objects.